From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518DBC2BA19 for ; Wed, 15 Apr 2020 15:44:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 126832137B for ; Wed, 15 Apr 2020 15:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZxRt1cdy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AKVoTgD+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 126832137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S4q39/FHlD0CJyUfHd5Cp3gtuLt6Z/MGa1j7BizbcQQ=; b=ZxRt1cdyg1IsR6 76mqxNcYUWdgGCIe8hKTG3dJmZMl9MOFWx2qwevADiEMBMSWxQPrMQp721VG1fc11pcHIfY3S40D3 PGvLm/cJ8TJIamyQU1ezEa2S0Hdhivy6wHrYtONnkb/62cGrJyHoCZUZ3bqfcWXxGJ6jHJVN2Nrq6 XxDGWnTtPi9H3VwUa9HUbmnZbcGNnDF11sD+UYEezVy0kyhyxsVRV0vMwL/zlnyiK1owr6CzPJicL EdhF/xLi0QjAAe3aUghXQYO1t4a5p50c/Fl50oiPmy54o0pjxt0jodNISqvS3vJZc/6Nx+3v66ldd bQS4qj3Bcgpvs5mZk5mQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOkDM-0000d6-4I; Wed, 15 Apr 2020 15:44:36 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOkDG-0000bU-FZ for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 15:44:33 +0000 Received: by mail-pj1-x1043.google.com with SMTP id e16so19460pjp.1 for ; Wed, 15 Apr 2020 08:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W+ikqrmBIBEKvVkXBn0UllA+OtUbb2X28KHF+kd9Sus=; b=AKVoTgD+v3LRySKFXD0u43wjuBan3xtaU0vntmRP548nKCKRJn0SCAgfW2hl+sug79 xeeqyfuxOZgKSwZexJXDW24RXk+8RRO3rl1fPT5DUYrHkg6LRxn2QntT1+3CxgcBplIQ PlGTKYDsfv4jrzvd5bekUSg8KqL742ven3KBA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W+ikqrmBIBEKvVkXBn0UllA+OtUbb2X28KHF+kd9Sus=; b=j40J2sqIXX4+IoDAw2tZfYxOwA3kHaxCh/iH5SsxD7E3/RT0NtyT2syxKwLfS3Y8fB Hh+W+Vm1QArvu0Vz9Y+nWaFnN0s3YluUK1XijdJ/Kz+yAYlHk835udmj0yAVhRkqoPqs Zllz/4gcFDY6ZG5RSz1tGTgqTFTOgV5RwibYACgybcmpr6CejAwpkYGRIaANyc7b+Mo0 /YqoJ15sWR3mkmbETjxKLXcyBUdLE9LwHdkF+hJPkjwSiZt7nJhz9lZEn5nXxWF1cYan 3iwOiqZz5+Ee2W0doACvEC0FGw/9NHq+UgAEo8tlVdDlGrETpOziY1k40bB27EgjxCoA tpkw== X-Gm-Message-State: AGi0PuYetHCFNGHrJZgfLHKZmEVvJ5SuVi+1bhvFeBESbDxP4jV/4KpB MJkbSr+tE4QRe9Ea0vIRdvFKFg== X-Google-Smtp-Source: APiQypIpRyHaEbePO5FqjfTHo4ISu3LJ/Zlc8dY0TXjNWuA2eQxr4cd+H9NX2VZ+/N1gu6NTS64z9g== X-Received: by 2002:a17:902:9b8f:: with SMTP id y15mr5654954plp.169.1586965468363; Wed, 15 Apr 2020 08:44:28 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f30sm15052172pje.29.2020.04.15.08.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 08:44:27 -0700 (PDT) Date: Wed, 15 Apr 2020 08:44:26 -0700 From: Kees Cook To: Ard Biesheuvel Subject: Re: [PATCH] ARM: do not assemble iwmmxt.S with LLVM toolchain Message-ID: <202004150833.E2E9A89E0@keescook> References: <20200409232728.231527-1-caij2003@gmail.com> <20200410123301.GX25745@shell.armlinux.org.uk> <202004141258.6D9CB92507@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_084430_559057_7D9575C7 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , Peter Smith , Stefan Agner , David Howells , Mauro Carvalho Chehab , Manoj Gupta , Benjamin Gaignard , "Joel Fernandes \(Google\)" , Kristof Beyls , Jian Cai , Bartosz Golaszewski , Ilie Halip , Masahiro Yamada , Russell King - ARM Linux admin , Krzysztof Kozlowski , clang-built-linux , Sami Tolvanen , Luis Lozano , Masami Hiramatsu , Arnd Bergmann , "Steven Rostedt \(VMware\)" , Jian Cai , Stephen Hines , Doug Anderson , Dan Williams , Linux ARM , Greg Kroah-Hartman , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Patrick Bellasi , "Eric W. Biederman" , Tejun Heo , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 12:32:17PM +0200, Ard Biesheuvel wrote: > To reiterate my point: I strongly prefer minor asm surgery over > elaborate Kconfig plumbing if it means we can retain the functionality > even when using LLVM tools. In particular, the use of macros to > implement missing ISA support should be considered before any other > solution, as these are already being used widely across architectures > to fill in such gaps. Yeah, this seems like the right place to start from. It sounded like there were cases where the people with knowledge needed to accomplish the macro creation were not always immediately available. But, yes, let's get iwmmxt fixed up. > This code has been around since 2004. It has never been possible to > assemble it with Clang's assembler. So the only thing this patch gives > you is the ability to switch from a .config where IWMMXT was disabled > by hand to one where it gets disabled automatically by Kconfig. Right -- I meant "let's fix iwmmxt with macro magic" not "let's disable it". I did want to point out the Kconfig disabling may be needed in other cases. > So what hard-won ground are we losing here? Did IWMMXT recently get > enabled in a defconfig that you care about? It's a CI's ability to do randconfig builds to catch new stuff. (i.e. where "disabled by hand" isn't part of the process.) Since there are multiple CIs doing multi-architecture builds we need to get these things fixed upstream, not a CI's local patch stacks or Kconfig whitelists, etc. And when the expertise isn't available to fix arch-specific stuff, Kconfig negative depends seems like a reasonable middle ground. I, too, prefer fixes that allow Clang to do its work without wrecking things for GNU as. > I am not disagreeing with you here, and I have worked with Nick, > Nathan and Stefan on numerous occasions to get Clang related build > issues solved. Yup! Totally; this thread just looked very familiar to me from doing treewide stuff and I didn't want what I thought looked like the core points to get lost in the details. :) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel