From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28F5C2BB55 for ; Wed, 15 Apr 2020 10:10:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7649620787 for ; Wed, 15 Apr 2020 10:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QcJ8V1oc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7649620787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3YNyVUnn9Vwe8i2NRHYkVwTkdjTmQgUJGhKl3hrbz7k=; b=QcJ8V1oceiW371 wXB2/pTaMTSuBE8crcSSz4Twx8B59YHN+JW70oxd1fMDOFOr2Yenth2o/IaPPLZl3clfiSZotwIfB P1cF+dmJq8hLf4lQM70PpjMPrfKmFGvNZ753ngiru9w9ev3vgsnXAZi1af+Lgv42dXHuV+Sfxv2We es+7gI7nSPypGp/GxIiDYPCo/lSuAHcMPVNoH1fkSqLqynYkv4Rpf9Vro2nYMrWRGt0YpLuegj5EU EFC643iLVB6Br2RBPyeGJ1uCGZjfftx3Gs7wkOnOe8JLUz59Z3cAgkuP+JWkSpIXGwhaQr2Tk/no4 e+Y0d2ZgyAJWtAk8fBcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOf0C-0001Rw-MS; Wed, 15 Apr 2020 10:10:40 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOezq-0007FD-1E; Wed, 15 Apr 2020 10:10:20 +0000 IronPort-SDR: DPVALde6wj/5LZcqQECD8bn6DV6Brk2fCUdQte0iVYxT63eA12Y4e/MH1yoJVThflbNiJ8SsWJ XWK00/RXM0yQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 03:10:11 -0700 IronPort-SDR: aGu6dAfqMFsukgAr+d5F7tEybqhEX5jUtoALJ7v7+QFrqzpee8vLQhMbjxsJBZ5kljzZ41to/W x1dxBc/0aBtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,386,1580803200"; d="scan'208";a="298954877" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by FMSMGA003.fm.intel.com with ESMTP; 15 Apr 2020 03:10:02 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jOezb-000kNp-9a; Wed, 15 Apr 2020 13:10:03 +0300 Date: Wed, 15 Apr 2020 13:10:03 +0300 From: Andy Shevchenko To: Matti Vaittinen Subject: Re: [PATCH v10 11/11] power: supply: KConfig cleanup default n Message-ID: <20200415101003.GS34613@smile.fi.intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_031018_093392_D539C3F6 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrei Stefanescu , Heiko Stuebner , "Rafael J. Wysocki" , Tony Lindgren , Linus Walleij , Brendan Higgins , Liam Girdwood , Andreas Kemnade , "Angelo G. Del Regno" , Hsin-Hsiung Wang , linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, Axel Lin , Gregory CLEMENT , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Markus Reichl , Bartosz Golaszewski , Chen-Yu Tsai , Andy Gross , markus.laine@fi.rohmeurope.com, Adam Thomson , devicetree@vger.kernel.org, Charles Keepax , mazziesaccount@gmail.com, linux-arm-msm@vger.kernel.org, Richard Fitzgerald , Mark Brown , linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Support Opensource , Baolin Wang , Sangbeom Kim , Greg Kroah-Hartman , linux-pm@vger.kernel.org, Randy Dunlap , Sebastian Reichel , linux-kernel@vger.kernel.org, mikko.mutanen@fi.rohmeurope.com, Vinod Koul , Rob Herring , patches@opensource.cirrus.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 08:24:14AM +0300, Matti Vaittinen wrote: > The "default n" is not needed. Clean the KConfig by removing > "default n". > Reviewed-by: Andy Shevchenko > Signed-off-by: Matti Vaittinen > --- > > This was pointed to me first by Randy Dunlap during v4 review. > I cleaned the BD99954 back then. > > Also Andy Shevchenko mentioned this to me. So as I was > changing the file anyways... Please just drop this patch out > of the series if you're not Ok with this. > > drivers/power/supply/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index ec028e47c3c2..04821d8c9e43 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -660,7 +660,6 @@ config CHARGER_RT9455 > config CHARGER_CROS_USBPD > tristate "ChromeOS EC based USBPD charger" > depends on CROS_USBPD_NOTIFY > - default n > help > Say Y here to enable ChromeOS EC based USBPD charger > driver. This driver gets various bits of information about > @@ -696,7 +695,6 @@ config CHARGER_BD70528 > tristate "ROHM bd70528 charger driver" > depends on MFD_ROHM_BD70528 > select LINEAR_RANGES > - default n > help > Say Y here to enable support for getting battery status > information and altering charger configurations from charger > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =] -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel