From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23752C2BB55 for ; Wed, 15 Apr 2020 12:29:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA0952074F for ; Wed, 15 Apr 2020 12:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gtyBSZf0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA0952074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mLG8RB9h7HMRbmnrnyZ3A6H2BAardxWusV0dSuJ2KtM=; b=gtyBSZf0gThn2q0w8TVj8tKKr JawRd771Ry/vU94mq+/otOnJiJi00BwNzvtwC5B/YJTkez+GyTsViSxnZQGglKG7bx87FYiHjhSh9 n0vFCM83cMaljHbs6fl5mA6qo9WCuDQgs+wmAm1wAl9NWbRitCxURENPGp60cQwgfcy7pNj0GvNfG LCuSa/E9C8sLH31RdToNrJrkE4R4PRdNEzaExXCOIb5TdX9qVypbZXmWxMRYgynPdqDUrl1Wup/EV pS/OersUNGC9v20CF6DGrjmgop5p0EuYfEBVONG+bPpt6mHyjcuZwbA1wBHHTawnLNYPYRyxoye1G uzaIPxqmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhAt-0005I6-FR; Wed, 15 Apr 2020 12:29:51 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOhAo-0005BS-IZ for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 12:29:48 +0000 Received: from localhost (p54B33507.dip0.t-ipconnect.de [84.179.53.7]) by pokefinder.org (Postfix) with ESMTPSA id 949342C1FF1; Wed, 15 Apr 2020 14:29:45 +0200 (CEST) Date: Wed, 15 Apr 2020 14:29:45 +0200 From: Wolfram Sang To: Rayagonda Kokatanur Subject: Re: [PATCH v1 1/1] i2c: iproc: generate stop event for slave writes Message-ID: <20200415122945.GC910@ninjato> References: <20200322182019.32493-1-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20200322182019.32493-1-rayagonda.kokatanur@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_052946_783045_C3639E47 X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lori Hikichi , Scott Branden , Ray Jui , linux-kernel@vger.kernel.org, Shreesha Rajashekar , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, Nishka Dasgupta , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4163222790778291480==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4163222790778291480== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="96YOpH+ONegL0A3E" Content-Disposition: inline --96YOpH+ONegL0A3E Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote: > When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP > event to i2c_client. >=20 > Fixes:=C2=A0c245d94ed106 ("i2c: iproc: Add multi byte read-write support = for slave mode") > Signed-off-by: Rayagonda Kokatanur Just to make sure: That means the HW has already detected a STOP condition on the bus? > --- > drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-= bcm-iproc.c > index 30efb7913b2e..b58224b7ba79 100644 > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_= i2c_dev *iproc_i2c, > value =3D (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK); > i2c_slave_event(iproc_i2c->slave, > I2C_SLAVE_WRITE_RECEIVED, &value); > + if (rx_status =3D=3D I2C_SLAVE_RX_END) > + i2c_slave_event(iproc_i2c->slave, > + I2C_SLAVE_STOP, &value); > } > } else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) { > /* Master read other than start */ > --=20 > 2.17.1 >=20 --96YOpH+ONegL0A3E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl6W/jUACgkQFA3kzBSg Kba56w//YyHFH3d77V7+5og30eKP1+eGDNLfHEL29jHAg9fqHDj+PlN8Z6kWxoir 2w/sI1a0Yj3e/G1q3G2bL7gWErqYjOMTHP8gYVJQSdNoFTMF3i1ynawW6x7aAXh6 HOLy/0ijpt52+YGlFvfwDdtzYf1lc6t5nBiqp3OiK7PKLWS6Oj88SjtImTwIFpZD yW3RdHndNZ7dj1nG+Ny+nVIlLRjPBPX415uKOgpcw759SGezT07llFsD65sK9c/r hWWHgKLq+l9bzFd3LQTF9WwqHyUzx8RTpiJ0U6hwh9PPTcRwuuomynDUdS4R0EeA PTYPmPrxpI6psoTJFAEKD3VTYS/QymiatT+TKmvZZXiGTStG3zIK2THaLPIPV93U UIwRD1DOPeSPX/EzBuZ7D31EYhjfmsJzpbIPgryIj4AFS567yrm7lwWMVlUwvQ5A GGyPrPDHraPDRibrDts+i3YXXOZrIrHJ6OVK25xoz3HcRYULe7Ik5t2YocwmHSHa ymjlay9LXDG0fTqjmo7KvAZ9Iv992jKH7an2n1m+TEWNZ6yVqQvJ304NHoDmbydO 05SgO8qnX7eAeGiNKls7H8J8+3uY3cEMiOLdQlccWpUZEP6fCN0fkFlR+oop2IgJ EKuHtdrx8QEMYgiRI8OuEqwINsqawezG89uWHCCSENvhh9Hu73s= =PQOf -----END PGP SIGNATURE----- --96YOpH+ONegL0A3E-- --===============4163222790778291480== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4163222790778291480==--