From: Cornelia Huck <cohuck@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: "Wanpeng Li" <wanpengli@tencent.com>,
kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
linux-kernel@vger.kernel.org,
"Paul Mackerras" <paulus@ozlabs.org>,
kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
"Janosch Frank" <frankja@linux.ibm.com>,
"Marc Zyngier" <maz@kernel.org>, "Joerg Roedel" <joro@8bytes.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
linux-mips@vger.kernel.org,
"Julien Thierry" <julien.thierry.kdev@gmail.com>,
"Suzuki K Poulose" <suzuki.poulose@arm.com>,
kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Jim Mattson" <jmattson@google.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Morse" <james.morse@arm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>
Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place
Date: Wed, 15 Apr 2020 18:20:37 +0200 [thread overview]
Message-ID: <20200415182037.521a92b2.cohuck@redhat.com> (raw)
In-Reply-To: <20200414155625.20559-1-eesposit@redhat.com>
On Tue, 14 Apr 2020 17:56:25 +0200
Emanuele Giuseppe Esposito <eesposit@redhat.com> wrote:
> The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple
> files, each used by a different architecure to initialize the debugfs
> entries for statistics. Since they all have the same purpose, they can be
> unified in a single common definition in include/linux/kvm_host.h
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> arch/arm64/kvm/guest.c | 23 ++---
> arch/mips/kvm/mips.c | 61 ++++++------
> arch/powerpc/kvm/book3s.c | 61 ++++++------
> arch/powerpc/kvm/booke.c | 41 ++++----
> arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++-------------------
> arch/x86/kvm/x86.c | 80 +++++++--------
> include/linux/kvm_host.h | 5 +
> 7 files changed, 231 insertions(+), 243 deletions(-)
Adds a bit of churn, but the end result does look nicer. Looks sane,
but did not review in detail.
Acked-by: Cornelia Huck <cohuck@redhat.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-04-15 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:56 [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place Emanuele Giuseppe Esposito
2020-04-15 6:36 ` Philippe Mathieu-Daudé
2020-04-15 8:30 ` Emanuele Giuseppe Esposito
2020-04-15 11:37 ` Claudio Imbrenda
2020-04-15 16:20 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415182037.521a92b2.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=eesposit@redhat.com \
--cc=f4bug@amsat.org \
--cc=frankja@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).