From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5F8C352BE for ; Thu, 16 Apr 2020 13:50:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 140EB20732 for ; Thu, 16 Apr 2020 13:50:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C9+0Ove9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="f5c9A4Fn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 140EB20732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2T5aT2ZYsdUD65wqEv2vTAWepzr6eQ75wUqRZv2shJo=; b=C9+0Ove9olF6iT jp322evNKFVGvbxyRCL2eLpjWCByVwFqQmycxVgwLHxO9JcQEN29cWv/SV9M2wFgrLioaTNEK98oX p/64LqxGeIcdmwmBy+rF7+YXjnFICyg5b9eRhe23lBKV+ejPwAumnCQzDtHw3yPCC6G5t9PA2LTR0 fqvCSNwhgJQlCk9LEzRpeV7vCa5Ogx5gEJAMIyfI4B4iVfdRUbl5V9Mo9F9ULdFGsgslhq09Ts8Ow DoItjkDiLpk6++Ts0GpLK1I82zAw/G1JT12Hj9QAyAS75TWFlOxK5TihuIRmTdYxvAxmaWpZIYrhe PXEAVP3EX6bRh0tL/ljA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP4up-0000Nx-U7; Thu, 16 Apr 2020 13:50:51 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP4un-0000NN-4F for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 13:50:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EF/f9myVVbgrLxXwzUMzNnUxGooj5hG2873Zghg3qio=; b=f5c9A4Fn3ySTK1wzQTyIowkDaW o2L99bBr1lFDYtL4BfBJGLRkjJyMo2p4ZrbupRO58aeykvzS/cr/UeCXY+d23IiSHcp6i7CeihRhq jZli5GjTIUplIniSlLGL4h7pv3GwqBpq82wY+p3xcMk7emkYyilPwPjrq7EfOWM4IAck=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jP4ud-0034yA-Ey; Thu, 16 Apr 2020 15:50:39 +0200 Date: Thu, 16 Apr 2020 15:50:39 +0200 From: Andrew Lunn To: Linus Walleij Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416135039.GL657811@lunn.ch> References: <20200329104549.GX25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_065049_163014_16BD8F88 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , "open list:GPIO SUBSYSTEM" , Gregory Clement , Russell King - ARM Linux admin , linux-pwm@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 16, 2020 at 09:51:37AM +0200, Linus Walleij wrote: > On Sun, Mar 29, 2020 at 12:46 PM Russell King - ARM Linux admin > wrote: > > > This series adds support for the fan PWM output on the Clearfog GT8K > > platform, and can potentially be extended to the Macchiatobin. > > The gpio changes all look fine to me +/- fixes for review comments. > > Could the MVEBU maintainers provide some feedback? Hi Linus I took a quick look at this when it was first posted. I also wrote the PWM support in this driver. The hardware is mostly a GPIO driver, but it has some basic PWM facilities. It is not possible to cleanly split it into two drivers, which is why it has the current structure. And the PWM maintainers ask that the PWM parts be listed in MAINTAINERS as such, so they got to know about any changes. Clocking with Marvell devices has always been interesting. Core IP like this gets reused between different generations of SoCs. The original Orion5x had no clock control at all. Latter SoCs have had more and more complex clock trees. So care has to be taken to not change old behaviour when adding support for new clocks. So Russell 2/6 patch looks good to me, and Uwe request could break on some SoCs. It would need testing on a lot of SoCs, with and without PWM support. I assume Russell will at some point repost without the RFC tag. At that point i will take a second look and add Reviewed-by. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel