[PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe()

[PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe()

[Tang Bin]

In the function lpi2c_imx_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant message
here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c92b56485..ee16e7e22 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -557,10 +557,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev)
 		return PTR_ERR(lpi2c_imx->base);
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "can't get irq number\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	lpi2c_imx->adapter.owner	= THIS_MODULE;
 	lpi2c_imx->adapter.algo		= &lpi2c_imx_algo;
-- 
2.20.1.windows.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe()

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

On Thu, Apr 16, 2020 at 10:05:29PM +0800, Tang Bin wrote:
> In the function lpi2c_imx_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
> 
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

Please make only one patch for all the drivers in the i2c subsystem.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel