From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABF8C2BB55 for ; Thu, 16 Apr 2020 14:12:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B15132076D for ; Thu, 16 Apr 2020 14:12:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j2d7kcIU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B15132076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G9DJCYd1Ty/wSnu7f5+02HA9V/QfII5E/xim5iPGkHM=; b=j2d7kcIU/QsBvWdKMvlpW3gl5 +Rx1sXBlAvsbFb8QO+UF+hMuV56PAUIDHa681IVRgngOi5f/HOpn6iNT/+MsoZGmrQBb/VdygxhGO VBX6jrA92AUDxHMkrNEG7VpjOp2B0dZBLWtIMyLCruElY8BoU/VSHfdu9vyUtosXUcn5r9J54n1pr +Hx0gYNhJv9H9sIfNb9g4WU4DZAswm6SliIZoOvSKDavyQyOXngBzWJDin4aYCw2Tmx+NiWJ2sqEn nR3bz7wyNTpc64xEcH8ZzC0xCFxbrNCjRYO6HuCc82xVKNnGjqPEKS6AbxyXnkvMDJdBsfzbx04T0 FF3Q3WSyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5FX-0000We-DP; Thu, 16 Apr 2020 14:12:15 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5FS-0000VD-UJ; Thu, 16 Apr 2020 14:12:13 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7DB971C001E; Thu, 16 Apr 2020 14:12:05 +0000 (UTC) Date: Thu, 16 Apr 2020 16:12:05 +0200 From: Paul Kocialkowski To: Johan Jonker Subject: Re: [PATCH 2/4] arm64: dts: rockchip: Add RGA support to the PX30 Message-ID: <20200416141205.GK125838@aptenodytes> References: <20200416115047.233720-1-paul.kocialkowski@bootlin.com> <20200416115047.233720-3-paul.kocialkowski@bootlin.com> <478f0a8b-f819-62f4-83b8-27918c4c2431@gmail.com> <20200416132442.GI125838@aptenodytes> <20200416135519.GJ125838@aptenodytes> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_071211_248033_F7FF9109 X-CRM114-Status: GOOD ( 26.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , linux-kernel@vger.kernel.org, Rob Herring , Hans Verkuil , linux-rockchip@lists.infradead.org, Jacob Chen , Thomas Petazzoni , Mauro Carvalho Chehab , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============3430888771668554521==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3430888771668554521== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IA03tywDYuoVKXrw" Content-Disposition: inline --IA03tywDYuoVKXrw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 16 Apr 20, 16:02, Johan Jonker wrote: > On 4/16/20 3:55 PM, Paul Kocialkowski wrote: > > Hi, > >=20 > > On Thu 16 Apr 20, 15:44, Johan Jonker wrote: > >> On 4/16/20 3:24 PM, Paul Kocialkowski wrote: > >>> Hi, > >>> > >>> On Thu 16 Apr 20, 15:02, Johan Jonker wrote: > >>>> Hi Paul, > >>>> > >>>> The conversion of rockchip-rga.txt to rockchip-rga.yaml by myself ju= st > >>>> has been approved by robh. > >>> > >>> Huh, I looked around for ongoing related work but missed it. > >>> I'll definitely rebase on top of your series and use the yaml descrip= tion > >>> instead. Thanks! > >>> > >>>> Maybe place dts patches at the end of a patch serie. > >>>> Could you include a &rga patch if your device is supported in mainli= ne, > >>>> so we can test with: > >>>> make ARCH=3Darm64 dtbs_check > >>>> DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/media/rockchip-r= ga.yaml > >>> > >>> I tested with the PX30 EVB so I can surely add a node there if that t= urns > >>> out necessary (see below). > >>> > >>>> Johan > >>>> > >>>> On 4/16/20 1:50 PM, Paul Kocialkowski wrote: > >>>>> The PX30 features a RGA block: add the necessary node to support it. > >>>>> > >>>>> Signed-off-by: Paul Kocialkowski > >>>>> --- > >>>>> arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++++++++++ > >>>>> 1 file changed, 11 insertions(+) > >>>>> > >>>>> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/bo= ot/dts/rockchip/px30.dtsi > >>>>> index 75908c587511..4bfbee9d4123 100644 > >>>>> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > >>>>> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > >>>>> @@ -1104,6 +1104,17 @@ vopl_mmu: iommu@ff470f00 { > >>>>> status =3D "disabled"; > >>>>> }; > >>>>> =20 > >>>>> + rga: rga@ff480000 { > >>>>> + compatible =3D "rockchip,px30-rga"; > >>>>> + reg =3D <0x0 0xff480000 0x0 0x10000>; > >>>>> + interrupts =3D ; > >>>>> + clocks =3D <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE= >; > >>>>> + clock-names =3D "aclk", "hclk", "sclk"; > >>>>> + resets =3D <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; > >>>>> + reset-names =3D "core", "axi", "ahb"; > >>>>> + power-domains =3D <&power PX30_PD_VO>; > >>>> > >>>> status =3D "disabled"; > >>> > >>> As of 5.6, the rk3399 has the node enabled by default. Did that chang= e? > >> > >> 'status' disappeared during review for rk3399 between v2 and v3, but > >> doesn't mention the reason. If someone can give more info here? > >> > >> https://lore.kernel.org/lkml/1500101920-24039-5-git-send-email-jacob-c= hen@iotwrt.com/ > >> > >> https://lore.kernel.org/lkml/1501470460-12014-5-git-send-email-jacob-c= hen@iotwrt.com/ > >> > >>> > >>> Since it's a standalone block that has no I/O dependency, I don't rea= lly see > >>> the point of disabling it by default. > >> > >> Vop, hdmi and other video devices are also disabled. > >> Follow the rest I think... > >=20 > > Well, these blocks do have related I/O ports so it makes sense not to e= nable > > them by default because of pinmux, or because there might be no connect= or > > populated/routed. > >=20 > > For a memory to memory internal block, I don't see any reason why. > > It's definitely not board-specific and having to add these nodes for ev= ery board > > that has them is kind of a pain and might be overlooked. This will easi= ly result > > in the feature not being available for end users without having to chan= ge the > > dt. > >=20 > > Also, the vpu node is always enabled on rockchip (and sunxi) platforms. > > I think these are better examples to follow. >=20 > From PX30 TRM-Part1: >=20 > Power domain is shared by vop and dsi. > It's up to the user what blocks he/she enables and what power it uses. >=20 > PD_VO: VOP_M, VOP_S, RGA and DSI Hum, there is no direct correlation between "node is enabled in dt" and "re= lated hardware block consumes power". And removing nodes from dt is certainly not= an appropriate way to do power management! Device-tree is a way to represent t= he hardware, not a configuration interface (well, besides the /chosen node). Besides, the RGA driver seems to have good runtime pm support, so be assured that its clocks will be off when unused. Cheers, Paul > >=20 > > Cheers, > >=20 > > Paul > >=20 > >>> > >>> What do you think? > >>> > >>> Cheers, > >>> > >>> Paul > >>> > >>>>> + }; > >>>>> + > >>>>> qos_gmac: qos@ff518000 { > >>>>> compatible =3D "syscon"; > >>>>> reg =3D <0x0 0xff518000 0x0 0x20>; > >>>>> > >>>> > >>> > >> > >=20 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --IA03tywDYuoVKXrw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl6YZ7UACgkQ3cLmz3+f v9H7Bwf/dxe/z672mfjqt4PR187hrwSZUxb8QrJrY0H31hOL2NOEFEufOKHPlA8y U+xPF95tT1SWwB+/6cjzhYGy9CF8EvmR0FDkBf2RVSXxbNvWSUMOFAVCA6bchQ5R 7iuxNcsjeQuEBGu6ljByelGcBFBTrk6MUQEmEKuAaH7F22lfnKTW53SlSXPvsnpD CAexlBFsLxN9VKECnc2QZ5qUjpNqRozzOexjDewJWm3BlPg4buAAkSKOQKlwd7q0 h7hYNx79PY6aFfp2EpdVy7XnbJOGRyRvwWbWsMFnKQo4wSYNtKWD3vMO3y6rX8ag JSRQ0iYXDgYz2uvtpi37rQb4y5Z0pg== =u/wC -----END PGP SIGNATURE----- --IA03tywDYuoVKXrw-- --===============3430888771668554521== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3430888771668554521==--