From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B998CC2BB55 for ; Thu, 16 Apr 2020 14:42:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CD2421D93 for ; Thu, 16 Apr 2020 14:42:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ecVc1pE4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="q8dZ9Zlw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CD2421D93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hc9HVFLdztF+jNolLeKesd9TgCwtR85eJ3OlResFSds=; b=ecVc1pE4Rc4ZKN vBM+vGoQyAAzAAIiwWeQDs3HsNbx6RnZJBPOIPDdz5yBslr1yPatwfQknCImnWeMTARQP/eWoFqTb g48gqlkOsZafl8RXo//MPvn8kYT0gJpFaaHp7yrQTSkKZ47hQRLVVLqIOOusu7qSHi2OFxkGv/83K I3I9mach9wQBwgoQpjae6OGgDZs8a5ACCkvhv3X85uhp030CKG+U2NyC/8Rv1psJGP32c19bXFmKQ JtrFUNP7Qk0TJNs/qztDLvkWn5Q+3x87rAlh5sInxnLvIIvVsUTJXag9xzmt+seWndWJsd2bIlc4w /PXPEfNWSia45+EKjncQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5j2-0005wn-8a; Thu, 16 Apr 2020 14:42:44 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP5iy-0005wN-M8 for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 14:42:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C7kfTyYkwsLnHp/E8P08Aix24d2ntiyV2E7RaHpJ+rE=; b=q8dZ9Zlw8dUKlEAdhL9bCiQXi1 fv2zR0EkSNsnsc+vE8rYzTwDeQCxJxVVIIKW//SEZxH3cY4+Y7I71Bul9FA1zOXdGZawqpHqve9IL k2v208wJKay0cfMHxRt5sdZ9QTt27Ze1bdX5oKBt4qX2RH8FDoL7g/of8qXm2wp1ahkY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jP5ip-0035Un-NP; Thu, 16 Apr 2020 16:42:31 +0200 Date: Thu, 16 Apr 2020 16:42:31 +0200 From: Andrew Lunn To: Robin Murphy Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416144231.GP657811@lunn.ch> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_074240_724646_6311D858 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , linux-pwm@vger.kernel.org, Linus Walleij , Russell King - ARM Linux admin , "open list:GPIO SUBSYSTEM" , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Bartosz Golaszewski , Gregory Clement , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote: > On 2020-04-16 2:50 pm, Andrew Lunn wrote: > [...] > > Clocking with Marvell devices has always been interesting. Core IP > > like this gets reused between different generations of SoCs. The > > original Orion5x had no clock control at all. Latter SoCs have had > > more and more complex clock trees. So care has to be taken to not > > change old behaviour when adding support for new clocks. > > FWIW, that sounds like a good argument for encoding the clock requirements > of each variant in the of_match_data, so the driver doesn't have to simply > trust the DT and hope. Hi Robin It is not really hope. It is very obvious when it is wrong, the whole machine stops dead when you are missing a clock. Very simple to test. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel