From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DAC4C352BE for ; Thu, 16 Apr 2020 17:37:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39CBC2076D for ; Thu, 16 Apr 2020 17:37:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tSfq5RCb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MPW/w2Hf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39CBC2076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xW4tGN2w6DNH0q1eJY3BzcM3eppnWhLkS1FsR0BecNY=; b=tSfq5RCbzsA7fM lTSqKossCu6baeCH0gOROHHUcY1QOGW/GIRdlKgrRGuDQQOi4NQLpcineULrdA0VUrsZ/IFMpM/jh ysmp+SbamRcEuErjCIoheB55/wHSZKKCkRdAvl4PDFybDbhNoEez84k8Q5T630iW2AsHAoYZR5U5a NVa1ap/nnoeCiCibyYyzIOIbp7kVAUD5pZJ9QALjjcheVxxiSHuFhJABeGQfei++VhB0TCxQC78T4 Lw4GCzL+apGxPFB5UO2NM9YdgRXw1mkH/ebOtkaZb/8Ct0s/73QyMyiZt/HnJTKaAGweMZS9MCvzj DZtIUcEaX9Gm8oRLmSrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP8S5-0000sZ-Rg; Thu, 16 Apr 2020 17:37:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP8S2-0000s3-Sq for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 17:37:24 +0000 Received: from Mani-XPS-13-9360 (unknown [157.50.106.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D183A2076D; Thu, 16 Apr 2020 17:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587058642; bh=c6RjcLo9mHi0Qj+iI/ymrQ+8S7krFiwa/crVExYtMzc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MPW/w2Hfnyk6tUbCwgA+epGBp7s9x8qUWJj1HiCBq+J9LTkOTM2QYZTP/j5uo/wrm Zu7E5RQleCiRVXkZUgTILmP6u9Q5+x1hOTZEgCwX8xxgd1Ay9ngjsrcfWax9ah1H31 eWIhS2p6dEJvzP9lw8E2V62BIIK92l1CFStWvCOY= Date: Thu, 16 Apr 2020 23:07:10 +0530 From: Manivannan Sadhasivam To: Andy Shevchenko Subject: Re: [PATCH 0/2] Add software flow control support for STM32 UART Message-ID: <20200416173710.GA4548@Mani-XPS-13-9360> References: <20200412180923.30774-1-mani@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_103722_952219_440955A8 X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Alexandre TORGUE , Greg Kroah-Hartman , Linux Kernel Mailing List , Rob Herring , Maxime Coquelin , "open list:SERIAL DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, Apr 13, 2020 at 12:17:21PM +0300, Andy Shevchenko wrote: > On Mon, Apr 13, 2020 at 7:06 AM wrote: > > > > From: Manivannan Sadhasivam > > > > Hello, > > > > This patchset adds software flow control support for STM32 UART controller. > > This is necessary for the upcoming STM32MP1 based board called Stinger96 > > IoT-Box. On that board, a bluetooth chip is connected to one of the UART > > controller but the CTS/RTS lines got swapped mistakenly. So in order to > > workaround that hardware bug and also to support the usecase of using only > > Tx/Rx pins, this patchset adds software flow control support. > > > > This patchset has been validated w/ Stinger96 IoT-Box connected to Murata > > WiFi-BT combo chip. > > > > I think it's a mix of terminology or so. Looking into the patches I > found that it's required to have GPIOs for SW flow control. > No, SW flow control does not require any additional signals, except RxD/TxD. > Yikes. Yes I got it wrong. 'st,hw-flow-ctrl' property confused me :) > On top of that, it seems you adding mctrl-gpio functionality. Why > can't you use that one? And thus no bindings needs to be updated. > Sure. This looks feasible. Will submit a follow up patch. Thanks, Mani > > Thanks, > > Mani > > > > Manivannan Sadhasivam (2): > > dt-bindings: serial: Add binding for software flow control in STM32 > > UART > > tty: serial: Add software flow control support for STM32 USART > > > > .../bindings/serial/st,stm32-uart.yaml | 15 +- > > drivers/tty/serial/stm32-usart.c | 143 +++++++++++++++++- > > drivers/tty/serial/stm32-usart.h | 4 + > > 3 files changed, 155 insertions(+), 7 deletions(-) > > > > -- > > 2.17.1 > > > > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel