From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: James Morse <james.morse@arm.com>
Cc: Will Deacon <will@kernel.org>,
gregkh@linuxfoundation.org, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
linux-arm-kernel@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
Tian Tao <tiantao6@hisilicon.com>,
tglx@linutronix.de, info@metux.net, allison@lohutok.net
Subject: Re: [PATCH] arm32: fix flushcache syscall with device address
Date: Tue, 21 Apr 2020 17:55:16 +0100 [thread overview]
Message-ID: <20200421165515.GF25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <d0814ab2-03fc-42c1-e447-bfee2df038da@arm.com>
On Tue, Apr 21, 2020 at 05:50:22PM +0100, James Morse wrote:
> Hi guys,
>
> (Subject Nit: arm64, as that is what your patch modifies)
That is irrelevent. This is a compatibility interface which is supposed
to reflect the arm32 implementation. Augmenting a compatibility
interface to do more than what it's counterpart that it's supposed to
be compatible with is senseless.
The API concerned is an ARM32 API which is expected to only be used
for ensuring I/D cache coherency, it is not for DMA.
Augmenting it on ARM64 for DMA is senseless.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-21 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:08 [PATCH] arm32: fix flushcache syscall with device address Tian Tao
2020-04-21 8:12 ` Will Deacon
2020-04-21 11:16 ` Jonathan Cameron
2020-04-21 16:50 ` James Morse
2020-04-21 16:55 ` Russell King - ARM Linux admin [this message]
2020-04-22 13:56 ` Catalin Marinas
2020-04-21 12:22 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421165515.GF25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jonathan.Cameron@Huawei.com \
--cc=allison@lohutok.net \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tglx@linutronix.de \
--cc=tiantao6@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).