From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756EFC54FCB for ; Wed, 22 Apr 2020 15:30:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 427C720776 for ; Wed, 22 Apr 2020 15:30:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q64wb1BP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="YZEibynY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 427C720776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ryunuyw5m1nDBU04JqVEQQZfS37m1M8fVlPtgN+BwQg=; b=Q64wb1BPaPrdVc XOiWDvNLfv3gXXj+JglHGHwANVWns3MaR0JR+RqtTpUJLIpkzNZh/lc+DkD+ksHieZdY8M5Hfikxo c0StL/mcNxoqMJR7XjbOVfFCVHWEqznsvA3VSc4At1VglhX5NT9pjU6uXjZJO5+hQrsYYHdXM33ZU JCmWEaSVSuZikA46711pEX05j1uNsGd975h4QvEi/7z0zvwjSkLOu9+02kfN1jv3S4WviCU26d/a7 GM9ZKf7Am/8NPyKkFGDkA0+jdyLhYP3QJcBXj5wzjOZg8nMGwJ44DEemSVfac3Mk1LcnYL/BSj9Qm pUA5Bg4nd7EMKD1UONjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRHKP-0001IM-E6; Wed, 22 Apr 2020 15:30:21 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRHKI-0000MU-BN; Wed, 22 Apr 2020 15:30:17 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CDF09528; Wed, 22 Apr 2020 17:30:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587569411; bh=+1pnVNRiTLb7nmelXOXTLaTwyd/zc6UiDxReSqZ2c6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YZEibynY0pa+TDNM4jvZ8GuCdVrCMyNK9OTmDn3ORYiOGgwHIvDpUiVBibucdqa8v Rv5t/yLaog2tGVFX71DYXDuyfQclTayygVbp86ZPxCR3CzXwj2v3/ighnC4PD2GvQv uLWR61e8wY8NIT+5L0/RsqrUqVeSQP3GDGfWgeow= Date: Wed, 22 Apr 2020 18:29:56 +0300 From: Laurent Pinchart To: Adrian Ratiu Subject: Re: [PATCH v7 5/8] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Message-ID: <20200422152956.GE28105@pendragon.ideasonboard.com> References: <20200421161610.1501827-1-adrian.ratiu@collabora.com> <20200421161610.1501827-6-adrian.ratiu@collabora.com> <20200422005832.GK5983@pendragon.ideasonboard.com> <20200422010155.GL5983@pendragon.ideasonboard.com> <877dy7ker6.fsf@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <877dy7ker6.fsf@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200422_083014_698736_3A914100 X-CRM114-Status: GOOD ( 24.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , devicetree@vger.kernel.org, Jernej Skrabec , Sjoerd Simons , Heiko Stuebner , Adrian Pop , Jonas Karlman , Martyn Welch , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , linux-rockchip@lists.infradead.org, linux-imx@nxp.com, Arnaud Ferraris , kernel@collabora.com, Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrian, On Wed, Apr 22, 2020 at 01:15:41PM +0300, Adrian Ratiu wrote: > On Wed, 22 Apr 2020, Laurent Pinchart wrote: > > On Wed, Apr 22, 2020 at 03:58:33AM +0300, Laurent Pinchart wrote: > >> On Tue, Apr 21, 2020 at 07:16:07PM +0300, Adrian Ratiu wrote: > >>> This provides an example DT binding for the MIPI DSI host > >>> controller present on the i.MX6 SoC based on Synopsis > >>> DesignWare v1.01 IP. Cc: Rob Herring Cc: > >>> Neil Armstrong Cc: Fabio Estevam > >>> Cc: Laurent Pinchart > >>> Cc: > >>> devicetree@vger.kernel.org Tested-by: Adrian Pop > >>> Tested-by: Arnaud Ferraris > >>> Signed-off-by: Sjoerd Simons > >>> Signed-off-by: Martyn Welch > >>> Signed-off-by: Adrian Ratiu > >>> --- Changes since v6: > >>> - Added ref to the newly created snps,dw-mipi-dsi.yaml > >>> (Laurent) - Moved *-cells properties outside > >>> patternProperties (Laurent) - Removed the panel port > >>> documentation (Laurent) - Wrapped lines at 80 chars, typo > >>> fixes, sort includes (Laurent) > >>> Changes since v5: > >>> - Fixed missing reg warning (Fabio) - Updated dt-schema and > >>> fixed warnings (Rob) > >>> Changes since v4: > >>> - Fixed yaml binding to pass `make dt_binding_check > >>> dtbs_check` and addressed received binding feedback (Rob) > >>> Changes since v3: > >>> - Added commit message (Neil) - Converted to yaml format > >>> (Neil) - Minor dt node + driver fixes (Rob) - Added small > >>> panel example to the host controller binding > >>> Changes since v2: > >>> - Fixed commit tags (Emil) > >>> --- > >>> .../display/imx/fsl,mipi-dsi-imx6.yaml | 135 > >>> ++++++++++++++++++ 1 file changed, 135 insertions(+) create > >>> mode 100644 > >>> Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > >>> diff --git > >>> a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > >>> b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > >>> new file mode 100644 index 0000000000000..b73e3ae33a852 --- > >>> /dev/null +++ > >>> b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > >>> @@ -0,0 +1,135 @@ +# SPDX-License-Identifier: (GPL-2.0-only > >>> OR BSD-2-Clause) +%YAML 1.2 +--- +$id: > >>> http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# + > >>> +title: Freescale i.MX6 DW MIPI DSI Host Controller + > >>> +maintainers: + - Adrian Ratiu > >>> + +description: | + The i.MX6 DSI host controller is a > >>> Synopsys DesignWare MIPI DSI v1.01 + IP block with a > >>> companion PHY IP. > > > > I forgot to mention, if there's a companion PHY, shouldn't it be > > referenced from the DT bindings ? > > I don't think so, that description was copied verbatim from the > imx6 ref manual IIRC, the physical layer is the same for MIPI DSI > which does TX as for MIPI CSI which does RX, but looking at the > ref manual and how drivers are written I don't think it's > necessary. Does that mean that the PHY is controlled through the registers specified by the reg property ? If so then this is fine. > This might change if we wanted to unify the DSI and CSI drivers a > bit, but considering the scope already associated with this patch > series I'm a bit afraid to open a subject like that =) That's understandable :-) > >>> + > >>> + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in > >>> + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with > >>> + the following device-specific properties. > >>> + > >>> +allOf: > >>> + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# > >>> + > >>> +properties: > >>> + '#address-cells': > >>> + const: 1 > >>> + > >>> + '#size-cells': > >>> + const: 0 > >>> + > >>> + compatible: > >>> + items: > >>> + - const: fsl,imx6q-mipi-dsi > >>> + - const: snps,dw-mipi-dsi > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + interrupts: > >>> + maxItems: 1 > >>> + > >>> + clocks: > >>> + items: > >>> + - description: Module Clock > >>> + - description: DSI bus clock > >>> + > >>> + clock-names: > >>> + items: > >>> + - const: ref > >>> + - const: pclk > >>> + > >>> + fsl,gpr: > >>> + description: > >>> + Phandle to the iomuxc-gpr region containing the multiplexer ctrl register. > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + > >>> + ports: > >>> + type: object > >>> + description: | > >>> + A node containing DSI input & output port nodes with endpoint > >>> + definitions as documented in > >>> + Documentation/devicetree/bindings/media/video-interfaces.txt > >>> + Documentation/devicetree/bindings/graph.txt > >>> + properties: > >>> + port@0: > >>> + type: object > >>> + description: > >>> + DSI input port node, connected to the ltdc rgb output port. > >>> + > >>> + port@1: > >>> + type: object > >>> + description: > >>> + RGB output port node, connected to a panel or a bridge input port. > >> > >> Isn't it the other way around, doesn't the bridge take RGB input and > >> output DSI ? And to be precise, it's not about RGB, but about the input > >> being parallel interface (DSI will also carry RGB). > >> > >> I would add > >> > >> required: > >> - port@0 > >> - port@1 > >> > >>> + > >>> +additionalProperties: false > >>> + > >>> +patternProperties: > >>> + "^panel@[0-3]$": > >>> + type: object > >>> + > >>> +required: > >>> + - "#address-cells" > >>> + - "#size-cells" > >>> + - compatible > >>> + - reg > >>> + - interrupts > >>> + - clocks > >>> + - clock-names > >>> + - ports > >>> + > >>> +examples: > >>> + - |+ > >>> + #include > >>> + #include > >>> + #include > >>> + > >>> + dsi: dsi@21e0000 { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + compatible = "fsl,imx6q-mipi-dsi", "snps,dw-mipi-dsi"; > >>> + reg = <0x021e0000 0x4000>; > >>> + interrupts = <0 102 IRQ_TYPE_LEVEL_HIGH>; > >>> + fsl,gpr = <&gpr>; > >>> + clocks = <&clks IMX6QDL_CLK_MIPI_CORE_CFG>, > >>> + <&clks IMX6QDL_CLK_MIPI_IPG>; > >>> + clock-names = "ref", "pclk"; > >>> + > >>> + ports { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >> > >> port@0 is missing. > >> > >>> + port@1 { > >>> + reg = <1>; > >>> + dsi_out: endpoint { > >>> + remote-endpoint = <&panel_in>; > >>> + }; > >>> + }; > >>> + }; > >>> + > >>> + panel@0 { > >>> + compatible = "sharp,ls032b3sx01"; > >>> + reg = <0>; > >>> + reset-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>; > >>> + ports { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + port@0 { > >>> + reg = <0>; > >>> + panel_in: endpoint { > >>> + remote-endpoint = <&dsi_out>; > >>> + }; > >>> + }; > >>> + }; > >>> + }; > >>> + }; > >>> + > >>> +... -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel