From: Mark Rutland <mark.rutland@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: docs: Mandate that the I-cache doesn't hold stale kernel text
Date: Thu, 23 Apr 2020 10:49:04 +0100 [thread overview]
Message-ID: <20200423094904.GA45833@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20200423093658.10602-1-will@kernel.org>
On Thu, Apr 23, 2020 at 10:36:58AM +0100, Will Deacon wrote:
> Although we require that the loaded kernel Image has been cleaned to the
> PoC, we neglect to spell out the state of the I-cache. Although this
> should be reasonably obvious, it doesn't hurt to be explicit.
>
> Require that the I-cache doesn't hold any stale entries for the kernel
> Image at boot.
>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Signed-off-by: Will Deacon <will@kernel.org>
This was certianly the intent, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> Documentation/arm64/booting.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/arm64/booting.rst b/Documentation/arm64/booting.rst
> index a3f1a47b6f1c..d063c05d5fb0 100644
> --- a/Documentation/arm64/booting.rst
> +++ b/Documentation/arm64/booting.rst
> @@ -173,7 +173,8 @@ Before jumping into the kernel, the following conditions must be met:
> - Caches, MMUs
>
> The MMU must be off.
> - Instruction cache may be on or off.
> + The instruction cache may be on or off, and must not hold any stale
> + entries corresponding to the loaded kernel image.
> The address range corresponding to the loaded kernel image must be
> cleaned to the PoC. In the presence of a system cache or other
> coherent masters with caches enabled, this will typically require
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-23 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 9:36 [PATCH] arm64: docs: Mandate that the I-cache doesn't hold stale kernel text Will Deacon
2020-04-23 9:49 ` Mark Rutland [this message]
2020-04-23 9:55 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423094904.GA45833@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox