From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B2BC54FCB for ; Thu, 23 Apr 2020 14:35:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCC8A20857 for ; Thu, 23 Apr 2020 14:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YDIUxJFz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="X7pKWg6D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCC8A20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=94rNQ33iCQjl5RPXSnstC6R9qYxNw2utEw4ENC07E4g=; b=YDIUxJFzf2WWuT piZDWP3gAhZ8gf7/6y0DHbEsKp2LVqcXzeIfmXBHV4FcvztEfj2acnwrAXK3YBWbGd2n0gb7XRm0o HbdnpK+rHa5hnGmCzdJKkFF0M9LVqDc3hRjFk6DqNjmkka/ecdvBtm1g2qjhUz+KPwgExAv0bIbkw Ij/9zxKHTvEGUHKAdfZ5QdNVhxf3QHDQu3bK1d5hNcxSrEHfuL9BbhZUp515QFcX1yiz4dF1EgTex 8q0IixfzWSIXPU2Y+2rADvcUTImweZBWVZNBgkqjoAFU+E3yvWE0M2eNYhIxJj+BCVcuKVJygLOrY Xhlp3EFrR1UkmqZmlh2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRcwv-0004cv-Vq; Thu, 23 Apr 2020 14:35:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRcwt-0004cD-OC for linux-arm-kernel@lists.infradead.org; Thu, 23 Apr 2020 14:35:33 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED0CF20728; Thu, 23 Apr 2020 14:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587652531; bh=Ee+RD+OrRjDd8d6DdnRs7oPT8hzvTilk3x0tw9gsORA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X7pKWg6D9PARol2JiFqEgz07RTYtk8QumlideyX+SsrZhpbtyNIMDbcinxy5AHhjN HH1e/ns54nnrepTdJMC5i0KS5fGoqPr40lSMi0v8eXto3fy01qvzEFshiui1yyC8t1 SsJTqSW4vwcvGTDZRnMmd06hwJc0Opgep4LtgUJY= Date: Thu, 23 Apr 2020 22:35:24 +0800 From: Shawn Guo To: Leonard Crestez Subject: Re: [PATCH v2] firmware: imx: scu: Fix corruption of header Message-ID: <20200423143523.GC9391@dragon> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200423_073531_800815_6B70FBCF X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Peng Fan , Franck LENORMAND , Oleksij Rempel , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 26, 2020 at 12:00:05AM +0200, Leonard Crestez wrote: > From: Franck LENORMAND > > The header of the message to send can be changed if the > response is longer than the request: > - 1st word, the header is sent > - the remaining words of the message are sent > - the response is received asynchronously during the > execution of the loop, changing the size field in > the header > - the for loop test the termination condition using > the corrupted header > > It is the case for the API build_info which has just a > header as request but 3 words in response. > > This issue is fixed storing the header locally instead of > using a pointer on it. > > Fixes: edbee095fafb (firmware: imx: add SCU firmware driver support) > > Signed-off-by: Franck LENORMAND > Reviewed-by: Leonard Crestez > Signed-off-by: Leonard Crestez > Cc: stable@vger.kernel.org Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel