* [PATCH] kbuild: remove unused AS assignment
@ 2020-04-27 0:30 Masahiro Yamada
2020-04-27 2:10 ` Nathan Chancellor
2020-04-27 8:06 ` Will Deacon
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-04-27 0:30 UTC (permalink / raw)
To: linux-kbuild
Cc: Linus Walleij, Arnd Bergmann, Catalin Marinas, Masahiro Yamada,
Nick Desaulniers, Russell King, linux-kernel, Joel Stanley,
Nathan Huckleberry, Nathan Chancellor, Will Deacon,
Ard Biesheuvel, linux-arm-kernel
$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
AS variable") killed it.
Remove the left-over code in arch/{arm,arm64}/Makefile.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/arm/Makefile | 2 --
arch/arm64/Makefile | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 7d5cd0f85461..cd28211f1418 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -45,12 +45,10 @@ endif
ifeq ($(CONFIG_CPU_BIG_ENDIAN),y)
KBUILD_CPPFLAGS += -mbig-endian
CHECKFLAGS += -D__ARMEB__
-AS += -EB
KBUILD_LDFLAGS += -EB
else
KBUILD_CPPFLAGS += -mlittle-endian
CHECKFLAGS += -D__ARMEL__
-AS += -EL
KBUILD_LDFLAGS += -EL
endif
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 85e4149cc5d5..d86cc9137539 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -84,7 +84,6 @@ KBUILD_CFLAGS += $(branch-prot-flags-y)
ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
KBUILD_CPPFLAGS += -mbig-endian
CHECKFLAGS += -D__AARCH64EB__
-AS += -EB
# Prefer the baremetal ELF build target, but not all toolchains include
# it so fall back to the standard linux version if needed.
KBUILD_LDFLAGS += -EB $(call ld-option, -maarch64elfb, -maarch64linuxb)
@@ -92,7 +91,6 @@ UTS_MACHINE := aarch64_be
else
KBUILD_CPPFLAGS += -mlittle-endian
CHECKFLAGS += -D__AARCH64EL__
-AS += -EL
# Same as above, prefer ELF but fall back to linux target if needed.
KBUILD_LDFLAGS += -EL $(call ld-option, -maarch64elf, -maarch64linux)
UTS_MACHINE := aarch64
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: remove unused AS assignment
2020-04-27 0:30 [PATCH] kbuild: remove unused AS assignment Masahiro Yamada
@ 2020-04-27 2:10 ` Nathan Chancellor
2020-04-27 8:06 ` Will Deacon
1 sibling, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2020-04-27 2:10 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, linux-kbuild, Catalin Marinas, Linus Walleij,
Nick Desaulniers, Russell King, linux-kernel, Joel Stanley,
Nathan Huckleberry, Will Deacon, Ard Biesheuvel, linux-arm-kernel
On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> AS variable") killed it.
>
> Remove the left-over code in arch/{arm,arm64}/Makefile.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: remove unused AS assignment
2020-04-27 0:30 [PATCH] kbuild: remove unused AS assignment Masahiro Yamada
2020-04-27 2:10 ` Nathan Chancellor
@ 2020-04-27 8:06 ` Will Deacon
2020-05-01 5:42 ` Masahiro Yamada
1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2020-04-27 8:06 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, linux-kbuild, Catalin Marinas, Linus Walleij,
Nick Desaulniers, Russell King, linux-kernel, Joel Stanley,
Nathan Huckleberry, Nathan Chancellor, Ard Biesheuvel,
linux-arm-kernel
On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> AS variable") killed it.
>
> Remove the left-over code in arch/{arm,arm64}/Makefile.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/arm/Makefile | 2 --
> arch/arm64/Makefile | 2 --
> 2 files changed, 4 deletions(-)
Acked-by: Will Deacon <will@kernel.org>
(If you post the arm64 part as a separate patch, I can pick it up)
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kbuild: remove unused AS assignment
2020-04-27 8:06 ` Will Deacon
@ 2020-05-01 5:42 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2020-05-01 5:42 UTC (permalink / raw)
To: Will Deacon
Cc: Arnd Bergmann, Linux Kbuild mailing list, Catalin Marinas,
Linus Walleij, Nick Desaulniers, Russell King,
Linux Kernel Mailing List, Joel Stanley, Nathan Huckleberry,
Nathan Chancellor, Ard Biesheuvel, linux-arm-kernel
On Mon, Apr 27, 2020 at 5:06 PM Will Deacon <will@kernel.org> wrote:
>
> On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> > $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> > AS variable") killed it.
> >
> > Remove the left-over code in arch/{arm,arm64}/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > arch/arm/Makefile | 2 --
> > arch/arm64/Makefile | 2 --
> > 2 files changed, 4 deletions(-)
>
> Acked-by: Will Deacon <will@kernel.org>
>
> (If you post the arm64 part as a separate patch, I can pick it up)
This is just a trivial cleanup patch.
So, I do not split it per-arch.
Applied to linux-kbuild.
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-01 5:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-27 0:30 [PATCH] kbuild: remove unused AS assignment Masahiro Yamada
2020-04-27 2:10 ` Nathan Chancellor
2020-04-27 8:06 ` Will Deacon
2020-05-01 5:42 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox