From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE01CAB360 for ; Mon, 27 Apr 2020 13:42:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20EC5206B6 for ; Mon, 27 Apr 2020 13:42:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WqLyXXW4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="uS5ZF4Y4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20EC5206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JprdwsK3Or29G5EQ86llBvfqD5dXDLsvg0ogFs8nk0M=; b=WqLyXXW4QoTsye qpAaPfqWLzHqcY2wysVJP6UBlfgwSzG3skgl1JeLRUu8NdRwXg8E972yhD5fL7HssbE6QnRbx4IKk +Lk+JOxYC2QoJ8j4UXq9W0uKAnzNipJqxbs9MKd8xCVzC/Ccwup/HquT3v9bz0na3Zcycxz4mgBmn s5sMRmC33P2X/eSx+rmfJ3xctT1GV9vUFUjz5GPVtHxa/puDpSK6JXUTgJpYK3iSp1skEKbCC5w7O MW1eJXabvxnG2f/kF0A/bhl9BaVXr+9n8GTWBj7kgDnpgWipvy9CmviGV+DFXEkSOv2MF83/QWxpY N9LKWIV2WOZLD2pex0xA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT41e-0005X8-Lp; Mon, 27 Apr 2020 13:42:22 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT41C-000509-IE for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 13:41:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gzBP/5TPSgWoYnfvROGi040waenlBeLNeHeHZF/9krM=; b=uS5ZF4Y4fsPKqhBVIAb9dODmx drtChwbes2kdwHDoLa75LyWIXKrhHIXZjaEQMWJIGLKFoKa2ofUeQWZmLoHx1TQkk4O/dcbHnMdA+ LYPgroUuuUOU3QT59FVZ3jBmpMp8BW1JrhUNHt9hb+3FD1wkQYMO2ra27rRJDqhs96xlFLcEgGUjE TJtzQASnKCxW9BwvRWMS4oqO0eTivJF3RFAQRHnV8x93MiVJi117d7PjQSeRetx05riLVwzTdipI9 qMlbycfDIPzWea/z8VRnFf8LvRfEyDMOJuwZUbl3mGWh+kD26YT0WYL2Hhzd1PsBZ5oLsfUNg0M5a LjdSx93zg==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:44630) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jT40w-000392-G1; Mon, 27 Apr 2020 14:41:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jT40v-0006hs-Lz; Mon, 27 Apr 2020 14:41:37 +0100 Date: Mon, 27 Apr 2020 14:41:37 +0100 From: Russell King - ARM Linux admin To: Calvin Johnson Subject: Re: [net-next PATCH v2 1/3] device property: Introduce phy related fwnode functions Message-ID: <20200427134137.GF25745@shell.armlinux.org.uk> References: <20200427132409.23664-1-calvin.johnson@oss.nxp.com> <20200427132409.23664-2-calvin.johnson@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200427132409.23664-2-calvin.johnson@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_064154_714235_1968BF56 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Heikki Krogerus , Cristi Sovaiala , Ioana Ciornei , Florian Fainelli , "Rajesh V . Bikkina" , Pankaj Bansal , Diana Madalina Craciun , linux-acpi@vger.kernel.org, Andy Shevchenko , Florin Laurentiu Chiculita , Madalin Bucur , Makarand Pawagi , Varun Sethi , Marcin Wojtas , linux-arm-kernel@lists.infradead.org, Laurentiu Tudor , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jeremy Linton , linux.cj@gmail.com, netdev@vger.kernel.org, "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 06:54:07PM +0530, Calvin Johnson wrote: > +/** > + * device_phy_find_device - For the given device, get the phy_device > + * @dev: Pointer to the given device > + * > + * If successful, returns a pointer to the phy_device with the embedded > + * struct device refcount incremented by one, or NULL on failure. It probably makes sense to refer the reader to the return conditions for fwnode_phy_find_device() so that should fwnode_phy_find_device() be updated, there's no need to modify multiple locations. > + */ > +struct phy_device *device_phy_find_device(struct device *dev) > +{ > + return fwnode_phy_find_device(dev_fwnode(dev)); > +} > +EXPORT_SYMBOL_GPL(device_phy_find_device); > + > +/** > + * fwnode_get_phy_node - Get the phy_node using the named reference. > + * @fwnode: Pointer to fwnode from which phy_node has to be obtained. > + * > + * Returns pointer to the phy fwnode, or ERR_PTR. Caller is responsible to > + * call fwnode_handle_put() on the returned phy fwnode pointer. This one even more so - fwnode_find_reference() is in an entirely separate file, so the comment could well be missed. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel