From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71962C83000 for ; Tue, 28 Apr 2020 07:25:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB23206B9 for ; Tue, 28 Apr 2020 07:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r4VgROWq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PpheMqqd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB23206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7EtMkDLF5Pnx1Besq5VRQmrry6/2RHU87zseuObXdrU=; b=r4VgROWqSmoszu AcgYhLwaWGDD29IQl0F5mF5qwBE2HYp+vOTjgpK6v6aRMARMP3B8iS2dlaVTV8fIUckFGyAr6q7QM xhfc/WDv0q0M2PbRNBc0BTrreqn9AkrpBNiNXesTLyVE22QVrfZxIFYSmE/xErTRqymuxnHDmFOg8 ljoXEB9Hszpq9DJEYemn79+uzgrm6VIOslgTLTVZBOd9PGGOfr9c5Y2I60bFRvQsLMIpQS0tHcvzO 1VgV0zYpZJfl4N3U3O2htgmHsyV17AMDCP51xENalbpAUNsqZKUW2DxMTzkdbJRmJF0A7/4+IOqT1 2VBvUPzfyYp3PAn5qeHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTKcL-0007vg-NM; Tue, 28 Apr 2020 07:25:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTKcJ-0007uK-8O for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 07:25:20 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15A6E20661; Tue, 28 Apr 2020 07:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588058714; bh=GLu5j27TIX4wZFikcdS3374+orGJgRuWeeuefdu1XMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PpheMqqd0u7obdLb311fFWl0BWxLCIGElMpzR1JL+EihHlxLyJdxEAwhK4VvGdvaK LMO3BvQ1yvDDuzCNWC/3b8XDj6TzxcjtBA7kyGe/WOQsT2l266x1XYEN3utRQjv+ld vuEeQRiIBnmS97jAdAO5hSbLU/lwE+4vU4tF/PT8= Date: Tue, 28 Apr 2020 08:25:09 +0100 From: Will Deacon To: Gavin Shan Subject: Re: [PATCH] arm64/mm: Reject invalid NUMA option Message-ID: <20200428072509.GA4049@willie-the-truck> References: <20200424045314.16017-1-gshan@redhat.com> <20200424101132.GC1167@C02TD0UTHF1T.local> <20200427225406.7cacc796@gandalf.local.home> <20200427225944.185d4431@gandalf.local.home> <20200427230920.3d606a2e@gandalf.local.home> <7e85ea83-de5f-c789-2e3c-e468a50ed4bd@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7e85ea83-de5f-c789-2e3c-e468a50ed4bd@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_002519_326498_9F6D1F2E X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, Steven Rostedt , shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 28, 2020 at 02:35:20PM +1000, Gavin Shan wrote: > On 4/28/20 1:09 PM, Steven Rostedt wrote: > > [...] > > > > > Could this be a bug in the implementation of strncmp() in > > arch/arm64/lib/strncmp.S. As I don't know arm64 assembly, I have no idea > > what it is trying to do. > > > > But strncmp("o","off",3) returning zero *is* a bug. > > > > I think it's false alarm. The patch has been in my local repo for a while. > I checked out 5.7.rc3 and tried passing "numa=o" to the kernel, @numa_off > is unchanged and its value is false. I also check the return value from > strncmp() as below, it's correct. Nothing is broken. I should have retested > before posting it. Sorry for the noise. Please ignore the crap patch :) Hmm, it's still worrying that you had that patch kicking around though, as it sounds like it /used/ to be broken. Would you be able to test the LTS kernels (5.4, 4.19, 4.14, 4.9, 4.4) to check that we're not missing a backport, please? Sorry to be a pain, but I'd like to get to the bottom of this! Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel