From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
linux-sunxi <linux-sunxi@googlegroups.com>,
Rob Herring <robh+dt@kernel.org>, Piotr Oniszczuk <warpme@o2.pl>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6
Date: Tue, 28 Apr 2020 09:51:56 +0200 [thread overview]
Message-ID: <20200428075156.65okklrupingiza6@gilmour.lan> (raw)
In-Reply-To: <20200426121709.1216-1-peron.clem@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 801 bytes --]
On Sun, Apr 26, 2020 at 02:17:09PM +0200, Clément Péron wrote:
> Tanix TX6 has a fixed regulator. As DVFS is instructed to change
> voltage to meet OPP table. The DVFS is not working as expected.
>
> Introduce a dedicated OPP Table where voltage are equals to
> the fixed regulator.
>
> Reported-by: Piotr Oniszczuk <warpme@o2.pl>
> Fixes: add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
I'm not really a big fan of duplicating the OPPs, since that would make an
update of those very likely to be overlooked for that particular board (and
since it's a board that not a lot of people have, it would be harder to notice
too).
IIRC, removing the cpu-supply property should work as well?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 7:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 12:17 [PATCH] arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6 Clément Péron
2020-04-26 12:18 ` Clément Péron
2020-04-28 7:51 ` Maxime Ripard [this message]
2020-04-28 8:45 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428075156.65okklrupingiza6@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=warpme@o2.pl \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox