From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B937CC83000 for ; Tue, 28 Apr 2020 09:40:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F7EB206D7 for ; Tue, 28 Apr 2020 09:40:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EzATQEDw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F7EB206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PHhEjNSD+bP3oxWnjFbFbaN1CCE+VBeVLcIVpeecKpA=; b=EzATQEDwJSS8zf KZFPHsW/V1vGKG9pPveA25xYmJOW7N5Uc5tQxirtHXNt0lFsBLE992uJj5kbOPBjaEhkUDX+iqHFX sxL37ffYHi9JqOlyveriTsP3hr95Ik7r+ZxJBaem9KF+J66ncRu+LbqVL+9ehIHFws57wqKtUoZMp R/iCMLB/H/SQbDjDLKTYrJcK0w0YZit1DQrlEb8yM8uTHnkCAlF+hjaXV8rRPnXUPBo+k2RqG6BCm BAlrNl07TOWtieYcNeWgBgDNtBLOol6KaeboSnLmQlXozzEac7Xl+JhPbIIMDxvPVZc8omCjq9Jlp +FMthLRLE2R/uZryeQ2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTMjK-000737-CT; Tue, 28 Apr 2020 09:40:42 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTMjF-000724-OQ for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 09:40:39 +0000 Received: by mail-ej1-f68.google.com with SMTP id e2so16655426eje.13 for ; Tue, 28 Apr 2020 02:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QPpy8dELuAAjDK6ELgslqKgtZGdGtoakZnwFCsFyxiY=; b=TVDA/Jj0UawGkLmOoqGM9CNir252roCeW5F9zse22JlFKhf988xC7SlsE4nlryOS5T 3aZL/nIDFIG0HGhavGnNWgIW53iP8OAZwwSfFwcpAeAUlGq4UAHAOzdVvuEFNtMPii7q mgSs0Q7xTlNxKzuLlYW6iKDSnfZyOGL4+ywoFqlgNriKeHV9g+5WuGUITIPg6pSlld15 APJrqFMAsuVpz4mTNS64luckO+e6aEqDAJUmS5SLEsQusXZTbvriHFxzzo8zqR+yQU1K V1tjrl3X1SAhAStk/GX1By2GUuWpQVjrPVgHStnWqjfuzwNv1VecHditRIpviVFW9toJ Y35Q== X-Gm-Message-State: AGi0PuYChkLUoEz0LCofuH46ifIybxvEPuLCBDhluf9qejXE16H4xYZ3 XOd9oJE+DPUH/CqK31srWSQ= X-Google-Smtp-Source: APiQypK/J2mRSfYf1Diw96LSTO8Uy+VHIm/8bbRhhtGMjC1QU33gdmtKQlVA6cbWyNIKnF5z1H2Phw== X-Received: by 2002:a17:907:20b5:: with SMTP id pw21mr22933290ejb.227.1588066835749; Tue, 28 Apr 2020 02:40:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.237]) by smtp.googlemail.com with ESMTPSA id yd11sm398829ejb.8.2020.04.28.02.40.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Apr 2020 02:40:34 -0700 (PDT) Date: Tue, 28 Apr 2020 11:40:32 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH] pinctrl: samsung: Save/restore eint_mask over suspend for EINT_TYPE GPIOs Message-ID: <20200428094032.GA23462@kozik-lap> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_024038_418615_D7DFA030 X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, tomasz.figa@gmail.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kgene@kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 25, 2020 at 04:10:46PM -0700, Jonathan Bakker wrote: > Currently, for EINT_TYPE GPIOs, the CON and FLTCON registers > are saved and restored over a suspend/resume cycle. However, the > EINT_MASK registers are not. > > On S5PV210 at the very least, these registers are not retained over > suspend, leading to the interrupts remaining masked upon resume and > therefore no interrupts being triggered for the device. There should > be no effect on any SoCs that do retain these registers as theoretically > we would just be re-writing what was already there. > > Signed-off-by: Jonathan Bakker > --- > drivers/pinctrl/samsung/pinctrl-exynos.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Exynos4412 (Odroid U3) also did not retain the register values. SD card detect interrupt should be affected. Thanks, applied (with CC-stable). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel