From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Hulk Robot <hulkci@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH] pinctrl: remove unused 'pwm37_pins'
Date: Tue, 28 Apr 2020 17:00:49 +0530 [thread overview]
Message-ID: <20200428113049.GA5259@Mani-XPS-13-9360> (raw)
In-Reply-To: <CACRpkdb5Ozz_MKAUDoyOxdnu_NkN72vRu=ZY7j_Lb5uMAiS3SA@mail.gmail.com>
On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote:
> On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> > Fix the following gcc warning:
> >
> > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> > but not used [-Wunused-const-variable=]
> > static const unsigned int pwm37_pins[] = { 110 };
> > ^~~~~~~~~~
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> I'm sceptic about this. I think PWM37 exists and just need to be
> properly defined.
>
> Mani will know the right solution to this.
>
Sorry for missing this thread before. The original patch didn't land in my
inbox.
Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper
fix would be to add it.
Jason, will you be able to send a patch for adding it? Otherwise I'll do that.
Thanks,
Mani
> Yours,
> Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 9:21 [PATCH] pinctrl: remove unused 'pwm37_pins' Jason Yan
2020-04-28 9:58 ` Linus Walleij
2020-04-28 11:30 ` Manivannan Sadhasivam [this message]
2020-04-28 11:44 ` Jason Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428113049.GA5259@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=hulkci@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox