From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups
Date: Tue, 28 Apr 2020 17:36:28 +0530 [thread overview]
Message-ID: <20200428120627.GB5259@Mani-XPS-13-9360> (raw)
In-Reply-To: <20200428115543.33379-1-yanaijie@huawei.com>
On Tue, Apr 28, 2020 at 07:55:43PM +0800, Jason Yan wrote:
> The 'pwm37' is not added to bm1880_pctrl_groups, which triggers a gcc
> build warning:
>
> drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: ‘pwm37_pins’ defined
> but not used [-Wunused-const-variable=]
> static const unsigned int pwm37_pins[] = { 110 };
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/pinctrl/pinctrl-bm1880.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index f7dff4f14101..d1a7d9836787 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -408,6 +408,7 @@ static const struct bm1880_pctrl_group bm1880_pctrl_groups[] = {
> BM1880_PINCTRL_GRP(pwm34),
> BM1880_PINCTRL_GRP(pwm35),
> BM1880_PINCTRL_GRP(pwm36),
> + BM1880_PINCTRL_GRP(pwm37),
> BM1880_PINCTRL_GRP(i2c0),
> BM1880_PINCTRL_GRP(i2c1),
> BM1880_PINCTRL_GRP(i2c2),
> --
> 2.21.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-28 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 11:55 [PATCH] pinctrl: add pwm37 to bm1880_pctrl_groups Jason Yan
2020-04-28 12:06 ` Manivannan Sadhasivam [this message]
2020-04-28 14:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428120627.GB5259@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox