From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0850CC83003 for ; Wed, 29 Apr 2020 13:14:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C40292072A for ; Wed, 29 Apr 2020 13:14:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JUDnYPoB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C40292072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=01bKbT4VhkyWc2/GWInsB1+H4th13Me32Mxv6q+zTsA=; b=JUDnYPoBIDiT0LUeJ5/sVXUCm hwwSKOnI/ZbfYH9ot1xm7avPG5lw/P5gvexJPy4xkSAJU94hb+x3YolbCa18AohxaIQix8S9Knz/U DB58KJ/BiTum1dAHgrStH+yMSFWZl3cNLISVzbRNPvIzVGdUkoyx7YaRCQQ/EbUyJMn6n4Cl/n8+V WHgdNhZei7sX2F9JO8lSnH0TFJ2reZHmlUzqtA9p4jKiGpUdMGKaenXns7z8ktJZDovRsEZGayEet tq9oDblSmHsKFXp4H0WsPuHLIZQlQGSig6F9/wr0+CUIybrGGjjAusuYvPDF02pdndqHWFQT6oTqU W7PgnJoqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTmXZ-0000XA-8g; Wed, 29 Apr 2020 13:14:17 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTmXU-0000VF-PA for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 13:14:14 +0000 X-Originating-IP: 93.29.109.196 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id F36E26000C; Wed, 29 Apr 2020 13:13:59 +0000 (UTC) Date: Wed, 29 Apr 2020 15:13:59 +0200 From: Paul Kocialkowski To: Arnd Bergmann Subject: Re: [PATCH] sun6i: dsi: fix gcc-4.8 Message-ID: <20200429131359.GJ610776@aptenodytes> References: <20200428215105.3928459-1-arnd@arndb.de> MIME-Version: 1.0 In-Reply-To: <20200428215105.3928459-1-arnd@arndb.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_061412_948832_554CE550 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Samuel Holland , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Maxime Ripard , Chen-Yu Tsai , Jagan Teki , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: multipart/mixed; boundary="===============3821731134249398016==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3821731134249398016== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yr/DzoowOgTDcSCF" Content-Disposition: inline --yr/DzoowOgTDcSCF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue 28 Apr 20, 23:50, Arnd Bergmann wrote: > Older compilers warn about initializers with incorrect curly > braces: >=20 > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c: In function 'sun6i_dsi_encoder_en= able': > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: missing braces aroun= d initializer [-Werror=3Dmissing-braces] > union phy_configure_opts opts =3D { 0 }; > ^ > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c:720:8: error: (near initialization= for 'opts.mipi_dphy') [-Werror=3Dmissing-braces] >=20 > Use the GNU empty initializer extension to avoid this. Looks good to me: Reviewed-by: Paul Kocialkowski But maybe use the drm/sun4i: dsi: prefix instead (granted, it wasn't used in the commit being fixed). Cheers, Paul > Fixes: bb3b6fcb6849 ("sun6i: dsi: Convert to generic phy handling") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun= 4i/sun6i_mipi_dsi.c > index f6c67dd87a05..aa67cb037e9d 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -718,7 +718,7 @@ static void sun6i_dsi_encoder_enable(struct drm_encod= er *encoder) > struct drm_display_mode *mode =3D &encoder->crtc->state->adjusted_mode; > struct sun6i_dsi *dsi =3D encoder_to_sun6i_dsi(encoder); > struct mipi_dsi_device *device =3D dsi->device; > - union phy_configure_opts opts =3D { 0 }; > + union phy_configure_opts opts =3D { }; > struct phy_configure_opts_mipi_dphy *cfg =3D &opts.mipi_dphy; > u16 delay; > int err; > --=20 > 2.26.0 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --yr/DzoowOgTDcSCF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl6pfZcACgkQ3cLmz3+f v9EZuwf/c+11FwGVP8LmF3ZNopR32d3cDoA0mLr1vizGfseJVldesiJUy/VuZI7I ppIjTfjte/iBHuyGcv8oAc0GQfkJaCvLFlcSkDUGgH5UfPEqxCTGvPLvV0doT77g MAUZw1EnVM2zHZ9IvjLmmes2/nvRMs/knC4qf8H8VW2LcFbDqUt+P9SioDHMEOzz ZpKNqa7C6Ll/KK7RljKfhk/i1bzakwyEw5Mv31bMBjJ5QeiP+OnLBDBD6ltBfjM7 f4ODxc85UpxYB9uoRfgQoE2Dk2aN2h2OMTGt7USnEA3HesH1oxRpP7xWpefwHGfY oHhO7JHJ8TOwoWS/iIN+wsbHxbDpWw== =QQXf -----END PGP SIGNATURE----- --yr/DzoowOgTDcSCF-- --===============3821731134249398016== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3821731134249398016==--