From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96CEC47255 for ; Thu, 30 Apr 2020 14:00:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A62F620870 for ; Thu, 30 Apr 2020 14:00:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JqauQb9W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A62F620870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ORP4WbWquYrF2+muGlq1Bg/oXcm8cml1B6o3Beo9GGM=; b=JqauQb9Wbac2gk I4DZ14UwMbPsolHsB9kfmQcGzo5DRYW8kkJzJ5vc3FM5lc30JPV2ZRJQc0lmL5BFNr4uVJ/T3C0MJ 4GyH2DhJTNRg5z4cUag37352Sw9kpJ5NhnJ045ECAJFn7CQ0B7b1k00LWYUBjh36HZAM7FnAl2Ld4 BbzrkuDWNO3+WUcaLs4tOgEj6x6G5GkArS0hKYPXDfR7508Ielb7+BXPPI0oaW2OsUVMIvi3QQj6E y8AjtOSyTCB7Qv3h6iojapdgSZwuSiKQWanHbK4M0057C1PNZ7BG48WmM7WstMokxOZktWLePgMr/ xxkmf76f7hRKtRqNqJdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU9kA-0003bq-St; Thu, 30 Apr 2020 14:00:50 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU9k3-0003Ws-KP for linux-arm-kernel@lists.infradead.org; Thu, 30 Apr 2020 14:00:46 +0000 Received: by mail-oi1-f195.google.com with SMTP id j16so5266023oih.10 for ; Thu, 30 Apr 2020 07:00:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4SqKDcgFBHx1L7Er/7o6lUHlh3wWzthDwvJZwo5hrJU=; b=cngkAM4JZWP1XnAhF0K/omRFReM+Zxv7SEUi1ZlzX3ETg/evkryrLX/qd8k5ftaNds HxiUHtHyxO9ZmiAyplqKGxdno6kMkXHP7t+Ly+YRSGmRf96cwvU+/B5xJLcdup9OOyvc /96A99F+WnRqHCFNdv53T/hmnD71JeEvMoHMw+gFhLvdLtRwIlXCcCWlYnKISUVC+ZUL rO62s4F0Yg15O6l09gLcWBocITZUdZKg+vushgrFEzYEz+WFeOMphGgSfJbXAw01gu+7 HJqSC2DczPu9PLNP4PMlevYgorfwbqMda3018FPvMyl8I5+B19DyQR9xU/A1ZUANA3+K RoRw== X-Gm-Message-State: AGi0Pua4+33PuT5Wv4x6RrEhGK8nNp/qR+4vv8h1gz5bYDJlrOTrG+Uo oAA/rCIAWaVL2/IMr9VbEhFfv0I= X-Google-Smtp-Source: APiQypK+NEro6nmq5Ju0kr11u0dYdZk562OwLmfEc6Rdsg37blDy9Pox4kBxZ7K1FWgojRgFDGj0HA== X-Received: by 2002:aca:d684:: with SMTP id n126mr1810974oig.173.1588255242401; Thu, 30 Apr 2020 07:00:42 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h137sm2698oib.33.2020.04.30.07.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 07:00:41 -0700 (PDT) Received: (nullmailer pid 20979 invoked by uid 1000); Thu, 30 Apr 2020 14:00:40 -0000 Date: Thu, 30 Apr 2020 09:00:40 -0500 From: Rob Herring To: Tony Lindgren Subject: Re: [PATCH 02/14] clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support Message-ID: <20200430140040.GA8363@bogus> References: <20200417165519.4979-1-tony@atomide.com> <20200417165519.4979-3-tony@atomide.com> <62be90e2-7dbe-410d-4171-c0ad0cddc7a3@linaro.org> <20200427143144.GQ37466@atomide.com> <29f39839-b3ed-cac3-1dea-c137286320b1@linaro.org> <20200427152329.GR37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200427152329.GR37466@atomide.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_070043_667074_9125BE0C X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Aaro Koskinen , Lokesh Vutla , Keerthy , Michael Turquette , Daniel Lezcano , linux-kernel@vger.kernel.org, Tero Kristo , Stephen Boyd , Andreas Kemnade , "H. Nikolaus Schaller" , Thomas Gleixner , linux-omap@vger.kernel.org, Adam Ford , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 08:23:29AM -0700, Tony Lindgren wrote: > * Daniel Lezcano [200427 15:03]: > > On 27/04/2020 16:31, Tony Lindgren wrote: > > > Hi, > > > > > > * Daniel Lezcano [200427 09:19]: > > >> On 17/04/2020 18:55, Tony Lindgren wrote: > > >>> --- a/Documentation/devicetree/bindings/timer/ti,timer.txt > > >>> +++ b/Documentation/devicetree/bindings/timer/ti,timer.txt > > >>> @@ -14,6 +14,8 @@ Required properties: > > >>> ti,omap5430-timer (applicable to OMAP543x devices) > > >>> ti,am335x-timer (applicable to AM335x devices) > > >>> ti,am335x-timer-1ms (applicable to AM335x devices) > > >>> + ti,dmtimer-clockevent (when used as for clockevent) > > >>> + ti,dmtimer-clocksource (when used as for clocksource) > > >> > > >> Please, submit a separate patch for this. > > >> > > >> Before you resend as is, this will be nacked as clocksource / clockevent > > >> is not a hardware description but a Linux thing. > > >> > > >> Finding a way to characterize that from the DT is an endless discussion > > >> since years, so I suggest to use a single property for the timer eg > > >> and initialize the clocksource and the clockevent in the > > >> driver. > > > > > > Hmm good point. We still need to specify which timer is a clocksource > > > and which one a clockevent somehow. > > > > > > Maybe we could have a generic properties like the clock framework such as: > > > > > > assigned-system-clocksource > > > assigned-system-clockevent > > > > I think that will be the same problem :/ > > Seems like other SoCs have the same issue too with multiple timers > to configure. > > > Is it possible to check the interrupt for the clockevent ? A timer node > > with the interrrupt is the clockevent, without it is a clocksource. > > OK let's try that. So the configuration would become then: > > compatible = "ti,dmtimer; /* reserved for system timers */ > /delete-property/interrupts; /* ok so it's a clocksource */ > /delete-property/interrupts-extended; That's not really what was meant. Let's say you have N timers. Either every timer is exactly the same and the OS can just assign them however it wants or there is some difference in the h/w making certain timer better for certain functions. Describe that difference. It could be clock rate, number of counter bits, always on, secure mode access only, has or doesn't have output compare or input capture, etc. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel