* [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341
@ 2020-04-30 9:43 dillon.minfei
2020-04-30 9:57 ` Alexandre Torgue
2020-04-30 12:08 ` Philippe Schenker
0 siblings, 2 replies; 5+ messages in thread
From: dillon.minfei @ 2020-04-30 9:43 UTC (permalink / raw)
To: alexandre.torgue
Cc: devicetree, mcoquelin.stm32, airlied, dillon.minfei, linux-kernel,
dri-devel, robh+dt, thierry.reding, daniel, sam, linux-stm32,
linux-arm-kernel
From: dillon min <dillon.minfei@gmail.com>
Signed-off-by: dillon min <dillon.minfei@gmail.com>
---
.../bindings/display/panel/ilitek,ili9341.txt | 42 +++++++++++
arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 79 +++++++++++++++++++
arch/arm/boot/dts/stm32f429-disco.dts | 88 ++++++++++++++++++++++
arch/arm/boot/dts/stm32f429.dtsi | 12 +++
4 files changed, 221 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
new file mode 100644
index 0000000..f5a4e55
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
@@ -0,0 +1,42 @@
+Ilitek ILI9341 TFT panel driver with SPI control bus
+
+This is a driver for 240x320 TFT panels, accepting a rgb input
+streams that get adapted and scaled to the panel.
+
+Required properties:
+ - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
+ (full system-specific compatible is always required to look up configuration)
+ - reg: address of the panel on the SPI bus
+
+Optional properties:
+ - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
+ - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
+
+ The following optional properties only apply to RGB input mode:
+
+ - pixelclk-active: see display/panel/display-timing.txt
+ - de-active: see display/panel/display-timing.txt
+ - hsync-active: see display/panel/display-timing.txt
+ - vsync-active: see display/panel/display-timing.txt
+
+The panel must obey the rules for a SPI slave device as specified in
+spi/spi-bus.txt
+
+The device node can contain one 'port' child node with one child
+'endpoint' node, according to the bindings defined in
+media/video-interfaces.txt. This node should describe panel's video bus.
+
+Example:
+
+panel: display@0 {
+ compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
+ reg = <0>;
+ spi-3wire;
+ spi-max-frequency = <10000000>;
+ dc-gpios = <&gpiod 13 0>;
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&display_out>;
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 392fa14..45b68f4 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -316,6 +316,85 @@
};
};
+ ltdc_pins_f429_disco: ltdc-1 {
+ pins {
+ pinmux = <STM32_PINMUX('C', 6, AF14)>,
+ /* LCD_HSYNC */
+ <STM32_PINMUX('A', 4, AF14)>,
+ /* LCD_VSYNC */
+ <STM32_PINMUX('G', 7, AF14)>,
+ /* LCD_CLK */
+ <STM32_PINMUX('C', 10, AF14)>,
+ /* LCD_R2 */
+ <STM32_PINMUX('B', 0, AF9)>,
+ /* LCD_R3 */
+ <STM32_PINMUX('A', 11, AF14)>,
+ /* LCD_R4 */
+ <STM32_PINMUX('A', 12, AF14)>,
+ /* LCD_R5 */
+ <STM32_PINMUX('B', 1, AF9)>,
+ /* LCD_R6*/
+ <STM32_PINMUX('G', 6, AF14)>,
+ /* LCD_R7 */
+ <STM32_PINMUX('A', 6, AF14)>,
+ /* LCD_G2 */
+ <STM32_PINMUX('G', 10, AF9)>,
+ /* LCD_G3 */
+ <STM32_PINMUX('B', 10, AF14)>,
+ /* LCD_G4 */
+ <STM32_PINMUX('D', 6, AF14)>,
+ /* LCD_B2 */
+ <STM32_PINMUX('G', 11, AF14)>,
+ /* LCD_B3*/
+ <STM32_PINMUX('B', 11, AF14)>,
+ /* LCD_G5 */
+ <STM32_PINMUX('C', 7, AF14)>,
+ /* LCD_G6 */
+ <STM32_PINMUX('D', 3, AF14)>,
+ /* LCD_G7 */
+ <STM32_PINMUX('G', 12, AF9)>,
+ /* LCD_B4 */
+ <STM32_PINMUX('A', 3, AF14)>,
+ /* LCD_B5 */
+ <STM32_PINMUX('B', 8, AF14)>,
+ /* LCD_B6 */
+ <STM32_PINMUX('B', 9, AF14)>,
+ /* LCD_B7 */
+ <STM32_PINMUX('F', 10, AF14)>;
+ /* LCD_DE */
+ slew-rate = <2>;
+ };
+ };
+
+ i2c3_pins: i2c3-0 {
+ pins {
+ pinmux = <STM32_PINMUX('C', 9, AF4)>,
+ /* I2C3_SDA */
+ <STM32_PINMUX('A', 8, AF4)>;
+ /* I2C3_SCL */
+ bias-disable;
+ drive-open-drain;
+ slew-rate = <3>;
+ };
+ };
+
+ spi5_pins: spi5-0 {
+ pins1 {
+ pinmux = <STM32_PINMUX('F', 7, AF5)>,
+ /* SPI5_CLK */
+ <STM32_PINMUX('F', 9, AF5)>;
+ /* SPI5_MOSI */
+ bias-disable;
+ drive-push-pull;
+ slew-rate = <0>;
+ };
+ pins2 {
+ pinmux = <STM32_PINMUX('F', 8, AF5)>;
+ /* SPI5_MISO */
+ bias-disable;
+ };
+ };
+
dcmi_pins: dcmi-0 {
pins {
pinmux = <STM32_PINMUX('A', 4, AF13)>, /* DCMI_HSYNC */
diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts
index 30c0f67..55eed05 100644
--- a/arch/arm/boot/dts/stm32f429-disco.dts
+++ b/arch/arm/boot/dts/stm32f429-disco.dts
@@ -49,6 +49,8 @@
#include "stm32f429.dtsi"
#include "stm32f429-pinctrl.dtsi"
#include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/gpio/gpio.h>
/ {
model = "STMicroelectronics STM32F429i-DISCO board";
@@ -98,6 +100,14 @@
regulator-name = "vcc5_host1";
regulator-always-on;
};
+
+ reg_3p3v: regulator-3p3v {
+ compatible = "regulator-fixed";
+ regulator-name = "3P3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
};
&clk_hse {
@@ -127,3 +137,81 @@
pinctrl-names = "default";
status = "okay";
};
+
+<dc {
+ status = "okay";
+ pinctrl-0 = <<dc_pins_f429_disco>;
+ pinctrl-names = "default";
+
+ port {
+ ltdc_out_rgb: endpoint {
+ remote-endpoint = <&panel_in_rgb>;
+ };
+ };
+};
+
+&spi5 {
+ status = "okay";
+ pinctrl-0 = <&spi5_pins>;
+ pinctrl-names = "default";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ cs-gpios = <&gpioc 1 GPIO_ACTIVE_LOW>,<&gpioc 2 GPIO_ACTIVE_LOW>;
+ dmas = <&dma2 3 2 0x400 0x0>,
+ <&dma2 4 2 0x400 0x0>;
+ dma-names = "rx", "tx";
+ l3gd20: l3gd20@0 {
+ compatible = "st,l3gd20-gyro";
+ spi-max-frequency = <10000000>;
+ st,drdy-int-pin = <2>;
+ interrupt-parent = <&gpioa>;
+ interrupts = <1 IRQ_TYPE_EDGE_RISING>,
+ <2 IRQ_TYPE_EDGE_RISING>;
+ reg = <0>;
+ vddio = <®_3p3v>;
+ vdd = <®_3p3v>;
+ status = "okay";
+ };
+ display: display@1{
+ /* Connect panel-ilitek-9341 to ltdc */
+ compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
+ reg = <1>;
+ spi-3wire;
+ spi-max-frequency = <10000000>;
+ dc-gpios = <&gpiod 13 0>;
+ port {
+ panel_in_rgb: endpoint {
+ remote-endpoint = <<dc_out_rgb>;
+ };
+ };
+ };
+};
+
+&i2c3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c3_pins>;
+ status = "okay";
+
+ touch: stmpe811@41 {
+ compatible = "st,stmpe811";
+ reg = <0x41>;
+ interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-parent = <&gpioa>;
+ vio = <®_3p3v>;
+ vcc = <®_3p3v>;
+ status = "okay";
+
+ stmpe_touchscreen {
+ compatible = "st,stmpe-ts";
+ st,sample-time = <4>;
+ st,mod-12b = <1>;
+ st,ref-sel = <0>;
+ st,adc-freq = <1>;
+ st,ave-ctrl = <1>;
+ st,touch-det-delay = <2>;
+ st,settling = <2>;
+ st,fraction-z = <7>;
+ st,i-drive = <1>;
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
index d777069..257b843 100644
--- a/arch/arm/boot/dts/stm32f429.dtsi
+++ b/arch/arm/boot/dts/stm32f429.dtsi
@@ -402,6 +402,18 @@
status = "disabled";
};
+ i2c3: i2c@40005c00 {
+ compatible = "st,stm32f4-i2c";
+ reg = <0x40005c00 0x400>;
+ interrupts = <72>,
+ <73>;
+ resets = <&rcc STM32F4_APB1_RESET(I2C3)>;
+ clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C3)>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
dac: dac@40007400 {
compatible = "st,stm32f4-dac-core";
reg = <0x40007400 0x400>;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341
2020-04-30 9:43 [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341 dillon.minfei
@ 2020-04-30 9:57 ` Alexandre Torgue
[not found] ` <CAL9mu0+AqO69+rEcH=HVWRhDLbqDO52-Cjxt-PAZmg6=7QtpvQ@mail.gmail.com>
2020-04-30 12:08 ` Philippe Schenker
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Torgue @ 2020-04-30 9:57 UTC (permalink / raw)
To: dillon.minfei
Cc: devicetree, mcoquelin.stm32, airlied, linux-kernel, dri-devel,
robh+dt, thierry.reding, daniel, sam, linux-stm32,
linux-arm-kernel
Hi
On 4/30/20 11:43 AM, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
Commit title should be ARM: dts: stm32: bla bla on stm32f429 and please
a commit message.
> ---
> .../bindings/display/panel/ilitek,ili9341.txt | 42 +++++++++++
> arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 79 +++++++++++++++++++
> arch/arm/boot/dts/stm32f429-disco.dts | 88 ++++++++++++++++++++++
> arch/arm/boot/dts/stm32f429.dtsi | 12 +++
> 4 files changed, 221 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
This binding description should be in a separate patch and you have to
write in YAML format.
> new file mode 100644
> index 0000000..f5a4e55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> @@ -0,0 +1,42 @@
> +Ilitek ILI9341 TFT panel driver with SPI control bus
> +
> +This is a driver for 240x320 TFT panels, accepting a rgb input
> +streams that get adapted and scaled to the panel.
> +
> +Required properties:
> + - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
> + (full system-specific compatible is always required to look up configuration)
> + - reg: address of the panel on the SPI bus
> +
> +Optional properties:
> + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
> + - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
> +
> + The following optional properties only apply to RGB input mode:
> +
> + - pixelclk-active: see display/panel/display-timing.txt
> + - de-active: see display/panel/display-timing.txt
> + - hsync-active: see display/panel/display-timing.txt
> + - vsync-active: see display/panel/display-timing.txt
> +
> +The panel must obey the rules for a SPI slave device as specified in
> +spi/spi-bus.txt
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video bus.
> +
> +Example:
> +
> +panel: display@0 {
> + compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
> + reg = <0>;
> + spi-3wire;
> + spi-max-frequency = <10000000>;
> + dc-gpios = <&gpiod 13 0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> index 392fa14..45b68f4 100644
> --- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> @@ -316,6 +316,85 @@
> };
> };
>
> + ltdc_pins_f429_disco: ltdc-1 {
> + pins {
> + pinmux = <STM32_PINMUX('C', 6, AF14)>,
> + /* LCD_HSYNC */
> + <STM32_PINMUX('A', 4, AF14)>,
> + /* LCD_VSYNC */
> + <STM32_PINMUX('G', 7, AF14)>,
> + /* LCD_CLK */
> + <STM32_PINMUX('C', 10, AF14)>,
> + /* LCD_R2 */
> + <STM32_PINMUX('B', 0, AF9)>,
> + /* LCD_R3 */
> + <STM32_PINMUX('A', 11, AF14)>,
> + /* LCD_R4 */
> + <STM32_PINMUX('A', 12, AF14)>,
> + /* LCD_R5 */
> + <STM32_PINMUX('B', 1, AF9)>,
> + /* LCD_R6*/
> + <STM32_PINMUX('G', 6, AF14)>,
> + /* LCD_R7 */
> + <STM32_PINMUX('A', 6, AF14)>,
> + /* LCD_G2 */
> + <STM32_PINMUX('G', 10, AF9)>,
> + /* LCD_G3 */
> + <STM32_PINMUX('B', 10, AF14)>,
> + /* LCD_G4 */
> + <STM32_PINMUX('D', 6, AF14)>,
> + /* LCD_B2 */
> + <STM32_PINMUX('G', 11, AF14)>,
> + /* LCD_B3*/
> + <STM32_PINMUX('B', 11, AF14)>,
> + /* LCD_G5 */
> + <STM32_PINMUX('C', 7, AF14)>,
> + /* LCD_G6 */
> + <STM32_PINMUX('D', 3, AF14)>,
> + /* LCD_G7 */
> + <STM32_PINMUX('G', 12, AF9)>,
> + /* LCD_B4 */
> + <STM32_PINMUX('A', 3, AF14)>,
> + /* LCD_B5 */
> + <STM32_PINMUX('B', 8, AF14)>,
> + /* LCD_B6 */
> + <STM32_PINMUX('B', 9, AF14)>,
> + /* LCD_B7 */
> + <STM32_PINMUX('F', 10, AF14)>;
> + /* LCD_DE */
> + slew-rate = <2>;
> + };
> + };
> +
> + i2c3_pins: i2c3-0 {
> + pins {
> + pinmux = <STM32_PINMUX('C', 9, AF4)>,
> + /* I2C3_SDA */
> + <STM32_PINMUX('A', 8, AF4)>;
> + /* I2C3_SCL */
> + bias-disable;
> + drive-open-drain;
> + slew-rate = <3>;
> + };
> + };
> +
> + spi5_pins: spi5-0 {
> + pins1 {
> + pinmux = <STM32_PINMUX('F', 7, AF5)>,
> + /* SPI5_CLK */
> + <STM32_PINMUX('F', 9, AF5)>;
> + /* SPI5_MOSI */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <0>;
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('F', 8, AF5)>;
> + /* SPI5_MISO */
> + bias-disable;
> + };
> + };
> +
> dcmi_pins: dcmi-0 {
> pins {
> pinmux = <STM32_PINMUX('A', 4, AF13)>, /* DCMI_HSYNC */
> diff --git a/arch/arm/boot/dts/stm32f429-disco.dts b/arch/arm/boot/dts/stm32f429-disco.dts
> index 30c0f67..55eed05 100644
> --- a/arch/arm/boot/dts/stm32f429-disco.dts
> +++ b/arch/arm/boot/dts/stm32f429-disco.dts
> @@ -49,6 +49,8 @@
> #include "stm32f429.dtsi"
> #include "stm32f429-pinctrl.dtsi"
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "STMicroelectronics STM32F429i-DISCO board";
> @@ -98,6 +100,14 @@
> regulator-name = "vcc5_host1";
> regulator-always-on;
> };
> +
> + reg_3p3v: regulator-3p3v {
3p3 ?
> + compatible = "regulator-fixed";
> + regulator-name = "3P3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> };
>
> &clk_hse {
> @@ -127,3 +137,81 @@
> pinctrl-names = "default";
> status = "okay";
> };
> +
> +<dc {
> + status = "okay";
> + pinctrl-0 = <<dc_pins_f429_disco>;
> + pinctrl-names = "default";
> +
> + port {
> + ltdc_out_rgb: endpoint {
> + remote-endpoint = <&panel_in_rgb>;
> + };
> + };
> +};
> +
> +&spi5 {
> + status = "okay";
> + pinctrl-0 = <&spi5_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpioc 1 GPIO_ACTIVE_LOW>,<&gpioc 2 GPIO_ACTIVE_LOW>;
> + dmas = <&dma2 3 2 0x400 0x0>,
> + <&dma2 4 2 0x400 0x0>;
> + dma-names = "rx", "tx";
> + l3gd20: l3gd20@0 {
> + compatible = "st,l3gd20-gyro";
> + spi-max-frequency = <10000000>;
> + st,drdy-int-pin = <2>;
> + interrupt-parent = <&gpioa>;
> + interrupts = <1 IRQ_TYPE_EDGE_RISING>,
> + <2 IRQ_TYPE_EDGE_RISING>;
> + reg = <0>;
> + vddio = <®_3p3v>;
> + vdd = <®_3p3v>;
> + status = "okay";
> + };
> + display: display@1{
> + /* Connect panel-ilitek-9341 to ltdc */
> + compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
> + reg = <1>;
> + spi-3wire;
> + spi-max-frequency = <10000000>;
> + dc-gpios = <&gpiod 13 0>;
> + port {
> + panel_in_rgb: endpoint {
> + remote-endpoint = <<dc_out_rgb>;
> + };
> + };
> + };
> +};
> +
> +&i2c3 {
Nodes are have to be ordered
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c3_pins>;
> + status = "okay";
> +
> + touch: stmpe811@41 {
> + compatible = "st,stmpe811";
> + reg = <0x41>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpioa>;
> + vio = <®_3p3v>;
> + vcc = <®_3p3v>;
> + status = "okay";
> +
> + stmpe_touchscreen {
> + compatible = "st,stmpe-ts";
> + st,sample-time = <4>;
> + st,mod-12b = <1>;
> + st,ref-sel = <0>;
> + st,adc-freq = <1>;
> + st,ave-ctrl = <1>;
> + st,touch-det-delay = <2>;
> + st,settling = <2>;
> + st,fraction-z = <7>;
> + st,i-drive = <1>;
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index d777069..257b843 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -402,6 +402,18 @@
Split Soc updates in a separate patch
> status = "disabled";
> };
>
> + i2c3: i2c@40005c00 {
> + compatible = "st,stm32f4-i2c";
> + reg = <0x40005c00 0x400>;
> + interrupts = <72>,
> + <73>;
> + resets = <&rcc STM32F4_APB1_RESET(I2C3)>;
> + clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C3)>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> dac: dac@40007400 {
> compatible = "st,stm32f4-dac-core";
> reg = <0x40007400 0x400>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341
[not found] ` <CAL9mu0+AqO69+rEcH=HVWRhDLbqDO52-Cjxt-PAZmg6=7QtpvQ@mail.gmail.com>
@ 2020-04-30 11:45 ` Alexandre Torgue
[not found] ` <CAL9mu0KRPPrTUWggs2dQWPGjkyubUMpYx=3JzOpwTPQPHjsGhw@mail.gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Torgue @ 2020-04-30 11:45 UTC (permalink / raw)
To: dillon min
Cc: devicetree, mcoquelin.stm32, airlied, linux-kernel, dri-devel,
robh+dt, thierry.reding, Daniel Vetter, sam, linux-stm32,
linux-arm-kernel
On 4/30/20 12:26 PM, dillon min wrote:
> Hi Alexandre,
>
> Alexandre Torgue <alexandre.torgue@st.com
> <mailto:alexandre.torgue@st.com>> 于2020年4月30日周四 下午5:57写道：
>
> Hi
>
> On 4/30/20 11:43 AM, dillon.minfei@gmail.com
> <mailto:dillon.minfei@gmail.com> wrote:
> > From: dillon min <dillon.minfei@gmail.com
> <mailto:dillon.minfei@gmail.com>>
> >
> > Signed-off-by: dillon min <dillon.minfei@gmail.com
> <mailto:dillon.minfei@gmail.com>>
>
> Commit title should be ARM: dts: stm32: bla bla on stm32f429 and please
> a commit message.
>
>
> *okay, thanks for your quicky response, this is my first kernel pull
> request, i will resubmit all patchsets following the history submits
> style who was did.*
ok no pb. In general way you have to execute ./scripts/checkpatch.pl to
check some style errors before sending. Use ./scripts/get_maintainer.pl
to see to who you have to send the patch. When you have several patches
in a series, you need to have a cover-letter which explains the aim of
your series. To have an idea of commit format just use git log on the
file changed to see how previous accepted commi have been written.
More details here: Documentation/process/submitting-patches.rst
>
> > ---
> > .../bindings/display/panel/ilitek,ili9341.txt | 42 +++++++++++
> > arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 79
> +++++++++++++++++++
> > arch/arm/boot/dts/stm32f429-disco.dts | 88
> ++++++++++++++++++++++
> > arch/arm/boot/dts/stm32f429.dtsi | 12 +++
> > 4 files changed, 221 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> >
> > diff --git
> a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
>
> This binding description should be in a separate patch and you have to
> write in YAML format.
>
> *okay, will do it later. *
>
>
> > new file mode 100644
> > index 0000000..f5a4e55
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> > @@ -0,0 +1,42 @@
> > +Ilitek ILI9341 TFT panel driver with SPI control bus
> > +
> > +This is a driver for 240x320 TFT panels, accepting a rgb input
> > +streams that get adapted and scaled to the panel.
> > +
> > +Required properties:
> > + - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
> > + (full system-specific compatible is always required to look
> up configuration)
> > + - reg: address of the panel on the SPI bus
> > +
> > +Optional properties:
> > + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
> > + - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
> > +
> > + The following optional properties only apply to RGB input mode:
> > +
> > + - pixelclk-active: see display/panel/display-timing.txt
> > + - de-active: see display/panel/display-timing.txt
> > + - hsync-active: see display/panel/display-timing.txt
> > + - vsync-active: see display/panel/display-timing.txt
> > +
> > +The panel must obey the rules for a SPI slave device as specified in
> > +spi/spi-bus.txt
> > +
> > +The device node can contain one 'port' child node with one child
> > +'endpoint' node, according to the bindings defined in
> > +media/video-interfaces.txt. This node should describe panel's
> video bus.
> > +
> > +Example:
> > +
> > +panel: display@0 {
> > + compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
> > + reg = <0>;
> > + spi-3wire;
> > + spi-max-frequency = <10000000>;
> > + dc-gpios = <&gpiod 13 0>;
> > + port {
> > + panel_in: endpoint {
> > + remote-endpoint = <&display_out>;
> > + };
> > + };
> > +};
> > diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> > index 392fa14..45b68f4 100644
> > --- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> > @@ -316,6 +316,85 @@
> > };
> > };
> >
> > + ltdc_pins_f429_disco: ltdc-1 {
> > + pins {
> > + pinmux = <STM32_PINMUX('C',
> 6, AF14)>,
> > + /* LCD_HSYNC */
> > + <STM32_PINMUX('A',
> 4, AF14)>,
> > + /* LCD_VSYNC */
> > + <STM32_PINMUX('G',
> 7, AF14)>,
> > + /* LCD_CLK */
> > + <STM32_PINMUX('C',
> 10, AF14)>,
> > + /* LCD_R2 */
> > + <STM32_PINMUX('B',
> 0, AF9)>,
> > + /* LCD_R3 */
> > + <STM32_PINMUX('A',
> 11, AF14)>,
> > + /* LCD_R4 */
> > + <STM32_PINMUX('A',
> 12, AF14)>,
> > + /* LCD_R5 */
> > + <STM32_PINMUX('B',
> 1, AF9)>,
> > + /* LCD_R6*/
> > + <STM32_PINMUX('G',
> 6, AF14)>,
> > + /* LCD_R7 */
> > + <STM32_PINMUX('A',
> 6, AF14)>,
> > + /* LCD_G2 */
> > + <STM32_PINMUX('G',
> 10, AF9)>,
> > + /* LCD_G3 */
> > + <STM32_PINMUX('B',
> 10, AF14)>,
> > + /* LCD_G4 */
> > + <STM32_PINMUX('D',
> 6, AF14)>,
> > + /* LCD_B2 */
> > + <STM32_PINMUX('G',
> 11, AF14)>,
> > + /* LCD_B3*/
> > + <STM32_PINMUX('B',
> 11, AF14)>,
> > + /* LCD_G5 */
> > + <STM32_PINMUX('C',
> 7, AF14)>,
> > + /* LCD_G6 */
> > + <STM32_PINMUX('D',
> 3, AF14)>,
> > + /* LCD_G7 */
> > + <STM32_PINMUX('G',
> 12, AF9)>,
> > + /* LCD_B4 */
> > + <STM32_PINMUX('A',
> 3, AF14)>,
> > + /* LCD_B5 */
> > + <STM32_PINMUX('B',
> 8, AF14)>,
> > + /* LCD_B6 */
> > + <STM32_PINMUX('B',
> 9, AF14)>,
> > + /* LCD_B7 */
> > + <STM32_PINMUX('F',
> 10, AF14)>;
> > + /* LCD_DE */
> > + slew-rate = <2>;
> > + };
> > + };
> > +
> > + i2c3_pins: i2c3-0 {
> > + pins {
> > + pinmux = <STM32_PINMUX('C',
> 9, AF4)>,
> > + /* I2C3_SDA */
> > + <STM32_PINMUX('A',
> 8, AF4)>;
> > + /* I2C3_SCL */
> > + bias-disable;
> > + drive-open-drain;
> > + slew-rate = <3>;
> > + };
> > + };
> > +
> > + spi5_pins: spi5-0 {
> > + pins1 {
> > + pinmux = <STM32_PINMUX('F',
> 7, AF5)>,
> > + /* SPI5_CLK */
> > + <STM32_PINMUX('F',
> 9, AF5)>;
> > + /* SPI5_MOSI */
> > + bias-disable;
> > + drive-push-pull;
> > + slew-rate = <0>;
> > + };
> > + pins2 {
> > + pinmux = <STM32_PINMUX('F',
> 8, AF5)>;
> > + /* SPI5_MISO */
> > + bias-disable;
> > + };
> > + };
> > +
> > dcmi_pins: dcmi-0 {
> > pins {
> > pinmux = <STM32_PINMUX('A',
> 4, AF13)>, /* DCMI_HSYNC */
> > diff --git a/arch/arm/boot/dts/stm32f429-disco.dts
> b/arch/arm/boot/dts/stm32f429-disco.dts
> > index 30c0f67..55eed05 100644
> > --- a/arch/arm/boot/dts/stm32f429-disco.dts
> > +++ b/arch/arm/boot/dts/stm32f429-disco.dts
> > @@ -49,6 +49,8 @@
> > #include "stm32f429.dtsi"
> > #include "stm32f429-pinctrl.dtsi"
> > #include <dt-bindings/input/input.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/gpio/gpio.h>
> >
> > / {
> > model = "STMicroelectronics STM32F429i-DISCO board";
> > @@ -98,6 +100,14 @@
> > regulator-name = "vcc5_host1";
> > regulator-always-on;
> > };
> > +
> > + reg_3p3v: regulator-3p3v {
>
> 3p3 ?
>
>
> *yes, the mfd stmpe driver need vcc & vio regulator, st sensor core
> driver need vddio & vdd*
I talked about the name. Somthing vdd_3v3 would be better. See how it is
done in other stm32fx platform
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "3P3V";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + };
> > };
> >
> > &clk_hse {
> > @@ -127,3 +137,81 @@
> > pinctrl-names = "default";
> > status = "okay";
> > };
> > +
> > +<dc {
> > + status = "okay";
> > + pinctrl-0 = <<dc_pins_f429_disco>;
> > + pinctrl-names = "default";
> > +
> > + port {
> > + ltdc_out_rgb: endpoint {
> > + remote-endpoint = <&panel_in_rgb>;
> > + };
> > + };
> > +};
> > +
> > +&spi5 {
> > + status = "okay";
> > + pinctrl-0 = <&spi5_pins>;
> > + pinctrl-names = "default";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + cs-gpios = <&gpioc 1 GPIO_ACTIVE_LOW>,<&gpioc 2
> GPIO_ACTIVE_LOW>;
> > + dmas = <&dma2 3 2 0x400 0x0>,
> > + <&dma2 4 2 0x400 0x0>;
> > + dma-names = "rx", "tx";
> > + l3gd20: l3gd20@0 {
> > + compatible = "st,l3gd20-gyro";
> > + spi-max-frequency = <10000000>;
> > + st,drdy-int-pin = <2>;
> > + interrupt-parent = <&gpioa>;
> > + interrupts = <1 IRQ_TYPE_EDGE_RISING>,
> > + <2 IRQ_TYPE_EDGE_RISING>;
> > + reg = <0>;
> > + vddio = <®_3p3v>;
> > + vdd = <®_3p3v>;
> > + status = "okay";
> > + };
> > + display: display@1{
> > + /* Connect panel-ilitek-9341 to ltdc */
> > + compatible = "stm32f429-disco,ltdc-panel",
> "ilitek,ili9341";
> > + reg = <1>;
> > + spi-3wire;
> > + spi-max-frequency = <10000000>;
> > + dc-gpios = <&gpiod 13 0>;
> > + port {
> > + panel_in_rgb: endpoint {
> > + remote-endpoint = <<dc_out_rgb>;
> > + };
> > + };
> > + };
> > +};
> > +
> > +&i2c3 {
>
> Nodes are have to be ordered
>
> *sorry, a little confused, i2c-3 is used by stmpe811 driver*
>
>
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c3_pins>;
> > + status = "okay";
> > +
> > + touch: stmpe811@41 {
> > + compatible = "st,stmpe811";
> > + reg = <0x41>;
> > + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> > + interrupt-parent = <&gpioa>;
> > + vio = <®_3p3v>;
> > + vcc = <®_3p3v>;
> > + status = "okay";
> > +
> > + stmpe_touchscreen {
> > + compatible = "st,stmpe-ts";
> > + st,sample-time = <4>;
> > + st,mod-12b = <1>;
> > + st,ref-sel = <0>;
> > + st,adc-freq = <1>;
> > + st,ave-ctrl = <1>;
> > + st,touch-det-delay = <2>;
> > + st,settling = <2>;
> > + st,fraction-z = <7>;
> > + st,i-drive = <1>;
> > + };
> > + };
> > +};
> > diff --git a/arch/arm/boot/dts/stm32f429.dtsi
> b/arch/arm/boot/dts/stm32f429.dtsi
> > index d777069..257b843 100644
> > --- a/arch/arm/boot/dts/stm32f429.dtsi
> > +++ b/arch/arm/boot/dts/stm32f429.dtsi
> > @@ -402,6 +402,18 @@
>
> Split Soc updates in a separate patch
>
> *okay, will do it later*
>
> > status = "disabled";
> > };
> >
> > + i2c3: i2c@40005c00 {
> > + compatible = "st,stm32f4-i2c";
> > + reg = <0x40005c00 0x400>;
> > + interrupts = <72>,
> > + <73>;
> > + resets = <&rcc STM32F4_APB1_RESET(I2C3)>;
> > + clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C3)>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "disabled";
> > + };
> > +
> > dac: dac@40007400 {
> > compatible = "st,stm32f4-dac-core";
> > reg = <0x40007400 0x400>;
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341
2020-04-30 9:43 [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341 dillon.minfei
2020-04-30 9:57 ` Alexandre Torgue
@ 2020-04-30 12:08 ` Philippe Schenker
1 sibling, 0 replies; 5+ messages in thread
From: Philippe Schenker @ 2020-04-30 12:08 UTC (permalink / raw)
To: dillon.minfei@gmail.com, alexandre.torgue@st.com
Cc: devicetree@vger.kernel.org, daniel@ffwll.ch, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, thierry.reding@gmail.com,
mcoquelin.stm32@gmail.com, sam@ravnborg.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
On Thu, 2020-04-30 at 17:43 +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
> .../bindings/display/panel/ilitek,ili9341.txt | 42 +++++++++++
> arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 79
> +++++++++++++++++++
> arch/arm/boot/dts/stm32f429-disco.dts | 88
> ++++++++++++++++++++++
> arch/arm/boot/dts/stm32f429.dtsi | 12 +++
> 4 files changed, 221 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
>
> diff --git
> a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> new file mode 100644
> index 0000000..f5a4e55
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.txt
> @@ -0,0 +1,42 @@
> +Ilitek ILI9341 TFT panel driver with SPI control bus
> +
> +This is a driver for 240x320 TFT panels, accepting a rgb input
> +streams that get adapted and scaled to the panel.
> +
> +Required properties:
> + - compatible: "stm32f429-disco,ltdc-panel", "ilitek,ili9341"
> + (full system-specific compatible is always required to look up
> configuration)
> + - reg: address of the panel on the SPI bus
> +
> +Optional properties:
> + - reset-gpios: a GPIO spec for the reset pin, see gpio/gpio.txt
> + - dc-gpios: a GPIO spec for the dc pin, see gpio/gpio.txt
> +
> + The following optional properties only apply to RGB input mode:
> +
> + - pixelclk-active: see display/panel/display-timing.txt
> + - de-active: see display/panel/display-timing.txt
> + - hsync-active: see display/panel/display-timing.txt
> + - vsync-active: see display/panel/display-timing.txt
> +
> +The panel must obey the rules for a SPI slave device as specified in
> +spi/spi-bus.txt
> +
> +The device node can contain one 'port' child node with one child
> +'endpoint' node, according to the bindings defined in
> +media/video-interfaces.txt. This node should describe panel's video
> bus.
> +
> +Example:
> +
> +panel: display@0 {
> + compatible = "stm32f429-disco,ltdc-panel", "ilitek,ili9341";
> + reg = <0>;
> + spi-3wire;
> + spi-max-frequency = <10000000>;
> + dc-gpios = <&gpiod 13 0>;
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> index 392fa14..45b68f4 100644
> --- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
> @@ -316,6 +316,85 @@
> };
> };
>
> + ltdc_pins_f429_disco: ltdc-1 {
> + pins {
> + pinmux = <STM32_PINMUX('C',
> 6, AF14)>,
> + /* LCD_HSYNC */
> + <STM32_PINMUX('A',
> 4, AF14)>,
> + /* LCD_VSYNC */
> + <STM32_PINMUX('G',
> 7, AF14)>,
> + /* LCD_CLK */
> + <STM32_PINMUX('C', 10,
> AF14)>,
> + /* LCD_R2 */
> + <STM32_PINMUX('B',
> 0, AF9)>,
> + /* LCD_R3 */
> + <STM32_PINMUX('A', 11,
> AF14)>,
> + /* LCD_R4 */
> + <STM32_PINMUX('A', 12,
> AF14)>,
> + /* LCD_R5 */
> + <STM32_PINMUX('B',
> 1, AF9)>,
> + /* LCD_R6*/
> + <STM32_PINMUX('G',
> 6, AF14)>,
> + /* LCD_R7 */
> + <STM32_PINMUX('A',
> 6, AF14)>,
> + /* LCD_G2 */
> + <STM32_PINMUX('G', 10,
> AF9)>,
> + /* LCD_G3 */
> + <STM32_PINMUX('B', 10,
> AF14)>,
> + /* LCD_G4 */
> + <STM32_PINMUX('D',
> 6, AF14)>,
> + /* LCD_B2 */
> + <STM32_PINMUX('G', 11,
> AF14)>,
> + /* LCD_B3*/
> + <STM32_PINMUX('B', 11,
> AF14)>,
> + /* LCD_G5 */
> + <STM32_PINMUX('C',
> 7, AF14)>,
> + /* LCD_G6 */
> + <STM32_PINMUX('D',
> 3, AF14)>,
> + /* LCD_G7 */
> + <STM32_PINMUX('G', 12,
> AF9)>,
> + /* LCD_B4 */
> + <STM32_PINMUX('A',
> 3, AF14)>,
> + /* LCD_B5 */
> + <STM32_PINMUX('B',
> 8, AF14)>,
> + /* LCD_B6 */
> + <STM32_PINMUX('B',
> 9, AF14)>,
> + /* LCD_B7 */
> + <STM32_PINMUX('F', 10,
> AF14)>;
> + /* LCD_DE */
> + slew-rate = <2>;
> + };
> + };
> +
> + i2c3_pins: i2c3-0 {
> + pins {
> + pinmux = <STM32_PINMUX('C', 9,
> AF4)>,
> + /* I2C3_SDA */
> + <STM32_PINMUX('A', 8,
> AF4)>;
> + /* I2C3_SCL */
> + bias-disable;
> + drive-open-drain;
> + slew-rate = <3>;
> + };
> + };
> +
> + spi5_pins: spi5-0 {
> + pins1 {
> + pinmux = <STM32_PINMUX('F', 7,
> AF5)>,
> + /* SPI5_CLK */
> + <STM32_PINMUX('F', 9,
> AF5)>;
> + /* SPI5_MOSI */
> + bias-disable;
> + drive-push-pull;
> + slew-rate = <0>;
> + };
> + pins2 {
> + pinmux = <STM32_PINMUX('F', 8,
> AF5)>;
> + /* SPI5_MISO */
> + bias-disable;
> + };
> + };
> +
> dcmi_pins: dcmi-0 {
> pins {
> pinmux = <STM32_PINMUX('A', 4,
> AF13)>, /* DCMI_HSYNC */
> diff --git a/arch/arm/boot/dts/stm32f429-disco.dts
> b/arch/arm/boot/dts/stm32f429-disco.dts
> index 30c0f67..55eed05 100644
> --- a/arch/arm/boot/dts/stm32f429-disco.dts
> +++ b/arch/arm/boot/dts/stm32f429-disco.dts
> @@ -49,6 +49,8 @@
> #include "stm32f429.dtsi"
> #include "stm32f429-pinctrl.dtsi"
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "STMicroelectronics STM32F429i-DISCO board";
> @@ -98,6 +100,14 @@
> regulator-name = "vcc5_host1";
> regulator-always-on;
> };
> +
> + reg_3p3v: regulator-3p3v {
> + compatible = "regulator-fixed";
> + regulator-name = "3P3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> };
>
> &clk_hse {
> @@ -127,3 +137,81 @@
> pinctrl-names = "default";
> status = "okay";
> };
> +
> +<dc {
> + status = "okay";
> + pinctrl-0 = <<dc_pins_f429_disco>;
> + pinctrl-names = "default";
> +
> + port {
> + ltdc_out_rgb: endpoint {
> + remote-endpoint = <&panel_in_rgb>;
> + };
> + };
> +};
> +
> +&spi5 {
> + status = "okay";
> + pinctrl-0 = <&spi5_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cs-gpios = <&gpioc 1 GPIO_ACTIVE_LOW>,<&gpioc 2
> GPIO_ACTIVE_LOW>;
> + dmas = <&dma2 3 2 0x400 0x0>,
> + <&dma2 4 2 0x400 0x0>;
> + dma-names = "rx", "tx";
> + l3gd20: l3gd20@0 {
> + compatible = "st,l3gd20-gyro";
> + spi-max-frequency = <10000000>;
> + st,drdy-int-pin = <2>;
> + interrupt-parent = <&gpioa>;
> + interrupts = <1 IRQ_TYPE_EDGE_RISING>,
> + <2 IRQ_TYPE_EDGE_RISING>;
> + reg = <0>;
> + vddio = <®_3p3v>;
> + vdd = <®_3p3v>;
> + status = "okay";
> + };
> + display: display@1{
> + /* Connect panel-ilitek-9341 to ltdc */
> + compatible = "stm32f429-disco,ltdc-panel",
> "ilitek,ili9341";
> + reg = <1>;
> + spi-3wire;
> + spi-max-frequency = <10000000>;
> + dc-gpios = <&gpiod 13 0>;
> + port {
> + panel_in_rgb: endpoint {
> + remote-endpoint = <<dc_out_rgb>;
> + };
> + };
> + };
> +};
> +
> +&i2c3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c3_pins>;
> + status = "okay";
> +
> + touch: stmpe811@41 {
> + compatible = "st,stmpe811";
> + reg = <0x41>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpioa>;
> + vio = <®_3p3v>;
> + vcc = <®_3p3v>;
> + status = "okay";
> +
> + stmpe_touchscreen {
> + compatible = "st,stmpe-ts";
> + st,sample-time = <4>;
> + st,mod-12b = <1>;
> + st,ref-sel = <0>;
> + st,adc-freq = <1>;
The above ADC related settings should go into the MFD device with
compatible "st,stmpe811". The use of those in touchscreen is deprecated.
Please check the bindings:
Documentation/devicetree/bindings/input/touchs
creen/stmpe.txt
Documentation/devicetree/bindings/mfd/stmpe.txt
Best Regards,
Philippe
> + st,ave-ctrl = <1>;
> + st,touch-det-delay = <2>;
> + st,settling = <2>;
> + st,fraction-z = <7>;
> + st,i-drive = <1>;
> + };
> + };
> +};
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi
> b/arch/arm/boot/dts/stm32f429.dtsi
> index d777069..257b843 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -402,6 +402,18 @@
> status = "disabled";
> };
>
> + i2c3: i2c@40005c00 {
> + compatible = "st,stm32f4-i2c";
> + reg = <0x40005c00 0x400>;
> + interrupts = <72>,
> + <73>;
> + resets = <&rcc STM32F4_APB1_RESET(I2C3)>;
> + clocks = <&rcc 0 STM32F4_APB1_CLOCK(I2C3)>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> dac: dac@40007400 {
> compatible = "st,stm32f4-dac-core";
> reg = <0x40007400 0x400>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341
[not found] ` <CAL9mu0KRPPrTUWggs2dQWPGjkyubUMpYx=3JzOpwTPQPHjsGhw@mail.gmail.com>
@ 2020-05-02 6:30 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2020-05-02 6:30 UTC (permalink / raw)
To: dillon min
Cc: devicetree, Alexandre Torgue, airlied, linux-kernel, dri-devel,
robh+dt, thierry.reding, linux-arm-kernel, Daniel Vetter,
linux-stm32, mcoquelin.stm32
Hi dillon min
> > okay, thanks alexandre, i will go through these docs. currently i'm on may
> day holiday, will be back at next wensday.
> after go back to work. i will separate this patch to five part with 9
> patchs , should be more clear
>
> dts releated
> 1, ARM: dts: stm32: Add i2c3 node for stm32f429
> 2, ARM: dts: stm32: Add drm panel ili9341 nodes connect to ldtc
> support for stm32f429-disco board
> 3, ARM: dts: stm32: Add stmpe811 touch screen support for
> stm32f429-disco board
> 4, ARM: dts: stm32: Add l3gd20 gyroscope sensor support for
> stm32f429-disco board
>
> clk releated
> 1, clk: stm32: Fix ltdc loading hang in set clk rate, pll_hw set to
> clks[PLL_VCO_SAI] but not clks[PLL_SAI]
> 2, clk: stm32: Add CLK_IGNORE_UNUSED flags for ltdc, make sure ltdc clk
> not be released after system startup
>
> spi releated
> 1, spi: stm32: Add transfer mode SPI_SIMPLE_RX, SPI_3WIRE_RX support
> for stm32f4
>
> drm releated
> 1, drm/panel: Add panel driver ilitek-ili9341
>
> doc releated
> 1, dt-bindings: display: panel: Add binding document for Ilitek Ili9341
Patch separation looks good.
Please cc: me on both the binding and the panel patches.
The binding must be in DT Schema format (.yaml).
See a lot of examples in drm-misc-next for inspiration.
Looks forward to see/review your submission.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-02 6:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 9:43 [PATCH 1/4] add dts node for drm panel driver ili9341 add dts i2c3 for stmpe touch add dts spi5 for gyro & ili9341 dillon.minfei
2020-04-30 9:57 ` Alexandre Torgue
[not found] ` <CAL9mu0+AqO69+rEcH=HVWRhDLbqDO52-Cjxt-PAZmg6=7QtpvQ@mail.gmail.com>
2020-04-30 11:45 ` Alexandre Torgue
[not found] ` <CAL9mu0KRPPrTUWggs2dQWPGjkyubUMpYx=3JzOpwTPQPHjsGhw@mail.gmail.com>
2020-05-02 6:30 ` Sam Ravnborg
2020-04-30 12:08 ` Philippe Schenker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).