From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C35B6C3A5A9 for ; Mon, 4 May 2020 12:43:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B64E2078C for ; Mon, 4 May 2020 12:43:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GYF9AP4/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B64E2078C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FVVe5kC5/7KR4vUG6ocyChVWSgL8nkjrjqjyqNEpaks=; b=GYF9AP4/K+PT3B GVGpI+Nv9JTd9Wv3XaMlh0Of8xywfI61PgKGov/ZzvyN8bBl0LCEHWMp8yNccNANwCbYW9uhil59u Xj+gMvPkew75Fc/mf1SsfTYvGsGQXhBJ5+kSaEuEqfgrv9fdJ5KULkqOWD4x5R9BXYiuxUFaELzBa 3WFlRc/dfxkPMFJMUe9EYx6j56r++FbNljoGUo05I4cB8P2sKKnqRonO8FINJqSfG+1aRRNTrKnsA WaCLUrqW5bVUsA/PhEdyXs7ps0PwCsP783ECZvvCFubLP2uGZlwgygZixvjE+E6XZQay6j12d+rwn PKthsjSQ+lsXUG0ttuLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVaRx-0002SU-El; Mon, 04 May 2020 12:43:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVaRu-0002Rn-T9 for linux-arm-kernel@lists.infradead.org; Mon, 04 May 2020 12:43:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 276E01FB; Mon, 4 May 2020 05:43:54 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.4.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 113593F71F; Mon, 4 May 2020 05:43:52 -0700 (PDT) Date: Mon, 4 May 2020 13:43:50 +0100 From: Mark Rutland To: Anshuman Khandual Subject: Re: [PATCH] arm64/cpuinfo: Move device_initcall() near cpuinfo_regs_init() Message-ID: <20200504124350.GB73375@C02TD0UTHF1T.local> References: <1588595377-4503-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1588595377-4503-1-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_054354_982378_9BE629FC X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, Mark Brown , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 04, 2020 at 05:59:37PM +0530, Anshuman Khandual wrote: > This moves device_initcall() near cpuinfo_regs_init() making the calling > sequence clear. Besides it is a standard practice to have device_initcall() > (any __initcall for that matter) just after the function it actually calls. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Brown > Cc: Mark Rutland > Cc: Suzuki Poulose > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Anshuman Khandual Acked-by: Mark Rutland Mark. > --- > Based on 5.7-rc4 > > arch/arm64/kernel/cpuinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index 86136075ae41..a515d8f3639e 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -311,6 +311,8 @@ static int __init cpuinfo_regs_init(void) > } > return 0; > } > +device_initcall(cpuinfo_regs_init); > + > static void cpuinfo_detect_icache_policy(struct cpuinfo_arm64 *info) > { > unsigned int cpu = smp_processor_id(); > @@ -403,5 +405,3 @@ void __init cpuinfo_store_boot_cpu(void) > boot_cpu_data = *info; > init_cpu_features(&boot_cpu_data); > } > - > -device_initcall(cpuinfo_regs_init); > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel