From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB98C47247 for ; Tue, 5 May 2020 10:50:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA57A206A5 for ; Tue, 5 May 2020 10:50:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iaFRadlc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA57A206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GHmte5aEcz06Vgy/zkuvAUpD5kgNNCfCUqErCN9qBJI=; b=iaFRadlcV67Z/G 9e/tsDlt4vzyvbZGJUzFqiDSKpuYOgWPw3CJdAt5Y9rho42Ojw192N0CLOFykzsI5Z9M+Ya0G6g1m 5ov7o4Hf3SKNZJeO7Y6yvXJUJ4rfKr9WGlngGLpOYJZxoN7qeO/sN1LHQj0BmzltZ+FOJgK2gQMtZ gJ5lIqX81fbL8vEtlKiVGMUmOQoljlDbKSkISyxEY/Lm9FRXJciMD6ldyIuvfnnJcXkqaZgxZsRGU uc5C+MA+PQ3C867oOzQ54pfAypWWdCRq3K0qH+DQs2VAMOQLoqSZ2J8PjzHhDs5xHYQ9J+75DN6sV AOay9oUpdUS/ABOodnYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVv9g-0006Qf-KT; Tue, 05 May 2020 10:50:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVv9d-0006QL-Vp for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2020 10:50:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 64EB968C4E; Tue, 5 May 2020 12:50:23 +0200 (CEST) Date: Tue, 5 May 2020 12:50:23 +0200 From: Christoph Hellwig To: Jann Horn Subject: Re: [PATCH v2 3/5] coredump: Refactor page range dumping into common helper Message-ID: <20200505105023.GB17400@lst.de> References: <20200429214954.44866-1-jannh@google.com> <20200429214954.44866-4-jannh@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200429214954.44866-4-jannh@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_035026_174660_5E3656C3 X-CRM114-Status: UNSURE ( 9.24 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Oleg Nesterov , linux-mm@kvack.org, Alexander Viro , Mark Salter , linux-fsdevel@vger.kernel.org, Russell King , Andrew Morton , Aurelien Jacquiot , Linus Torvalds , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, "Eric W . Biederman" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 11:49:52PM +0200, Jann Horn wrote: > Both fs/binfmt_elf.c and fs/binfmt_elf_fdpic.c need to dump ranges of pages > into the coredump file. Extract that logic into a common helper. > > Any other binfmt that actually wants to create coredumps will probably need > the same function; so stop making get_dump_page() depend on > CONFIG_ELF_CORE. Why is the #ifdef CONFIG_ELF_CORE in gup.c removed when the only remaining caller is under the same ifdef? Otherwise this looks fine to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel