From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B170C47254 for ; Tue, 5 May 2020 16:17:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52324206A4 for ; Tue, 5 May 2020 16:17:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nTMYJl4b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52324206A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nwJ1l1Gq2jGlrj9KD/Gsl3CRSLrzzH2nxLG5bkLd5PY=; b=nTMYJl4bU3Ofsy lNGzr1SSeD9GSnks0afeBRrdSZwsFCK/BwJ2QSMGVPqBaMZXeYt/3/CbNlEjGWzDueYO8WYeZ54+Q Ebswm0zSrV2VAAn6swVUJbQWCVGpLGyrs61GT1uw61fnzNrHTkO99UBgOhiNooHJrWTarZyWtvygK Y7Ue3k90yib+D4gIP0tMxDX8OVSanTRLTRtJgEOZCygQ9beN7j/44Nbf91PUor0qIVXyHSs+YTsFC LwR3oKuK3i6UStGgbcwhoryDuHDi3UOTe3PWKTg/l0d1MWZ+oJLoq6+JkMNqDo7KrN02yPAJab751 JkgrgKQpS0M44Ku5P/8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW0Fh-0007QG-8Q; Tue, 05 May 2020 16:17:01 +0000 Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW0Ff-0007PU-89; Tue, 05 May 2020 16:16:59 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id ACB03409A3; Tue, 5 May 2020 13:16:56 -0300 (-03) Date: Tue, 5 May 2020 13:16:56 -0300 From: Arnaldo Carvalho de Melo To: Mathieu Poirier Subject: Re: [PATCH] perf cs-etm: Move defined of traceid_list Message-ID: <20200505161656.GX30487@kernel.org> References: <20200505133642.4756-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Peter Zijlstra , Linux Kernel Mailing List , Tor Jeremiassen , Alexander Shishkin , Ingo Molnar , Leo Yan , Namhyung Kim , Jiri Olsa , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, May 05, 2020 at 08:52:18AM -0600, Mathieu Poirier escreveu: > On Tue, 5 May 2020 at 07:37, Leo Yan wrote: > > > > The variable 'traceid_list' is defined in the header file cs-etm.h, > > if multiple C files include cs-etm.h the compiler might complaint for > > multiple definition of 'traceid_list'. > > > > To fix multiple definition error, move the definition of 'traceid_list' > > into cs-etm.c. > > > > Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") > > Reported-by: Thomas Backlund > > Signed-off-by: Leo Yan > > Reviewed-by: Mike Leach > > Tested-by: Mike Leach > > }; > > > > -/* RB tree for quick conversion between traceID and metadata pointers */ > > -struct intlist *traceid_list; > > - > > Reviewed-by: Mathieu Poirier > Thanks, applied, - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel