From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7E3C47247 for ; Tue, 5 May 2020 23:34:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A624B206B8 for ; Tue, 5 May 2020 23:34:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p5HBJVoZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A624B206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g4LJ6zsc/awUO+ExIIuHHFdt4PTSR6kbakI5AxvzuiU=; b=p5HBJVoZCtuijF h5SI/j5i0RmjlKybFJBgx84TXt49o6UG1DoyoQkAS1QbXu3HChyjXeZUV8tbLKFGLK4FU7CeQsLHj vUgwYTsBeT9hL9bAPA64jANWuh8IR9uzlxlitEi/+bO7xJ3syzY0u+dfTyUub+JSBY4IaiXiP63TZ TVas9KTuNsXCtkWsObqa8ntPuvPKk27KS8aLRJGBUyBErmWv+NkQHfISpWDmrcwifkT4L+FLZTaQL 9RWjR952jfqm6fsHDFfweiIPX91LxJTOjAZ5iOdx7q6qNVx7vt+4Y7/GEnMGQAVUn6horw5VCqAyp 0lAKWPRSXiQDN2ddC7kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW74s-000482-Vt; Tue, 05 May 2020 23:34:18 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW74p-00046f-FY for linux-arm-kernel@lists.infradead.org; Tue, 05 May 2020 23:34:16 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F1A6480A5; Tue, 5 May 2020 23:35:00 +0000 (UTC) Date: Tue, 5 May 2020 16:34:08 -0700 From: Tony Lindgren To: Adam Ford Subject: Re: [PATCH] ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2 Message-ID: <20200505233408.GS37466@atomide.com> References: <20200504230100.181926-1-aford173@gmail.com> <20200505184223.GR37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_163415_568887_6ADECDCB X-CRM114-Status: GOOD ( 19.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Paul Walmsley , Linux Kernel Mailing List , Adam Ford-BE , Russell King , Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Linux-OMAP , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Adam Ford [200505 21:18]: > On Tue, May 5, 2020 at 1:42 PM Tony Lindgren wrote: > > > > * Adam Ford [200504 16:02]: > > > Various OMAP3 boards have two AES blocks, but only one is currently > > > available, because the hwmods are only configured for one. > > > > > > This patch migrates the hwmods for the AES engine to sysc-omap2 > > > which allows the second AES crypto engine to become available. > > > > > > omap-aes 480a6000.aes1: OMAP AES hw accel rev: 2.6 > > > omap-aes 480a6000.aes1: will run requests pump with realtime priority > > > omap-aes 480c5000.aes2: OMAP AES hw accel rev: 2.6 > > > omap-aes 480c5000.aes2: will run requests pump with realtime priority > > > > Great :) Looks like I'm getting the following though: > > > > DTC arch/arm/boot/dts/am3517-craneboard.dtb > > arch/arm/boot/dts/omap3.dtsi:160.39-184.5: ERROR (phandle_references): > > /ocp@68000000/target-module@480a6000: > > Reference to non-existent node or label "aes1_ick" > > > > Is this patch maybe missing a change for am3717 for the aes1_ick? > > I am guessing it's the same issue that plagues the am3517 with a note > in the hwmods that stated noone seems to know which am3517's support > it and which don't. The RNG was disabled on the 3517, so I am > guessing I'll do the same for AES. OK, I have no idea what modules might be there on am3517. > I should have posted it as an RFC, because I don't have the proper IRQ > setup for the newly supported AES engine. The interrupts that are > used for the original AES are listed as 'Resereved' in the AM3517 TRM. > I assume the second engine uses different interrupts. I don't suppose > anyone know what it should be? Sorry no idea, usually the secure accelerator documentation is just left out it seems. My guess the values are the same as on omap3. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel