From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF32C28CBC for ; Wed, 6 May 2020 17:34:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21DCE208E4 for ; Wed, 6 May 2020 17:34:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BIGavjwk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="f7hnEas2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21DCE208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yPWmIYzXQEZkEZ/3ZHPU/rvxOhc0JNQ+mQbABjaWFyA=; b=BIGavjwkiF18wdUDRGfTYiCtP lXnxaOMWS7+cNL0ZOYqVc0XKIzEryL5nJMnKPPcR7vQnuPN5wwW1YR5X+kW230cL32ZuRt4v38Edt wJPHf4AVaakO/3i8yB+zqeyUQHDclPdPDzPSmQ4bUKI3A3qZPdDEXiZAvEfK7dqD/tf8aLzlGqxxv aolbrgGLhB12xTE+CwbUN2fC6ijbmoofmUDGYCq6L+KRWaYjQUxmtNk0YOK8U3HeKkIi+giVFMhw9 BaTAk8lK4FuZqRKxWuiB8V7LjlItcri+1AL0ztynyat+bp3/4c2w4bmvVVmhxJjUFBernyx9lfR2Y JBA0dYSrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWNwB-0007JF-4V; Wed, 06 May 2020 17:34:27 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWNw6-0007IV-Tp for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2020 17:34:25 +0000 Received: by mail-pl1-x643.google.com with SMTP id s20so787021plp.6 for ; Wed, 06 May 2020 10:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v5j4S3JEVj0FPIjZ8oxj1MyFeG1ZAskbKGCn2iAsiYc=; b=f7hnEas2RuwiW30eTk9Sr6ocUIfaNFrt9EpsP8J9y68iep50a17a2n4POGJTkjLfwC 3g6JC/2fbDod1d56lq0TSLPPbSnmhoGLN/ULurD//t9cNNtQjHEZumIuton8xNfVTydP D61fB9wRz7oGNLtjq6t5N4+GxpnDeL9Li9uqZHo6c5VlABFervrl32YalUuS9BIutyPl mLJs9lV06k3jJ6Vk9/UDOeTClyBrph4sfuG941+oaVxADzsySotpIb0N6W9Mli/DdZ5e UPxtl7qHf6WnWtW+CDuyNzBc49juGSrdZRs58//GQK9rIMwVjsuTlwYPOr6AeBfB69p8 O+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v5j4S3JEVj0FPIjZ8oxj1MyFeG1ZAskbKGCn2iAsiYc=; b=PcTd1SSp/ZLG7zimV3GjSx+9iJMQZaEhFCV34NHv+TKP9nCpNZNtx7Rl2lzzHaLHJ+ 48r8MK5D1LPQ2t0wGGsxGV1NF5mJiORy7eUTH1s5G8GETZbCM1XR0CyAfNsFHfR/tw1I gC2K3rQjCF9DhhupGmRDfWa9S4S9qA/Li5YlH+/jYisyM6jh03/sjWD8xNS7HDzZQ3NE 5ujyqeJjWZ4GDBAoULUeE3ieM66XLECG936nYxjyUPz+jDK1dP2jnxpjX0WJiu/S+Csl oX0sFwxrMEqF4GcFK7CJ/eXnEjO2kQPiGqZpKWleNF0sZNonRXmJgrzCWZaDMusvRhPD qdRQ== X-Gm-Message-State: AGi0PuZa3RfH4xGEwvaqxPOVyclRZepVFmoSDAkjFx40bIpY/bIIx/Qv prb9KmO8bVfD7tuKda5oXXljxw== X-Google-Smtp-Source: APiQypLb+RC6/cMnfZERoKxaxndhqIfrmhAyRJ4+TYtl0zrdOB1QJHeG7mElx357RbHMDcXFPqymJg== X-Received: by 2002:a17:90a:5289:: with SMTP id w9mr10372222pjh.97.1588786460049; Wed, 06 May 2020 10:34:20 -0700 (PDT) Received: from google.com ([2620:15c:2ce:0:9efe:9f1:9267:2b27]) by smtp.gmail.com with ESMTPSA id k6sm5207655pju.44.2020.05.06.10.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 10:34:19 -0700 (PDT) Date: Wed, 6 May 2020 10:34:16 -0700 From: Fangrui Song To: Nick Desaulniers Subject: Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds Message-ID: <20200506173416.hmdp5cgkslunfko7@google.com> References: <20200505141257.707945-1-arnd@arndb.de> <20200505142556.GF82823@C02TD0UTHF1T.local> <20200505194243.5bfc6ec6@blackhole> <20200506034523.GA564255@ubuntu-s3-xlarge-x86> <20200506153156.GA1213645@ubuntu-s3-xlarge-x86> <20200506154556.5fsxzs3vbfwixggd@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_103422_984190_4A9B696E X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Amit Daniel Kachhap , Will Deacon , Ard Biesheuvel , Alexandre Ghiti , clang-built-linux , Marc Zyngier , AKASHI Takahiro , Kees Cook , Arnd Bergmann , Torsten Duwe , Kristina Martsenko , Josh Poimboeuf , Nathan Chancellor , Linux ARM , Julien Thierry , Ard Biesheuvel , Steve Capper , "linux-kernel@vger.kernel.org" , Torsten Duwe , Andrew Morton , Ionela Voinescu Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-05-06, Nick Desaulniers wrote: >On Wed, May 6, 2020 at 8:46 AM 'Fangrui Song' via Clang Built Linux > wrote: >> Created https://reviews.llvm.org/D79495 to allow the function attribute >> 'patchable_function_entry' on aarch64_be. >> I think -fpatchable-function-entry= just works. >> >> Note, LLD does not support aarch64_be >> (https://github.com/ClangBuiltLinux/linux/issues/380). > >I've approved the patch. Thanks for the quick fix. Looks like we >backported -fpatchable-function-entry= to the clang-10 release, so we >should cherry pick your fix to the release-10 branch for the clang >10.1 release. > >I'd rather have this fixed on the toolchain side. +1. Cherry picked to release/10.x https://github.com/llvm/llvm-project/commit/98f9f73f6d2367aa8001c4d16de9d3b347febb08 I did not use any endianness-sensitive in the original implementation, so hopefully this will not run into issues. The scheduled rc1 of LLVM 10.0.1 will happen on May 18, 2020 (https://lists.llvm.org/pipermail/llvm-dev/2020-April/141128.html) We should be quick if we want to test it on qemu or real hardware. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel