From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3423AC54E49 for ; Thu, 7 May 2020 05:55:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 055D020936 for ; Thu, 7 May 2020 05:55:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PhsRy51X"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=leon-nu.20150623.gappssmtp.com header.i=@leon-nu.20150623.gappssmtp.com header.b="NtQ9lrEB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 055D020936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=leon.nu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cw2Vnr19ljG3tZQruQichUviO6w4/PpF1GxbO8SfbPs=; b=PhsRy51Xxbz4YQ fHV2b0lU3g8XY+vY/t2acgIAXXL/IN7jHXRyz8B7zPzaEqaBvlVq8on+j7axHSlaes6ItbPOdgO8h 4am95xac42VfI8L0nwEhxgYv3Txthy7yx+ohE4YeP2FPhc5eMhAYT/lEPWKne8MjpKYO0A6FofOhE NWCTPrDJ+l+gVrfmHFv93VmbTiKe7yd4FJfTxMW1ol23AIZE5gXHsfQn8fsB3BwmiYjnARbD0q0NV ckgdjiPeQYFAQV1oy5XuKuDvzMIYM5xTpCvLMnKDfzBodQWhM7tmFpB/Iswga+Adz1smgBynY5RwA D5uZKw0aqhCxN5I1ULdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWZVi-0005fz-5E; Thu, 07 May 2020 05:55:54 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWZVf-0005f5-Pu for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 05:55:53 +0000 Received: by mail-wm1-x344.google.com with SMTP id h4so4957987wmb.4 for ; Wed, 06 May 2020 22:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leon-nu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oH3LjbuNvDT9L8S5Sf69u824MeEV5cEtswBnzJfZKgg=; b=NtQ9lrEB0RKmvJcKiFzKnz9QfMiUbEXXjSe/p7wlkumIjpn8oRgUaELn6nJE6+2mwu eXq4XStBUlPFpoP7TZhinRFDLHkIVkcxHvIXhU/OEMPZK2iLNXl++NcXynu44/BVTlIn rVh6p9N05KTDa9Q8ype8NNg2HnUWiPAd3wP3AzpbjjlhbKDy3Xx6bX2MASwUnDq/e9sH NpPRGLQdiSfRxfqGDpqARRojvEVXdkbhH8c4G/uNC+4VE+5mkWr1oASrxa68BA9bhq1D Ks+uYM4F4sB7PlGSmjPu//nwU8Pla6FjKmc/oxCpG6pwK81I+kxqrhid3dpNLpAPvwsk VLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oH3LjbuNvDT9L8S5Sf69u824MeEV5cEtswBnzJfZKgg=; b=NKwpeIqXBEUD2hHRAHzYFTAbsPhaIu0i8iZt2E9gKf9Hnd1nDl5EvfQdIskxxHN18I wl7zGitI+x+FRbrbqu7ZLnzeaqmjn603PtRxDMkftmFFZUHb07LKu94K2TVSU5Ww3RzO aP1r3Up6EL7FZBD1yDsiEEOcI8oxKWH5vfHTLHo4x71FxkZKgc+st8te9MNj8ix4GTYt +4yeiPkXJakaoYNxKBMvQuDn75uewf2ZqH5ezTpK3aqgnpVdobyJMeZ25sI64igVf5et xpAM1LVY639dewGx6slaT4/4AZIUpnoKfB/yfUxSE9tEureeJZvx+EGcZtT1ZoAqIYHy COrg== X-Gm-Message-State: AGi0PuaweJ149xdwJv5p/dM2XaDV/2+Gs3FCBkxqrYkYchJbcL7UERtl 1JLoBZ3pydSwCl+biBuXwd7apA== X-Google-Smtp-Source: APiQypK8a3UU8ELR11PAnuJfpnQYv+HCtC1y98AmPp3kCtHlJNWMr93w7mzfA1WmRqve6h0Pe9LTrg== X-Received: by 2002:a7b:c3d4:: with SMTP id t20mr8648512wmj.170.1588830950010; Wed, 06 May 2020 22:55:50 -0700 (PDT) Received: from localhost ([2a00:a040:183:2d::a43]) by smtp.gmail.com with ESMTPSA id i129sm6614225wmi.20.2020.05.06.22.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2020 22:55:49 -0700 (PDT) Date: Thu, 7 May 2020 08:55:47 +0300 From: Leon Romanovsky To: Jakub Kicinski Subject: Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver Message-ID: <20200507055547.GB78674@unreal> References: <20200505140231.16600-1-brgl@bgdev.pl> <20200505140231.16600-7-brgl@bgdev.pl> <20200506122329.0a6b2ac4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506122329.0a6b2ac4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_225551_908562_FF443AF8 X-CRM114-Status: GOOD ( 10.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Felix Fietkau , Arnd Bergmann , Bartosz Golaszewski , linux-netdev , Bartosz Golaszewski , Sean Wang , linux-kernel@vger.kernel.org, Mark Lee , Fabien Parent , Rob Herring , linux-mediatek@lists.infradead.org, John Crispin , Matthias Brugger , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 06, 2020 at 12:23:29PM -0700, Jakub Kicinski wrote: > On Wed, 6 May 2020 22:16:11 +0300 Leon Romanovsky wrote: > > > +#define MTK_MAC_DRVNAME "mtk_eth_mac" > > > +#define MTK_MAC_VERSION "1.0" > > > > Please don't add driver version to new driver. > > It has already been pointed out. Please trim your replies. Off-topic. Is there any simple way to trim replies semi-automatically in VIM? Right now, I'm doing it manually, but maybe there is some better way to do it. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel