From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32819C38A2A for ; Thu, 7 May 2020 18:55:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03B4720575 for ; Thu, 7 May 2020 18:55:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jFgYePMS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03B4720575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JNtFTEq3Dua+owUQDk4KcREe3fXc/heFykC0zXu0oGE=; b=jFgYePMSfd1T43 EzQFqNtn4llVlZSj1irHD+HqHb/P2hLNIk4YescG7pJLW7l/4L6U9XNFwuaKtysUIouDwuuKwD5yu fpCNz/WuUnS6AqXhoWGhCt/zmHmvLjIw3gqGFew9SNcWeTfnNqXH+aXKjlr0rBYjUtnP12fPEQ/lf uQsYLx/ygyaR5DTrl9GHrNSC2T9g9On6f12+WZCTBrzyyOb2o0X2LE9Dq8j1eORCOLVGv532Ak0/3 j19ausRqI2gakaF2vUl994GqKGR8k3TKAGp8hrQNTxDpkDMy+uMsyzP8Qivr8tQkUBfNwBdurDC7M 6ZfhmvoqB1SZXTMDDcNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWlg0-000291-05; Thu, 07 May 2020 18:55:20 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWlfs-00027a-VD for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 18:55:18 +0000 Received: by mail-ot1-f65.google.com with SMTP id i27so5417670ota.7 for ; Thu, 07 May 2020 11:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UwYYGNzYe2kxY79h+ETMMs0ZcfM9ltMxZYor/BkhBJM=; b=gOkOYk3KUmwd6jypuV7cZK2uhL51rHDntZk+/PnOyQPEC9J80WpAOiyadYLdoR9BBB lykBg1cd4NuJqtC6mW6ln1GCRz8str2UX4o+TleqNf8GCPgn8vOfrzGODigWfxflWcGH XHaOdiGK+M9wW2FtV607dvr+mzKA4r06BPD5kJdC5UCkS14UiN8iZeG4dTMeV1Bb+1/F 6U1jCFW/10GMZGCBQOcfvWI2IgWAycWy2tFQFzdskRzq3Nl1anZk+Z99yVCtc6sMlIlX FU18NwBUimHcR/BRROcaVZuQUdw+6SJ1aOvnS0tw9AFURkh/+ZVz0ShI7iieMwNEhjj/ i9nA== X-Gm-Message-State: AGi0PubvNsa1XT3H5JzCBPwaaiF5GsimG1IrF4aYcm8XT6h6SKTzOtXX EGvr324tXKmwJF1fYlo6pw== X-Google-Smtp-Source: APiQypKjijNorzsZ2dMMQG79xGnq6uhyLhE113wETl7HLQYF6IWQzqVm7SjGi2gTa9qDY0cJ7JepHg== X-Received: by 2002:a05:6830:1316:: with SMTP id p22mr10842049otq.223.1588877711170; Thu, 07 May 2020 11:55:11 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y17sm1675843oou.13.2020.05.07.11.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 11:55:10 -0700 (PDT) Received: (nullmailer pid 1054 invoked by uid 1000); Thu, 07 May 2020 18:55:09 -0000 Date: Thu, 7 May 2020 13:55:09 -0500 From: Rob Herring To: Jaedon Shin Subject: Re: [PATCH v2 2/2] PCI: brcmstb: Drop clk_put when probe fails and remove Message-ID: <20200507185509.GA913@bogus> References: <20200221033640.55163-1-jaedon.shin@gmail.com> <20200221033640.55163-3-jaedon.shin@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200221033640.55163-3-jaedon.shin@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_115516_873618_2A1EEA77 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Bartosz Golaszewski , linux-pci@vger.kernel.org, Linus Walleij , Jaedon Shin , linux-gpio@vger.kernel.org, Mark Brown , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Gregory Fong , Bjorn Helgaas , Florian Fainelli , Nicolas Saenz Julienne , Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 21 Feb 2020 12:36:40 +0900, Jaedon Shin wrote: > devm_clk_get* APIs are device managed and get freed automatically when > the device detaches. so there is no reason to explicitly call clk_put() > in probe or remove functions. > > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host > controller driver") > Signed-off-by: Jaedon Shin > Acked-by: Florian Fainelli > Acked-by: Nicolas Saenz Julienne > --- > drivers/pci/controller/pcie-brcmstb.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel