From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36487C54E49 for ; Thu, 7 May 2020 20:26:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0848324959 for ; Thu, 7 May 2020 20:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="INSKZ4Uk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0848324959 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UEQeMkqeBT4RnosMS8V8h3gwX5iKYEYG8fuM8EPbp20=; b=INSKZ4UknLhfWgb7o8v7PDulC W/XpWo1lKjairNE2K+N5n+DZlK1Kg27KKmLsTM2gDSUzYGtDgMdSpXsEYrwtHoDI8v2sfv6z+7SpM KRgynpn6LZvgRDkjub9Gj5qoUMacgWSTRhChX4GuNitWNBZyS4yXWpkgp+z9YiFrTnU1XnuoG8INI 1coxBVuvfvNG2BY/HbfU3T8kvXEsyiBUpVJ9eGOj1GPB5RjQ7kVZk4OHg7l19a/wMD3NUTA5gLOKB qNryW5Z1lfFsgrFXXk802c3UWg9s8sWnmtFso2mvQeNw4fiPK37+VOy4S2J4esmNI6tX9uRiJGOsD n4lHs+6mA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWn5q-0007oQ-LN; Thu, 07 May 2020 20:26:06 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWn5o-0007nT-5x; Thu, 07 May 2020 20:26:05 +0000 Received: from aptenodytes (196.109.29.93.rev.sfr.net [93.29.109.196]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 26FC6100002; Thu, 7 May 2020 20:25:59 +0000 (UTC) Date: Thu, 7 May 2020 22:25:58 +0200 From: Paul Kocialkowski To: Johan Jonker Subject: Re: [PATCH v3 2/4] arm64: dts: rockchip: Add RGA support to the PX30 Message-ID: <20200507202558.GK2422122@aptenodytes> References: <20200430164245.1630174-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_132604_358753_FC9AEFBB X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, heiko@sntech.de, linux-kernel@vger.kernel.org, hansverk@cisco.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, thomas.petazzoni@bootlin.com, mchehab@kernel.org, ezequiel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============5431860513426238484==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5431860513426238484== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aqWxf8ydqYKP8htK" Content-Disposition: inline --aqWxf8ydqYKP8htK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri 01 May 20, 00:05, Johan Jonker wrote: > Hi Paul, >=20 > > The PX30 features a RGA block: add the necessary node to support it. > >=20 > > Signed-off-by: Paul Kocialkowski > > --- > > arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/d= ts/rockchip/px30.dtsi > > index f809dd6d5dc3..3de70aa4f1ce 100644 > > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > > @@ -1102,6 +1102,17 @@ vopl_mmu: iommu@ff470f00 { > > status =3D "disabled"; > > }; > > =20 > > + rga: rga@ff480000 { > > + compatible =3D "rockchip,px30-rga", "rockchip,rk3288-rga"; > > + reg =3D <0x0 0xff480000 0x0 0x10000>; > > + interrupts =3D ; > > + clocks =3D <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; > > + clock-names =3D "aclk", "hclk", "sclk"; >=20 > > + resets =3D <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; > > + reset-names =3D "core", "axi", "ahb"; > > + power-domains =3D <&power PX30_PD_VO>; >=20 > sort >=20 > power-domains =3D <&power PX30_PD_VO>; > resets =3D <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>; > reset-names =3D "core", "axi", "ahb"; What's the rationale behind this (besides alphabetic sorting, which I don't believe is a rule for dt properties)? Some nodes above in the file have it = in the same order that I do, and I like to see clocks followed by resets. Cheers, Paul >=20 >=20 > > + }; > > + > > qos_gmac: qos@ff518000 { > > compatible =3D "syscon"; > > reg =3D <0x0 0xff518000 0x0 0x20>; > > --=20 > > 2.26.0 >=20 --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --aqWxf8ydqYKP8htK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAl60btYACgkQ3cLmz3+f v9Ha1Qf/Xr5JD/LpgWWDus3bRN+aBAhQYAdGgLJOCLzfZ73l5ovYy4znYccQvOP7 9jefTg3IgTEVV/Dxsh+EFuaWAJzHmEREpDRMSCywxGQgrkWyU8rgB2z7GHjT0xUM DV0SU5Hi8mL2SDyXXMjAu+VQRu2ewNCXTSrNGMNey2R9ii5XZB51VZ61lYh4Zct8 wZ/M1S+jG6x/JbZT4UalUqvUyQIvNHS27RlkBROLBHcEBngSWCB/iQCOuLl5kjwa 3FFE9oLKQC/8C0q8Ys8o0Oz7lnfH5EEQ+3y4wLuHBTLGjMBrED3AREihwZOaLoHS OmTf3luRVKugDzmY3MKRI6vUPxK0lA== =fLpQ -----END PGP SIGNATURE----- --aqWxf8ydqYKP8htK-- --===============5431860513426238484== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5431860513426238484==--