From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81780C38A2A for ; Fri, 8 May 2020 07:54:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54D88207DD for ; Fri, 8 May 2020 07:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nGB/S+wv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54D88207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=99IszxPWnZpa9oNpk+FQY1G1H0GK1KS267IabPQZhqM=; b=nGB/S+wvwV/88j ME/LlBgxGMUMQ4CJ4oTDkrdS+xld34VGvLnkEQHiXfAvalAlDDuoUXQEYsJXEs3c9c7EvWQWgfXLM mjCX1mASpiW4EccTlkmYwgOn2PafN4E7awspQQFyOgHqr141XOZzc/CT+079heae6qxNtQ9xHiWU2 dOPuceXE5RI58K0sjCLyJdlS8buGhGewZ6aujRWAGLnV0QcSQI2V7JQnyNfc53TiXp4Ga8v7CS6md Z11Hw+T3PbWQuWztCy4zzX0orDV9W5lK3s7rwwtG5FOGBARXVjn2n5k97P6lE4LLTL00YDU/2ecGr Yi/hCVoNXdq6LVC3kLdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWxq1-00020i-Rk; Fri, 08 May 2020 07:54:29 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWxpy-0001t4-97 for linux-arm-kernel@lists.infradead.org; Fri, 08 May 2020 07:54:28 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7451980503; Fri, 8 May 2020 09:52:17 +0200 (CEST) Date: Fri, 8 May 2020 09:52:10 +0200 From: Sam Ravnborg To: Bernard Subject: Re: [PATCH] drm/exynos: remove no need devm_kfree in probe [re-send, welcome any comments] Message-ID: <20200508075210.GA8789@ravnborg.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=1WtWmnkvAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=BHcMzYUn60HY1PDIBp0A:9 a=CjuIK1q_8ugA:10 a=-_UHfarfsM-RsASml2Jt:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200508_005426_496119_31E1FE6F X-CRM114-Status: GOOD ( 21.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Inki Dae , Kyungmin Park , Kukjin Kim , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bernard. On Wed, May 06, 2020 at 08:49:03PM +0800, Bernard wrote: > Remove no need devm_kfree in probe. > The change is to make the code a bit more readable > > Signed-off-by: Bernard Zhao Could you take a closer look and fix similar patterns in the rest of the driver? For example in exynos_dpi_probe() Is would be nice to only have to review for this type of changes once, so one patch-set is preferred over single patches over time. You can add: Reviewed-by: Sam Ravnborg to this patch when you re-send a new series. Thanks, Sam > --- > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > index 43fa0f26c052..e06f7d7a6695 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c > @@ -181,10 +181,8 @@ static int exynos_dpi_parse_dt(struct exynos_dpi *ctx) > return -ENOMEM; > > ret = of_get_videomode(dn, vm, 0); > - if (ret < 0) { > - devm_kfree(dev, vm); > + if (ret < 0) > return ret; > - } > > ctx->vm = vm; > > @@ -233,10 +231,8 @@ struct drm_encoder *exynos_dpi_probe(struct device *dev) > ctx->dev = dev; > > ret = exynos_dpi_parse_dt(ctx); > - if (ret < 0) { > - devm_kfree(dev, ctx); > - return NULL; > - } > + if (ret < 0) > + return ERR_PTR(ret); > > if (ctx->panel_node) { > ctx->panel = of_drm_find_panel(ctx->panel_node); > -- > 2.26.2 > > > [re-send, welcome any comments] > Regards, > Bernard > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel