From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FA6C28CBC for ; Sat, 9 May 2020 13:25:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E367C20722 for ; Sat, 9 May 2020 13:25:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vn+sSNEM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CC1qQzYw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E367C20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FGtsjz+ot98Xnqm+ORHN0tpCuq+yiWLJIC9OUo85Ww8=; b=Vn+sSNEM5IJKE9 6FdpLe4ygImehD2zhiJ0nKKoSbkSyewQk7f8Kp3cvK+tDZaqa6lE1sPNhB34ywH41hroNOgLS10lh djQfpUj4gnbCjM9M7ndlIVZVzMTT2v8ynOkwFYd67IaXZl2sXvfSflXgDlx/D2RfXTKPIJyauyGyc cBZ6TIA9EgIidTuWTW5Lmw7KglW7zclPfBF4rMhTVsjJ8WvM1g/F/ZO2bdCI+nrcxrydbMrpokGwD 9FLup8o1ns2ZPjT8Z+Obg4SLrteR3RSRkXOa+ETKWn4Dw0dyaiqS+fwx4eU/4LUWY0ksNtfEjDzUT hD3irl/6AHhxdxquhSEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXPUF-0002WL-IY; Sat, 09 May 2020 13:25:51 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXPUC-0002Um-8A for linux-arm-kernel@lists.infradead.org; Sat, 09 May 2020 13:25:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xxlsFN8Q2F7QH7NHZLiYgcMIZjPCMsIK8HIfpq4aIt4=; b=CC1qQzYwUvi3gcWuWkniLvbVn +1SRe5Cwu1ktiXbITbx+OQsj8ufkHeYyYXavUQ5G5gwuX8rEDg/htQ5Z3UTaSlk1FaY3fbig7HjaG 4jngtXZSQnGJNq86asL7QOfbiLmUL4ynk0NVBKbW4DfmWiRrCwmjM83LRyssNFOg4ypmuT5CDjrBv p8Hzmc5aThtcAw2lvomwaQSPUA55cbUugMVtTVHNQT2EopMpJlHYOwfb99RjDxWfYUtnWSiC3iwfG X/VuA0b750K672ePelBIBzgBLRIMg+49G/ukh6HsSUZnSw8FcWZI4KjPwFRVaCNsxQL3SqKCMQW1G 7KVQRW2aA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38026) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXPTr-0003zF-P5; Sat, 09 May 2020 14:25:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jXPTo-0002su-Mn; Sat, 09 May 2020 14:25:24 +0100 Date: Sat, 9 May 2020 14:25:24 +0100 From: Russell King - ARM Linux admin To: Stefan Chulski Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Message-ID: <20200509132524.GD1551@shell.armlinux.org.uk> References: <20190524100554.8606-1-maxime.chevallier@bootlin.com> <20190524100554.8606-4-maxime.chevallier@bootlin.com> <20200423170003.GT25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200509_062548_610040_95F4032C X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antoine Tenart , netdev , "gregory.clement@bootlin.com" , "miquel.raynal@bootlin.com" , LKML , Maxime Chevallier , Nadav Haklai , Thomas Petazzoni , Matteo Croce , Marcin Wojtas , "David S . Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 09, 2020 at 12:31:21PM +0000, Stefan Chulski wrote: > > -----Original Message----- > > From: Matteo Croce > > Sent: Saturday, May 9, 2020 3:16 PM > > To: Stefan Chulski > > Cc: David S . Miller ; Maxime Chevallier > > ; netdev ; LKML > > ; Antoine Tenart > > ; Thomas Petazzoni > > ; gregory.clement@bootlin.com; > > miquel.raynal@bootlin.com; Nadav Haklai ; Marcin > > Wojtas ; Linux ARM > kernel@lists.infradead.org>; Russell King - ARM Linux admin > > > > Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to > > handle RSS tables > > > > Hi, > > > > The point is that RXHASH works fine on all interfaces, but on the gigabit one > > (eth2 usually). > > And on the 10 gbit interface is very very effective, the throughput goes 4x when > > enabled, so it would be a big drawback to disable it on all interfaces. > > > > Honestly I don't have any 2.5 gbit hardware to test it on eth3, so I don't know if > > rxhash actually only works on the first interface of a unit (so eth0 and eth1), or > > if it just doesn't work on the gigabit one. > > > > If someone could test it on the 2.5 gbit port, this will be helpful. > > RSS tables is part of Packet Processor IP, not MAC(so it's not related to specific speed). Probably issue exist on specific packet processor ports. > Since RSS work fine on first port of the CP, we can do the following: > if (port-> id == 0) > dev->hw_features |= NETIF_F_RXHASH; I can confirm that Macchiatobin Single Shot eth0 port works with a 1G Fibre SFP or 10G DA SFP with or without rxhash on. So it seems Stefan's hunch that it is port related is correct. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel