From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FA1C28CBC for ; Sat, 9 May 2020 13:51:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB63521655 for ; Sat, 9 May 2020 13:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CSoFMEyN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="LYvqtNTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB63521655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HBGBkL7by44ARpnixbZacquLhukdK+oF1srDZl//gT4=; b=CSoFMEyN+7ClgN zdD2e3ViGogL2e+QfyBWwM286PYC9PRqYII+FKlRN65PnaTSMpovL1OwsPlNHtb05Kkaru5yf/QQa QFxDfgw9zDQRFdVTSZBpcaG+EWWNXaV/flW2jEwduCgpSeC/xxPI1sHR9IG0DmHgvlSO4y9eH8Szq Xt81KA05yKhcIeeVDXEj35HdpH0Wq1cmmcl9JwU9JjF7la09k95+8AkP8cP8uET/mdA/qissPlrw6 0iWEO7sJ2a5uDZ2RFEDCaOYzg88j6bDS/wpdkhSWKhTQPyl3PrJ12KiSdWm8T6M0VOdqnruACKFrW 3ega5hCgszK4TjBHpvrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXPtB-00032i-GZ; Sat, 09 May 2020 13:51:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jXPt8-000320-GT for linux-arm-kernel@lists.infradead.org; Sat, 09 May 2020 13:51:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2uygEucO5eCGyC1Yl+l/qEGrNAjV1cjP3RBl/px8ykw=; b=LYvqtNTkAfpe2zWTtXqs0AlVr JSY/8pWu8EKEKUpiD3KHRAIrqtN/gZWHmvDAyeY6MYSSAmSw+HjwcOoURlbOlMtkwKx/eYWaE8NAe estJ6I3KznNOQ+XT5SNmMxkySCAiYeQP46EeJpLbeso6Y8i7JQkzn6aN7sAwovHwQVrnnSLUoWnMD ilbvI8F/q0AhjOMwccK28a53kaB6tg7R3G2bnyHC/TP5TqmVJrbWwsESPcr/dVb8e4e1p590UHxg/ o8aW5eD5kKR+Vb8IK/zowKmzjpCn3Fzib3PAmwVQNiVk4K6VhAboF9Et6ayykFoPahOH1R55nlk/S tFwQiXG3w==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38036) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXPsk-00044H-Uh; Sat, 09 May 2020 14:51:11 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jXPsf-0002u4-W2; Sat, 09 May 2020 14:51:06 +0100 Date: Sat, 9 May 2020 14:51:05 +0100 From: Russell King - ARM Linux admin To: Matteo Croce Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Message-ID: <20200509135105.GE1551@shell.armlinux.org.uk> References: <20190524100554.8606-1-maxime.chevallier@bootlin.com> <20190524100554.8606-4-maxime.chevallier@bootlin.com> <20200423170003.GT25745@shell.armlinux.org.uk> <20200509114518.GB1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200509_065134_549026_6CFEEDBB X-CRM114-Status: GOOD ( 24.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antoine Tenart , netdev , "gregory.clement@bootlin.com" , LKML , Maxime Chevallier , Nadav Haklai , Thomas Petazzoni , "miquel.raynal@bootlin.com" , Stefan Chulski , Marcin Wojtas , "David S . Miller" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 09, 2020 at 03:14:05PM +0200, Matteo Croce wrote: > On Sat, May 9, 2020 at 1:45 PM Russell King - ARM Linux admin > wrote: > > > > On Sat, May 09, 2020 at 11:15:58AM +0000, Stefan Chulski wrote: > > > > > > > > > > -----Original Message----- > > > > From: Matteo Croce > > > > Sent: Saturday, May 9, 2020 3:13 AM > > > > To: David S . Miller > > > > Cc: Maxime Chevallier ; netdev > > > > ; LKML ; Antoine > > > > Tenart ; Thomas Petazzoni > > > > ; gregory.clement@bootlin.com; > > > > miquel.raynal@bootlin.com; Nadav Haklai ; Stefan > > > > Chulski ; Marcin Wojtas ; Linux > > > > ARM ; Russell King - ARM Linux admin > > > > > > > > Subject: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to > > > > handle RSS tables > > > > > > > > Hi, > > > > > > > > What do you think about temporarily disabling it like this? > > > > > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > > @@ -5775,7 +5775,8 @@ static int mvpp2_port_probe(struct platform_device > > > > *pdev, > > > > NETIF_F_HW_VLAN_CTAG_FILTER; > > > > > > > > if (mvpp22_rss_is_supported()) { > > > > - dev->hw_features |= NETIF_F_RXHASH; > > > > + if (port->phy_interface != PHY_INTERFACE_MODE_SGMII) > > > > + dev->hw_features |= NETIF_F_RXHASH; > > > > dev->features |= NETIF_F_NTUPLE; > > > > } > > > > > > > > > > > > David, is this "workaround" too bad to get accepted? > > > > > > Not sure that RSS related to physical interface(SGMII), better just remove NETIF_F_RXHASH as "workaround". > > > > Hmm, I'm not sure this is the right way forward. This patch has the > > effect of disabling: > > > > d33ec4525007 ("net: mvpp2: add an RSS classification step for each flow") > > > > but the commit you're pointing at which caused the regression is: > > > > 895586d5dc32 ("net: mvpp2: cls: Use RSS contexts to handle RSS tables") > > > > > > Hi, > > When git bisect pointed to 895586d5dc32 ("net: mvpp2: cls: Use RSS > contexts to handle RSS tables"), which was merged > almost an year after d33ec4525007 ("net: mvpp2: add an RSS > classification step for each flow"), so I assume that between these > two commits either the feature was working or it was disable and we > didn't notice > > Without knowing what was happening, which commit should my Fixes tag point to? Let me make sure that I get this clear: - Prior to 895586d5dc32, you can turn on and off rxhash without issue on any port. - After 895586d5dc32, turning rxhash on eth2 prevents reception. Prior to 895586d5dc32, with rxhash on, it looks like hashing using CRC32 is supported but only one context. So, if it's possible to enable rxhash on any port on the mcbin without 895586d5dc32, and the port continues to work, I'd say the bug was introduced by 895586d5dc32. Of course, that would be reinforced if there was a measurable difference in performance due to rxhash on each port. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel