From: Sudeep Holla <sudeep.holla@arm.com>
To: joe_zhuchg@126.com
Cc: Joe Zhu <Chunguang.Zhu@verisilicon.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 1/1] firmware: arm_scmi/mailbox: ignore notification for tx done using irq
Date: Sat, 9 May 2020 16:20:07 +0100 [thread overview]
Message-ID: <20200509152007.GA18877@bogus> (raw)
In-Reply-To: <20200509085457.31920-1-joe_zhuchg@126.com>
On Sat, May 09, 2020 at 04:54:57PM +0800, joe_zhuchg@126.com wrote:
> From: Joe Zhu <Chunguang.Zhu@verisilicon.com>
>
> If mailbox uses IRQ method, it already notified framework with
> mbox_chan_txdone() in ISR.
>
> Signed-off-by: Joe Zhu <Chunguang.Zhu@verisilicon.com>
> ---
> drivers/firmware/arm_scmi/mailbox.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/arm_scmi/mailbox.c b/drivers/firmware/arm_scmi/mailbox.c
> index 73077bbc4ad9..303a5dc42429 100644
> --- a/drivers/firmware/arm_scmi/mailbox.c
> +++ b/drivers/firmware/arm_scmi/mailbox.c
> @@ -9,6 +9,7 @@
> #include <linux/err.h>
> #include <linux/device.h>
> #include <linux/mailbox_client.h>
> +#include <linux/mailbox_controller.h>
This is an indication that something is wrong. The mailbox controller
and client interfaces are very clear. You need to use mailbox controller
interface when implementing a mailbox controller and use only client
interface when implementing a mailbox client.
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/slab.h>
> @@ -147,7 +148,8 @@ static void mailbox_mark_txdone(struct scmi_chan_info *cinfo, int ret)
> * Unfortunately, we have to kick the mailbox framework after we have
> * received our message.
> */
> - mbox_client_txdone(smbox->chan, ret);
> + if (!smbox->chan->mbox->txdone_irq)
> + mbox_client_txdone(smbox->chan, ret);
If this patch is to avoid getting "Client can't run the TX ticker" error
messages, then you make need to fix that with something like below:
Regards,
Sudeep
-->8
diff --git i/drivers/mailbox/mailbox.c w/drivers/mailbox/mailbox.c
index 0b821a5b2db8..5a78a0adcce4 100644
--- i/drivers/mailbox/mailbox.c
+++ w/drivers/mailbox/mailbox.c
@@ -189,7 +189,9 @@ EXPORT_SYMBOL_GPL(mbox_chan_txdone);
void mbox_client_txdone(struct mbox_chan *chan, int r)
{
if (unlikely(!(chan->txdone_method & TXDONE_BY_ACK))) {
- dev_err(chan->mbox->dev, "Client can't run the TX ticker\n");
+ if (unlikely(!(chan->txdone_method & TXDONE_BY_IRQ)))
+ dev_err(chan->mbox->dev,
+ "Client can't run the TX ticker\n");
return;
}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-09 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 8:54 [PATCH 1/1] firmware: arm_scmi/mailbox: ignore notification for tx done using irq joe_zhuchg
2020-05-09 15:20 ` Sudeep Holla [this message]
2020-05-11 0:52 ` 答复: " Zhu, Joe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509152007.GA18877@bogus \
--to=sudeep.holla@arm.com \
--cc=Chunguang.Zhu@verisilicon.com \
--cc=joe_zhuchg@126.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).