From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E812C47255 for ; Mon, 11 May 2020 07:42:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC59E2082E for ; Mon, 11 May 2020 07:42:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dmKrF7QM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC59E2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oy0sa8axlxWxENRwZ6tOW6uGq3A3nELPSbrRIJTGJTI=; b=dmKrF7QMBP+HCV QxSLya7P3dbC2LDBsXInflpEhT4n70SW4n/YdzpO6RjohHpxSYkwUbpRwX3bnd2RGBFW37hXnGtgc 9utla5tRCVzdxp63QqywplR/4/IsRLHxcepmJQ0iKwhjDAzoJQ8gSKurTNMTconYzaFhJD6a04kPy vEfu8we1Yvw2bY0yKPvgJQPws/ZQ8WljmlhrXQh/5UwjT2C4r7RYAdkwW3LUGlNVchoMWiUS78sXA +N4vzvmfPaObQtFKTadQM8LV1kNVbWYtTkXnUcjt6bESMo2w/Mc8hgFSTvSn0ciHiBrbVWgT18un1 LGhW/6PVQb2KqXLvps8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY35H-0007EX-Tm; Mon, 11 May 2020 07:42:43 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY35C-0007AF-Om for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 07:42:40 +0000 Received: by mail-ed1-f68.google.com with SMTP id e10so375418edq.0 for ; Mon, 11 May 2020 00:42:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/gXH+5V1OhGf0lDZmtXQexZA4f2X1Oj6FaM9kDcTW/I=; b=nIis/z1U0G/Vrke0zMaJbtUJFbBgjE8e2teqZrgQZ8eBbHOGeG6vT5M05AgcCFRZHF yiNmzz4nlSTuh/0BQO5RYt+/EG66UxmqIsHn+W0Hyke9IjMoDHdcK1jfkBXrv0upfXI7 tElHuFJb2+ehqiABsrsH11LBrx9UsT6AnGvVmglN3gq5bB7pIYFeaM5QBa4O1LGuj70z 37qn28J++hmIW1MDVHwq7IvoAyt7fbyt6+VvNg9s8aZngQKGMz6mNu0Q7I46xa950p3+ yF+Faml2qFuTeMBRktzT20Ue4jQqUu1yB+YIq/oJjokLSzukwGCHzPbwsscP0NoBoNkD FGYw== X-Gm-Message-State: AGi0PubgkXSnv3lWQBpf3NjJJrsZG995qovTMJKeLC1H1B97nE7dhC99 32QQywqiuGiUnUXkCCQnUNI= X-Google-Smtp-Source: APiQypKNXJxBqeWKUcQZCLy5hhnnh16d804wT763ceEEJlpi/zqQEfidD1ZPGObtTh2DAv0fOSjHSw== X-Received: by 2002:a05:6402:1d23:: with SMTP id dh3mr12214214edb.349.1589182956149; Mon, 11 May 2020 00:42:36 -0700 (PDT) Received: from kozik-lap ([194.230.155.237]) by smtp.googlemail.com with ESMTPSA id g20sm1194769ejb.41.2020.05.11.00.42.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 May 2020 00:42:35 -0700 (PDT) Date: Mon, 11 May 2020 09:42:32 +0200 From: Krzysztof Kozlowski To: Jonathan Cameron Subject: Re: [PATCH] iio: adc: Add scaling support to exynos adc driver Message-ID: <20200511074232.GA7134@kozik-lap> References: <20200510112417.1e54d66e@archlinux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200510112417.1e54d66e@archlinux> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_004238_822814_DC767475 X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, linux-samsung-soc@vger.kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org, mpe@ellerman.id.au, Jonathan Bakker , linux-kernel@vger.kernel.org, swboyd@chromium.org, cw00.choi@samsung.com, kgene@kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 10, 2020 at 11:24:17AM +0100, Jonathan Cameron wrote: > On Fri, 8 May 2020 14:14:00 -0700 > Jonathan Bakker wrote: > > > Currently the driver only exposes the raw counts. As we > > have the regulator voltage and the maximum value (stored in > > the data mask), we can trivially produce a scaling fraction > > of voltage / max value. > > > > This assumes that the regulator voltage is in fact the max > > voltage, which appears to be the case for all mainline dts > > and cross referenced with the public Exynos4412 and S5PV210 > > datasheets. > > > > Signed-off-by: Jonathan Bakker > > Seems reasonable to me. I'd like an exynos Ack though before applying. It's correct, at least with ARMv7 Exynos datasheets The few ARMv8 Exynos chips are silent about the voltage levels. The Exynos 7 DTS board in mainline kernel does not have regulator but it looks clearly like mistake. I think they behave the same, so for Exynos: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > thanks, > > Jonathan > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel