From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4497BC47255 for ; Mon, 11 May 2020 14:59:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B18206F9 for ; Mon, 11 May 2020 14:59:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M0yqrsyB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wKZwMCRG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B18206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EVYMguRt/37zQgw+Dsax5qH8TjL+1xIkOyEGbFxp6wk=; b=M0yqrsyBLT7yIR baYfdOSQLJEbfa75IyvDjWwwcLfj8s/H2w2eAAYd894jRLF72IabcPU2LDCpgzY4ZmdGdwDZSgb9q 20Tw/YvRMIzd+B62NsHFisszjFcGt37Ml1DZIjc1HQ6AlEnB4fm7inkGe8F5KYHTupCqiF7i6p3yA o/ayi4hybiIAfc0/Pk0GWQzlZmjESCXstwvkjo+bZj03h3dzIY0tHZwR/o8Nn1QDzRaRf7D5uB0zq RiESK1hSJ9S4+X8sfmeJ6NPHHKUCXLNnDrqb+JCriGSN6Tyy3do27QVYOFVR/l21h5Ig8mpeIaaqJ QXcTRfzIgd0JzxIO69DA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY9tx-0003iR-7q; Mon, 11 May 2020 14:59:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jY9tl-0003Yb-9m for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 14:59:18 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B959420643; Mon, 11 May 2020 14:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589209157; bh=h6Ea4lLoHxX7Auk/jUvpA6sDRTJxI89bcfhFCCCylgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wKZwMCRGb/qPVQrXagi72UbQrDDDpUCfscELhKXUCYWtWz/96oJ3TsTAVuOo9hq3N OTup9e3bn90dJWWmHxlKrSdmxAXWW+8b1fClhGGt1d9f8pbz6odwWVeOYY4PQ/tUpC Fx64l5wovGXZdTUhdEqOyQyid+5J32xaXo4AOdek= Date: Mon, 11 May 2020 15:59:09 +0100 From: Will Deacon To: Douglas Anderson Subject: Re: [PATCH v3 05/11] arm64: Add call_break_hook() to early_brk64() for early kgdb Message-ID: <20200511145908.GA22040@willie-the-truck> References: <20200428211351.85055-1-dianders@chromium.org> <20200428141218.v3.5.I22067ad43e77ddfd4b64c2d49030628480f9e8d9@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428141218.v3.5.I22067ad43e77ddfd4b64c2d49030628480f9e8d9@changeid> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_075917_356532_E3ADF014 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, bjorn.andersson@linaro.org, hpa@zytor.com, frowand.list@gmail.com, daniel.thompson@linaro.org, corbet@lwn.net, jinho lim , agross@kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Dave Martin , Masami Hiramatsu , jslaby@suse.com, Alexios Zavras , bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, Allison Randal , sumit.garg@linaro.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, James Morse , "Eric W. Biederman" , jason.wessel@windriver.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Doug, On Tue, Apr 28, 2020 at 02:13:45PM -0700, Douglas Anderson wrote: > diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c > index 48222a4760c2..59c353dfc8e9 100644 > --- a/arch/arm64/kernel/debug-monitors.c > +++ b/arch/arm64/kernel/debug-monitors.c > @@ -297,7 +297,7 @@ void unregister_kernel_break_hook(struct break_hook *hook) > unregister_debug_hook(&hook->node); > } > > -static int call_break_hook(struct pt_regs *regs, unsigned int esr) > +int call_break_hook(struct pt_regs *regs, unsigned int esr) > { > struct break_hook *hook; > struct list_head *list; > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index cf402be5c573..a8173f0c1774 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -1044,6 +1044,9 @@ int __init early_brk64(unsigned long addr, unsigned int esr, > if ((comment & ~KASAN_BRK_MASK) == KASAN_BRK_IMM) > return kasan_handler(regs, esr) != DBG_HOOK_HANDLED; > #endif > + if (call_break_hook(regs, esr) == DBG_HOOK_HANDLED) > + return 0; I think this just means we're not running debug_traps_init() early enough, and actually the KASAN early handler is unnecessary too. If we call debug_traps_init() directly from setup_arch() and drop the arch_initcall(), can we then drop early_brk64 entirely? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel