From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Kathiravan T <kathirav@codeaurora.org>
Cc: alexander.shishkin@linux.intel.com, mike.leach@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com
Subject: Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once
Date: Mon, 11 May 2020 10:58:51 -0600 [thread overview]
Message-ID: <20200511165851.GB13202@xps15> (raw)
In-Reply-To: <1588933721-18700-1-git-send-email-kathirav@codeaurora.org>
Hi Kathiravan,
On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote:
> When more than one coresight components uses the obsolete DT bindings,
> warning is displayed for only one component and not for the others.
> Lets warn it for all components by replacing dev_warn_once with dev_warn.
>
> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
> ---
> drivers/hwtracing/coresight/coresight-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 43418a2..b7d9a02 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev,
> if (!parent) {
> legacy_binding = true;
> parent = node;
> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n");
We made a concious decision to use dev_warn_once() rather than dev_warn().
There can be a lot of coresight devices on a platform and warning for every
device doesn't do anything more than adding noise.
If one device is using obsolete bindings the others very likely to do so as
well. While fixing one device, checking the remaining devices should be
intuitive.
Thanks,
Mathieu
> }
>
> conn = pdata->conns;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-11 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 10:28 [PATCH] coresight: platform: use dev_warn instead of dev_warn_once Kathiravan T
2020-05-11 16:58 ` Mathieu Poirier [this message]
2020-05-11 17:31 ` Suzuki K Poulose
2020-05-13 12:36 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511165851.GB13202@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=kathirav@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox