From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33561C54E4B for ; Tue, 12 May 2020 08:57:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F01F32072B for ; Tue, 12 May 2020 08:57:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BN0qPJqF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F01F32072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ApkhVFaKFlbf5kUcTrZRH0itsG/cpLalZ67Fk0g8KkQ=; b=BN0qPJqFENZPWL GU0UZlZPfeOIOiqpiP+fk0svxUej45Ku+rDvTfJJ5NPcjCfBRIF0Fh4b8qrpuTqW2FH2IezgSEtVA Jyr/RP2a4QVZ+Zp6/0sSqZRgaT3frt8H2ZVAYG5a+NfubInvyhZ3FGYae8bzHpkSEFEEBd3yw5J68 6T0WcZqlPn3j6bfQfm+MUnHcy/d7a6Kbuv29r1PNfek1QnxctzMu0VSZocqE4idA4zVjAsAVa1oOP WzdpBgHwE/vPtLCs2U4ybIzacJqxn4sY0JVklRJJFfsbn+RPS1hv7yLk8Bphr8o6vfNLiYehzeGJd ELHIgIP/2OgKX37VYxTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYQjV-0006lh-2N; Tue, 12 May 2020 08:57:49 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYQjQ-0006jg-6A; Tue, 12 May 2020 08:57:44 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A91C4305EEF; Tue, 12 May 2020 10:57:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 929A3286BFA73; Tue, 12 May 2020 10:57:41 +0200 (CEST) Date: Tue, 12 May 2020 10:57:41 +0200 From: Peter Zijlstra To: Leo Yan Subject: Re: [PATCH v2 0/3] arm64: perf_event: Fix time offset prior to epoch Message-ID: <20200512085741.GG2978@hirez.programming.kicks-ass.net> References: <20200505135544.6003-1-leo.yan@linaro.org> <20200511092200.GF2957@hirez.programming.kicks-ass.net> <20200511092519.GA3001@hirez.programming.kicks-ass.net> <20200512063812.GA20352@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200512063812.GA20352@leoy-ThinkPad-X240s> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , Enrico Weigelt , Greg Kroah-Hartman , Alexander Shishkin , Marc Zyngier , Jiri Olsa , Daniel Lezcano , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Paul Cercueil , Alexios Zavras , "Ahmed S. Darwish" , Ingo Molnar , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Namhyung Kim , Thomas Gleixner , Will Deacon , "Ben Dooks \(Codethink\)" , Allison Randal Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 12, 2020 at 02:38:12PM +0800, Leo Yan wrote: > I have verified this change, it works as expected on my Arm64 board. > Also paste the updated code which makes building success with minor > fixing. W00t ! > I am not sure how to proceed, will you merge this? Or you want me to > send out formal patches (or only for the Arm64 part)? I suppose I can write a Changelog for the thing, Will asked for another change as well. > P.s. it's shame I still missed you guys suggestion in prvious thread > even though you have provide enough ifno, and thank you for the helping! All good. > ---8<--- > - /* > - * time_shift is not expected to be greater than 31 due to > - * the original published conversion algorithm shifting a > - * 32-bit value (now specifies a 64-bit value) - refer > - * perf_event_mmap_page documentation in perf_event.h. > - */ > - if (shift == 32) { > - shift = 31; > - userpg->time_mult >>= 1; > - } Is there a reason you completely lost that? IIRC I preserved that. Although I don't know if it is still relevant. I'll keep it for now, and removal can be a separate patch with proper justification, ok? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel