From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C15BC54E8B for ; Tue, 12 May 2020 10:56:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D2AC20722 for ; Tue, 12 May 2020 10:56:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AoMStd5a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D2AC20722 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SADvsmQ/0qKitki+Hi42OavcnN12vlUs4M5Qh8kS3+8=; b=AoMStd5aH/VeZf TAPH2pizELcIy/VJdYHdCL0rZ7z9IaljZ0VolrvmJ6uJ9nD56xwP+AcJ6w9cvaevlxWLowaxg3Tug ejE01civ7gxuC/5VlX9My3C6gMbReg9PWAGX5YaB1VZkIudHqJSFyjV4aHxHKsc/p5mAVO/8SJ2y1 v/3tGXerzenKpdBmIbwvJMSq58mFRdbW06Zl64kkcxKnjDpbwKRg5R7WuQ3ITMXvoAAc0R73+zx/0 h4SGwBo5wuQmo/7etyqkoJMgQvt07ujGfPQ1poMX1C1lzhpvcljPmQ6tARVAqqp0qycKHjavB3dDR ZZxDBgJFv7JpZgW7plbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYSaG-0004aq-W4; Tue, 12 May 2020 10:56:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYSaC-0004a5-IB for linux-arm-kernel@lists.infradead.org; Tue, 12 May 2020 10:56:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A26A530E; Tue, 12 May 2020 03:56:19 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.28.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD7243F71E; Tue, 12 May 2020 03:56:17 -0700 (PDT) Date: Tue, 12 May 2020 11:56:14 +0100 From: Mark Rutland To: Anshuman Khandual Subject: Re: [PATCH] arm64/cpufeature: Add ID_AA64MMFR0_PARANGE_MASK Message-ID: <20200512105614.GC60359@C02TD0UTHF1T.local> References: <1589249606-27177-1-git-send-email-anshuman.khandual@arm.com> <20200512105343.GB60359@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200512105343.GB60359@C02TD0UTHF1T.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200512_035620_645106_CDC29948 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , Marc Zyngier , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 12, 2020 at 11:53:43AM +0100, Mark Rutland wrote: > > > > /* Clamp the IPA limit to the PA size supported by the kernel */ > > ipa_max = (pa_max > PHYS_MASK_SHIFT) ? PHYS_MASK_SHIFT : pa_max; > > @@ -411,7 +411,8 @@ int kvm_arm_setup_stage2(struct kvm *kvm, unsigned long type) > > phys_shift = KVM_PHYS_SHIFT; > > } > > > > - parange = read_sanitised_ftr_reg(SYS_ID_AA64MMFR0_EL1) & 7; > > + parange = id_aa64mmfr0_parange(read_sanitised_ftr_reg > > + (SYS_ID_AA64MMFR0_EL1)); > > Can't we add a system_ipa_range() helper, and avoid more boilerplate in > each of these? > > e.g. > > int system_ipa_range(void) > { > u64 mmfr0; > int parange; > > mmfr0 = read_sanitised_ftr_reg(SYS_ID_AA64MMFR0_EL1); > parange = cpuid_feature_extract_unsigned_field(mmfr0, > ID_AA64MMFR0_PARANGE_SHIFT); > > return parange; > } As Per MarcZ's comments, that should be system_pa_range() rather than system_ipa_range(). Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel