From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C24C54E4A for ; Tue, 12 May 2020 13:09:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E726206CC for ; Tue, 12 May 2020 13:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZIrHPM9n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E726206CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w/alh/BN4yKGEnyj+LmA1sXJrofmH2oD/LUb1H9+1ZU=; b=ZIrHPM9nKdWaxP QlAsE23WKEmSRdSEzSeYtZkQAqZL1Aqls3J2zgQ3EBFt1ExN7qVDfKMJtSot5uE/hsTQtBeZ9Kd6f BLoQu4GUAv99AsuqIz7lJBODK7GDy700mYq0l45heZgbAYJdcANJyOAEQ8Nuq9jhExlYDu7eje9OO 1QbzEbHCS7tIps0xFP1uGfM2KgWbvPclsOuDoxLZXzjXBPGxG0t+0Rdhre9WvVsdmYlsjdhBHFFm0 Eq2wAMC5rbPgEPsT4cdcbTTwphEjDCRhfkzz0nXM6gHs0SNQNAQg0XrfTle7Fuhou9FTNZOwotL5L b3AyRmyBKUC3vb2yiE2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYUfG-0005Bk-Ou; Tue, 12 May 2020 13:09:42 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYUfD-0005BO-Ay for linux-arm-kernel@lists.infradead.org; Tue, 12 May 2020 13:09:40 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6FB5F68BEB; Tue, 12 May 2020 15:09:36 +0200 (CEST) Date: Tue, 12 May 2020 15:09:36 +0200 From: Christoph Hellwig To: Marek Szyprowski Subject: Re: [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects Message-ID: <20200512130936.GA24428@lst.de> References: <20200512085710.14688-1-m.szyprowski@samsung.com> <20200512090058.14910-1-m.szyprowski@samsung.com> <20200512121808.GA20393@lst.de> <1a80255d-81de-2c5d-6d06-ea126fd7f994@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1a80255d-81de-2c5d-6d06-ea126fd7f994@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200512_060939_524598_CFE4C2CA X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartlomiej Zolnierkiewicz , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org, Daniel Vetter , Robin Murphy , Christoph Hellwig , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 12, 2020 at 03:00:31PM +0200, Marek Szyprowski wrote: > > if (n <= 0) > > return -EINVAL; > > sgt->nents = n; > > return 0; > > > Indeed this version looks much better. I will resend it in a few minutes. I could also just fix it up when applying the patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel