* [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static
@ 2020-05-12 2:29 Samuel Zou
2020-05-13 9:02 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Zou @ 2020-05-12 2:29 UTC (permalink / raw)
To: jun.nie, shawnguo, linux; +Cc: Samuel Zou, linux-kernel, linux-arm-kernel
Fix the following sparse warning:
arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared.
The zx_smp_prepare_cpus has only call site within platsmp.c
It should be static
Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
arch/arm/mach-zx/platsmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
index d4e1d37..43a33ea 100644
--- a/arch/arm/mach-zx/platsmp.c
+++ b/arch/arm/mach-zx/platsmp.c
@@ -38,7 +38,7 @@ static void __iomem *pcu_base;
static void __iomem *matrix_base;
static void __iomem *scu_base;
-void __init zx_smp_prepare_cpus(unsigned int max_cpus)
+static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
{
struct device_node *np;
unsigned long base = 0;
--
2.6.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static
2020-05-12 2:29 [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static Samuel Zou
@ 2020-05-13 9:02 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2020-05-13 9:02 UTC (permalink / raw)
To: Samuel Zou, Arnd Bergmann; +Cc: jun.nie, linux, linux-arm-kernel, linux-kernel
On Tue, May 12, 2020 at 10:29:21AM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared.
>
> The zx_smp_prepare_cpus has only call site within platsmp.c
> It should be static
>
> Fixes: 71bc724300e6 ("ARM: zx: enable SMP and hotplug for zx296702")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
Hi Arnd,
Can you please apply it to arm-soc tree?
Shawn
> ---
> arch/arm/mach-zx/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c
> index d4e1d37..43a33ea 100644
> --- a/arch/arm/mach-zx/platsmp.c
> +++ b/arch/arm/mach-zx/platsmp.c
> @@ -38,7 +38,7 @@ static void __iomem *pcu_base;
> static void __iomem *matrix_base;
> static void __iomem *scu_base;
>
> -void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> +static void __init zx_smp_prepare_cpus(unsigned int max_cpus)
> {
> struct device_node *np;
> unsigned long base = 0;
> --
> 2.6.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 2:29 [PATCH -next] ARM: zx: Make zx_smp_prepare_cpus static Samuel Zou
2020-05-13 9:02 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).