linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, iommu@lists.linux-foundation.org,
	Daniel Vetter <daniel@ffwll.ch>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 03/38] iommu: add generic helper for mapping sgtable objects
Date: Wed, 13 May 2020 11:03:21 +0200	[thread overview]
Message-ID: <20200513090320.GH9820@8bytes.org> (raw)
In-Reply-To: <20200512090058.14910-3-m.szyprowski@samsung.com>

Hi Marek,

On Tue, May 12, 2020 at 11:00:23AM +0200, Marek Szyprowski wrote:
> ---
>  include/linux/iommu.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)

Some nits below, with those fixed:

	Acked-by: Joerg Roedel <jroedel@suse.de>

> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 7cfd2dd..ba662ba 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -478,6 +478,22 @@ extern size_t iommu_map_sg_atomic(struct iommu_domain *domain,
>  extern void iommu_set_fault_handler(struct iommu_domain *domain,
>  			iommu_fault_handler_t handler, void *token);
>  
> +/**
> + * iommu_map_sgtable - Map the given buffer to the IOMMU domain
> + * @domain:	The IOMMU domain to perfor
                                    ^^^^^^ Truncated comment?
> + * @iova:	The start addrees to map the buffer
                          ^^^^^^^ Typo

> + * @sgt:	The sg_table object describing the buffer
> + * @prot:	IOMMU protection bits
> + *
> + * Create a mapping at @iova for the buffer described by a scatterlist
> + * stored in the given sg_table object in the provided IOMMU domain.
> + */
> +static inline size_t iommu_map_sgtable(struct iommu_domain *domain,
> +			unsigned long iova, struct sg_table *sgt, int prot)
> +{
> +	return iommu_map_sg(domain, iova, sgt->sgl, sgt->orig_nents, prot);
> +}
> +
>  extern void iommu_get_resv_regions(struct device *dev, struct list_head *list);
>  extern void iommu_put_resv_regions(struct device *dev, struct list_head *list);
>  extern void generic_iommu_put_resv_regions(struct device *dev,
> -- 
> 1.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-13  9:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200512085722eucas1p2fbaab30e49c9ddadc64b27db856e5921@eucas1p2.samsung.com>
2020-05-12  8:57 ` [PATCH v4 00/38] DRM: fix struct sg_table nents vs. orig_nents misuse Marek Szyprowski
2020-05-12  9:00   ` [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 02/38] scatterlist: add generic wrappers for iterating over " Marek Szyprowski
2020-05-12 12:18       ` Christoph Hellwig
2020-05-13 13:24       ` Robin Murphy
2020-05-12  9:00     ` [PATCH v4 03/38] iommu: add generic helper for mapping " Marek Szyprowski
2020-05-12 12:18       ` Christoph Hellwig
2020-05-13  9:03       ` Joerg Roedel [this message]
2020-05-13 13:27       ` Robin Murphy
2020-05-12  9:00     ` [PATCH v4 04/38] drm: prime: add common helper to check scatterlist contiguity Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 05/38] drm: prime: use sgtable iterators in drm_prime_sg_to_page_addr_arrays() Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 06/38] drm: core: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 07/38] drm: amdgpu: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 08/38] drm: armada: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 09/38] drm: etnaviv: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 10/38] drm: exynos: use common helper for a scatterlist contiguity check Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 11/38] drm: exynos: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 12/38] drm: i915: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 13/38] drm: lima: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 14/38] drm: mediatek: use common helper for a scatterlist contiguity check Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 15/38] drm: mediatek: use common helper for extracting pages array Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 16/38] drm: msm: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 17/38] drm: omapdrm: use common helper for extracting pages array Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 18/38] drm: omapdrm: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 19/38] drm: panfrost: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 20/38] drm: radeon: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 21/38] drm: rockchip: use common helper for a scatterlist contiguity check Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 22/38] drm: rockchip: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 23/38] drm: tegra: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 24/38] drm: v3d: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 25/38] drm: virtio: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 26/38] drm: vmwgfx: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 27/38] xen: gntdev: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 28/38] drm: host1x: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 29/38] drm: rcar-du: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 30/38] dmabuf: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 31/38] staging: ion: remove dead code Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 32/38] staging: ion: fix common struct sg_table related issues Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 33/38] staging: tegra-vde: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 34/38] misc: fastrpc: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 35/38] rapidio: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 36/38] samples: vfio-mdev/mbochs: " Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 37/38] media: pci: fix common ALSA DMA-mapping related codes Marek Szyprowski
2020-05-12  9:00     ` [PATCH v4 38/38] videobuf2: use sgtable-based scatterlist wrappers Marek Szyprowski
2020-05-12 17:52       ` Ruhl, Michael J
2020-05-12 20:33         ` Marek Szyprowski
2020-05-13 12:01           ` Ruhl, Michael J
2020-05-12 12:18     ` [PATCH v4 01/38] dma-mapping: add generic helpers for mapping sgtable objects Christoph Hellwig
2020-05-12 13:00       ` Marek Szyprowski
2020-05-12 13:09         ` Christoph Hellwig
2020-05-12 13:19           ` Marek Szyprowski
2020-05-13 13:23     ` Robin Murphy
2020-05-12 12:19   ` [PATCH v4 00/38] DRM: fix struct sg_table nents vs. orig_nents misuse Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513090320.GH9820@8bytes.org \
    --to=joro@8bytes.org \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).