Re: [PATCH v8 2/3] drivers: input: keyboard: Add mtk keypad driver

Andy Shevchenko
2020-05-15T11:40:48Z

On Fri, May 15, 2020 at 11:30:16AM +0200, Marco Felsch wrote:
> On 20-05-15 14:20, Fengping Yu wrote:

...

> > + depends on OF && HAVE_CLK
>
> Please drop those deps and instead use:

+1

> depends on ARCH_MEDIATEK && ARM64

I would go even further
depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST

> There are still some missing deps:
>
> select CONFIG_REGMAP_MMIO
> select INPUT_MATRIXKMAP

...

> > +#define MTK_KPD_DEBOUNCE_MAX_US 256000 /*256ms */
>
> Thanks for aligning the defines but the 256ms comment is still useless
> as Andy already said.

Yes, it seems my comments partially (?) have been ignored.

--
With Best Regards,
Andy Shevchenko