From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E644FC433E0 for ; Fri, 15 May 2020 09:25:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3EE720709 for ; Fri, 15 May 2020 09:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QHRNo9rI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3EE720709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xeTWLOlg7SUTXvxBGcPw/ddmCga/oZw/Mbij99Pd3uU=; b=QHRNo9rIQJ5eEK 2x/VKGwX6r2FifMXuSxCiopoh/VwAvtq7i00EVSUyYgkd5Cxox4snkTxycY5WDPhiCTecMTSyj3uI r9m+GkEn6TvyxqWwEFwLfZZMI+5aAf8l3S4rn3OyhUPEpn+aBdMpj6KPFFUc2w42jPh7YLkBbHUuP STZPxDZSq/BQFaonsKmnVsdohhKL3jR8eYogZqc0Y8RrOaWkP/LPXdxXqpG3I0X/WpYknkUfJa8ri 6F28My9kFQwXcixO0mh6ieZkghqcUdVCxeuC8Iz/yFnCpwNucSpgaLGdQnOYyJZxh03LU42TQsdxi veKtSDXJJbehSEQ3OSOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZWad-0004lZ-2f; Fri, 15 May 2020 09:25:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZWaW-0003I8-Ni for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 09:25:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C428C2F; Fri, 15 May 2020 02:25:03 -0700 (PDT) Received: from bogus (unknown [10.37.12.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF31D3F71E; Fri, 15 May 2020 02:25:00 -0700 (PDT) Date: Fri, 15 May 2020 10:24:57 +0100 From: Sudeep Holla To: Etienne Carriere Subject: Re: [PATCH 2/2] firmware: psci: support SMCCC v1.2 for SMCCC conduit Message-ID: <20200515092457.GB23671@bogus> References: <20200514082109.27573-1-etienne.carriere@linaro.org> <20200514082109.27573-2-etienne.carriere@linaro.org> <20200514142442.GB23401@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_022504_841201_F849BA19 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , lorenzo.pieralisi@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, Steven Price , alexios.zavras@intel.com, Thomas Gleixner , will@kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 14, 2020 at 04:56:53PM +0200, Etienne Carriere wrote: > On Thu, 14 May 2020 at 16:24, Sudeep Holla wrote: > > > > On Thu, May 14, 2020 at 10:21:09AM +0200, Etienne Carriere wrote: > > > Update PSCI driver to support SMCCC v1.2 reported by secure firmware > > > and indirectly make SMCCC conduit properly set when so. TF-A release > > > v2.3 implements and reports SMCCC v1.2 since commit [1]. > > > > > > Link: [1] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=e34cc0cedca6e229847c232fe58d37fad2610ce9 > > > Signed-off-by: Etienne Carriere > > > --- > > > drivers/firmware/psci/psci.c | 14 ++++++++++---- > > > include/linux/psci.h | 1 + > > > 2 files changed, 11 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > > > index 2937d44b5df4..80cf73bea4b0 100644 > > > --- a/drivers/firmware/psci/psci.c > > > +++ b/drivers/firmware/psci/psci.c > > > @@ -409,11 +409,17 @@ static void __init psci_init_smccc(void) > > > feature = psci_features(ARM_SMCCC_VERSION_FUNC_ID); > > > > > > if (feature != PSCI_RET_NOT_SUPPORTED) { > > > - u32 ret; > > > - ret = invoke_psci_fn(ARM_SMCCC_VERSION_FUNC_ID, 0, 0, 0); > > > - if (ret == ARM_SMCCC_VERSION_1_1) { > > > + ver = invoke_psci_fn(ARM_SMCCC_VERSION_FUNC_ID, 0, 0, 0); > > > + > > > + switch (ver) { > > > + case ARM_SMCCC_VERSION_1_1: > > > psci_ops.smccc_version = SMCCC_VERSION_1_1; > > > - ver = ret; > > > + break; > > > + case ARM_SMCCC_VERSION_1_2: > > > + psci_ops.smccc_version = SMCCC_VERSION_1_2; > > > + break; > > > + default: > > > + break; > > > } > > > } > > > > > > diff --git a/include/linux/psci.h b/include/linux/psci.h > > > index a67712b73b6c..c7d99b7f34ed 100644 > > > --- a/include/linux/psci.h > > > +++ b/include/linux/psci.h > > > @@ -24,6 +24,7 @@ bool psci_has_osi_support(void); > > > enum smccc_version { > > > SMCCC_VERSION_1_0, > > > SMCCC_VERSION_1_1, > > > + SMCCC_VERSION_1_2, > > > > I took approach to kill this completely [1] instead of having to keep > > expanding it for ever. > > Yes, I've been pointed to [1]. Discard this change. Sorry for the > (little) noise. > No worries, it's not a noise, just different approach. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel