* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-04-29 10:36 ` [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device Daniel Lezcano
@ 2020-04-29 20:02 ` Lukasz Luba
2020-04-29 21:01 ` Daniel Lezcano
2020-05-06 9:57 ` Amit Kucheria
2020-06-15 11:25 ` Ulf Hansson
2 siblings, 1 reply; 8+ messages in thread
From: Lukasz Luba @ 2020-04-29 20:02 UTC (permalink / raw)
To: Daniel Lezcano, rui.zhang
Cc: Lorenzo Pieralisi, open list:CPU IDLE TIME MANAGEMENT FRAMEWORK,
Rafael J. Wysocki, open list, Sudeep Holla,
open list:CPUIDLE DRIVER - ARM PSCI
On 4/29/20 11:36 AM, Daniel Lezcano wrote:
> The cpuidle driver can be used as a cooling device by injecting idle
> cycles. The DT binding for the idle state added an optional
>
> When the property is set, register the cpuidle driver with the idle
> state node pointer as a cooling device. The thermal framework will do
> the association automatically with the thermal zone via the
> cooling-device defined in the device tree cooling-maps section.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> - V4:
> - Do not check the return value as the function does no longer return one
> ---
> drivers/cpuidle/cpuidle-arm.c | 3 +++
> drivers/cpuidle/cpuidle-psci.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
> index 9e5156d39627..8c758920d699 100644
> --- a/drivers/cpuidle/cpuidle-arm.c
> +++ b/drivers/cpuidle/cpuidle-arm.c
> @@ -8,6 +8,7 @@
>
> #define pr_fmt(fmt) "CPUidle arm: " fmt
>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -124,6 +125,8 @@ static int __init arm_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
> return 0;
>
> out_kfree_drv:
> diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c
> index bae9140a65a5..1f38e0dfc9b2 100644
> --- a/drivers/cpuidle/cpuidle-psci.c
> +++ b/drivers/cpuidle/cpuidle-psci.c
> @@ -9,6 +9,7 @@
> #define pr_fmt(fmt) "CPUidle PSCI: " fmt
>
> #include <linux/cpuhotplug.h>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -313,6 +314,8 @@ static int __init psci_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
> return 0;
>
> out_kfree_drv:
>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-04-29 20:02 ` Lukasz Luba
@ 2020-04-29 21:01 ` Daniel Lezcano
2020-05-04 18:00 ` Daniel Lezcano
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Lezcano @ 2020-04-29 21:01 UTC (permalink / raw)
To: Lukasz Luba, rui.zhang, Rafael J. Wysocki
Cc: open list:CPU IDLE TIME MANAGEMENT FRAMEWORK, Lorenzo Pieralisi,
open list, open list:CPUIDLE DRIVER - ARM PSCI, Sudeep Holla
On 29/04/2020 22:02, Lukasz Luba wrote:
>
>
> On 4/29/20 11:36 AM, Daniel Lezcano wrote:
>> The cpuidle driver can be used as a cooling device by injecting idle
>> cycles. The DT binding for the idle state added an optional
>>
>> When the property is set, register the cpuidle driver with the idle
>> state node pointer as a cooling device. The thermal framework will do
>> the association automatically with the thermal zone via the
>> cooling-device defined in the device tree cooling-maps section.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> - V4:
>> - Do not check the return value as the function does no longer
>> return one
>> ---
[ ... ]
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Thanks Lukasz for the review.
Rafael, as Lorenzo and Sudeep are not responsive, could you consider ack
this patch so I can merge the series through the thermal tree ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-04-29 21:01 ` Daniel Lezcano
@ 2020-05-04 18:00 ` Daniel Lezcano
2020-05-15 9:58 ` Sudeep Holla
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Lezcano @ 2020-05-04 18:00 UTC (permalink / raw)
To: Lukasz Luba, rui.zhang, Rafael J. Wysocki
Cc: open list:CPU IDLE TIME MANAGEMENT FRAMEWORK, Lorenzo Pieralisi,
open list, open list:CPUIDLE DRIVER - ARM PSCI, Sudeep Holla
Hi,
On 29/04/2020 23:01, Daniel Lezcano wrote:
> On 29/04/2020 22:02, Lukasz Luba wrote:
>>
>>
>> On 4/29/20 11:36 AM, Daniel Lezcano wrote:
>>> The cpuidle driver can be used as a cooling device by injecting idle
>>> cycles. The DT binding for the idle state added an optional
>>>
>>> When the property is set, register the cpuidle driver with the idle
>>> state node pointer as a cooling device. The thermal framework will do
>>> the association automatically with the thermal zone via the
>>> cooling-device defined in the device tree cooling-maps section.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>>> - V4:
>>> - Do not check the return value as the function does no longer
>>> return one
>>> ---
>
> [ ... ]
>
>> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
>
> Thanks Lukasz for the review.
>
> Rafael, as Lorenzo and Sudeep are not responsive, could you consider ack
> this patch so I can merge the series through the thermal tree ?
Gentle ping ... Sudeep, Lorenzo or Rafael ?
Thanks
-- Danie
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-05-04 18:00 ` Daniel Lezcano
@ 2020-05-15 9:58 ` Sudeep Holla
2020-05-15 11:03 ` Daniel Lezcano
0 siblings, 1 reply; 8+ messages in thread
From: Sudeep Holla @ 2020-05-15 9:58 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Lorenzo Pieralisi, open list:CPU IDLE TIME MANAGEMENT FRAMEWORK,
Rafael J. Wysocki, open list, open list:CPUIDLE DRIVER - ARM PSCI,
Sudeep Holla, rui.zhang, Lukasz Luba
On Mon, May 04, 2020 at 08:00:01PM +0200, Daniel Lezcano wrote:
>
> Hi,
>
> On 29/04/2020 23:01, Daniel Lezcano wrote:
> > On 29/04/2020 22:02, Lukasz Luba wrote:
> >>
> >>
> >> On 4/29/20 11:36 AM, Daniel Lezcano wrote:
> >>> The cpuidle driver can be used as a cooling device by injecting idle
> >>> cycles. The DT binding for the idle state added an optional
> >>>
> >>> When the property is set, register the cpuidle driver with the idle
> >>> state node pointer as a cooling device. The thermal framework will do
> >>> the association automatically with the thermal zone via the
> >>> cooling-device defined in the device tree cooling-maps section.
> >>>
> >>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> >>> ---
> >>> - V4:
> >>> - Do not check the return value as the function does no longer
> >>> return one
> >>> ---
> >
> > [ ... ]
> >
> >> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> >
> > Thanks Lukasz for the review.
> >
> > Rafael, as Lorenzo and Sudeep are not responsive, could you consider ack
> > this patch so I can merge the series through the thermal tree ?
>
> Gentle ping ... Sudeep, Lorenzo or Rafael ?
>
Sorry for the delay. I ignore this as it was generic and I was fine with
it. Didn't know you were waiting me, sorry for that.
FWIW:
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-05-15 9:58 ` Sudeep Holla
@ 2020-05-15 11:03 ` Daniel Lezcano
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2020-05-15 11:03 UTC (permalink / raw)
To: Sudeep Holla
Cc: Lorenzo Pieralisi, open list:CPU IDLE TIME MANAGEMENT FRAMEWORK,
Rafael J. Wysocki, open list, open list:CPUIDLE DRIVER - ARM PSCI,
rui.zhang, Lukasz Luba
On 15/05/2020 11:58, Sudeep Holla wrote:
> On Mon, May 04, 2020 at 08:00:01PM +0200, Daniel Lezcano wrote:
>>
>> Hi,
>>
>> On 29/04/2020 23:01, Daniel Lezcano wrote:
>>> On 29/04/2020 22:02, Lukasz Luba wrote:
>>>>
>>>>
>>>> On 4/29/20 11:36 AM, Daniel Lezcano wrote:
>>>>> The cpuidle driver can be used as a cooling device by injecting idle
>>>>> cycles. The DT binding for the idle state added an optional
>>>>>
>>>>> When the property is set, register the cpuidle driver with the idle
>>>>> state node pointer as a cooling device. The thermal framework will do
>>>>> the association automatically with the thermal zone via the
>>>>> cooling-device defined in the device tree cooling-maps section.
>>>>>
>>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>>> ---
>>>>> - V4:
>>>>> - Do not check the return value as the function does no longer
>>>>> return one
>>>>> ---
>>>
>>> [ ... ]
>>>
>>>> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
>>>
>>> Thanks Lukasz for the review.
>>>
>>> Rafael, as Lorenzo and Sudeep are not responsive, could you consider ack
>>> this patch so I can merge the series through the thermal tree ?
>>
>> Gentle ping ... Sudeep, Lorenzo or Rafael ?
>>
>
> Sorry for the delay. I ignore this as it was generic and I was fine with
> it. Didn't know you were waiting me, sorry for that.
No problem, thanks for the ack.
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Rafael, if you are ok with that, I'll take this patch in the thermal
tree along with the others.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-04-29 10:36 ` [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device Daniel Lezcano
2020-04-29 20:02 ` Lukasz Luba
@ 2020-05-06 9:57 ` Amit Kucheria
2020-06-15 11:25 ` Ulf Hansson
2 siblings, 0 replies; 8+ messages in thread
From: Amit Kucheria @ 2020-05-06 9:57 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Lorenzo Pieralisi, open list:CPU IDLE TIME MANAGEMENT FRAMEWORK,
Rafael J. Wysocki, open list, open list:CPUIDLE DRIVER - ARM PSCI,
Sudeep Holla, Zhang Rui, Lukasz Luba
On Wed, Apr 29, 2020 at 4:07 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> The cpuidle driver can be used as a cooling device by injecting idle
> cycles. The DT binding for the idle state added an optional
Incomplete sentence.
> When the property is set, register the cpuidle driver with the idle
> state node pointer as a cooling device. The thermal framework will do
> the association automatically with the thermal zone via the
> cooling-device defined in the device tree cooling-maps section.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Conditionally,
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> - V4:
> - Do not check the return value as the function does no longer return one
> ---
> drivers/cpuidle/cpuidle-arm.c | 3 +++
> drivers/cpuidle/cpuidle-psci.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
> index 9e5156d39627..8c758920d699 100644
> --- a/drivers/cpuidle/cpuidle-arm.c
> +++ b/drivers/cpuidle/cpuidle-arm.c
> @@ -8,6 +8,7 @@
>
> #define pr_fmt(fmt) "CPUidle arm: " fmt
>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -124,6 +125,8 @@ static int __init arm_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
> return 0;
>
> out_kfree_drv:
> diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c
> index bae9140a65a5..1f38e0dfc9b2 100644
> --- a/drivers/cpuidle/cpuidle-psci.c
> +++ b/drivers/cpuidle/cpuidle-psci.c
> @@ -9,6 +9,7 @@
> #define pr_fmt(fmt) "CPUidle PSCI: " fmt
>
> #include <linux/cpuhotplug.h>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -313,6 +314,8 @@ static int __init psci_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
> return 0;
>
> out_kfree_drv:
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device
2020-04-29 10:36 ` [PATCH v4 4/4] thermal: cpuidle: Register cpuidle cooling device Daniel Lezcano
2020-04-29 20:02 ` Lukasz Luba
2020-05-06 9:57 ` Amit Kucheria
@ 2020-06-15 11:25 ` Ulf Hansson
2 siblings, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2020-06-15 11:25 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Lorenzo Pieralisi, open list:CPU IDLE TIME MANAGEMENT FRAMEWORK,
Rafael J. Wysocki, open list, open list:CPUIDLE DRIVER - ARM PSCI,
Sudeep Holla, Zhang Rui, lukasz.luba
On Wed, 29 Apr 2020 at 12:37, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> The cpuidle driver can be used as a cooling device by injecting idle
> cycles. The DT binding for the idle state added an optional
>
> When the property is set, register the cpuidle driver with the idle
> state node pointer as a cooling device. The thermal framework will do
> the association automatically with the thermal zone via the
> cooling-device defined in the device tree cooling-maps section.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> - V4:
> - Do not check the return value as the function does no longer return one
> ---
> drivers/cpuidle/cpuidle-arm.c | 3 +++
> drivers/cpuidle/cpuidle-psci.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-arm.c b/drivers/cpuidle/cpuidle-arm.c
> index 9e5156d39627..8c758920d699 100644
> --- a/drivers/cpuidle/cpuidle-arm.c
> +++ b/drivers/cpuidle/cpuidle-arm.c
> @@ -8,6 +8,7 @@
>
> #define pr_fmt(fmt) "CPUidle arm: " fmt
>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -124,6 +125,8 @@ static int __init arm_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
> return 0;
>
> out_kfree_drv:
> diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c
> index bae9140a65a5..1f38e0dfc9b2 100644
> --- a/drivers/cpuidle/cpuidle-psci.c
> +++ b/drivers/cpuidle/cpuidle-psci.c
> @@ -9,6 +9,7 @@
> #define pr_fmt(fmt) "CPUidle PSCI: " fmt
>
> #include <linux/cpuhotplug.h>
> +#include <linux/cpu_cooling.h>
> #include <linux/cpuidle.h>
> #include <linux/cpumask.h>
> #include <linux/cpu_pm.h>
> @@ -313,6 +314,8 @@ static int __init psci_idle_init_cpu(int cpu)
> if (ret)
> goto out_kfree_drv;
>
> + cpuidle_cooling_register(drv);
> +
Apologies for the late reply, but just noticed this change in v5.8-rc1.
Don't you need a cpuidle_cooling_unregister function? For example,
cpuidle-psci may fail and then calls cpuidle_unregister() to cleans up
things.
Is that okay?
Kind regards
Uffe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread