From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94067C433E0 for ; Fri, 15 May 2020 11:33:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 642E9205CB for ; Fri, 15 May 2020 11:33:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JR4Qj9H6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 642E9205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+ZcAzLHIhKzkGK0prf3sS4Am2dWfYxAReB4dyEez16U=; b=JR4Qj9H6kIu41+ hQ8ZPw0dR4mTEjMnAe/Aon46+OjySqAmYeL5Sslh7MHzKAe7eF+5XeumuV4xaYO8fwi8YK5SIBIHq jLwbKKbRm1tZsgJtH3a4093j4T52lv23QEAIGB0MaDm/QjcAWoy7rEseNrskMneG4k7aYPMlMb7gE 9OrtkC+oC5iiAu6tcs6FxwUCwG6QD0qcCvG+51ir8PfNODZ+s3J85eVW1yFG8gpKhOLJVc+woHVRJ qPVQz2TqyZ9EJiKWIYen4Q8RqtceSNg55k86M+Uevj5wx8P8gNLT9CLU/PXhQvCTHfYyiV/KwxfVT +IQCDO8z1PjAj2ylJAmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYaM-0000uU-A5; Fri, 15 May 2020 11:33:02 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYaJ-0000tE-M8 for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 11:33:01 +0000 IronPort-SDR: yhF2ZaLhNZe8AoJ1synS29p05wHRi0wL6GYjr7d5mQtrcQCI0V6hRPazo3F6VAcy66g1qcloUt p4GofNusGugA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 04:32:58 -0700 IronPort-SDR: 0gS0OaFJiuv3OfG2ljoqjSB4HKx6CLP4K3KFhfm6vWhg8PAp9Nw/f+wW4k3a8VLZLakldEI3/w +/CncU4PobkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="464700264" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 15 May 2020 04:32:55 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZYaH-006qe0-KA; Fri, 15 May 2020 14:32:57 +0300 Date: Fri, 15 May 2020 14:32:57 +0300 From: Andy Shevchenko To: Syed Nayyar Waris Subject: Re: [PATCH v6 0/4] Introduce the for_each_set_clump macro Message-ID: <20200515113257.GP185537@smile.fi.intel.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_043259_739648_F58675BF X-CRM114-Status: GOOD ( 19.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, amit.kucheria@verdurent.com, arnd@arndb.de, yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org, linus.walleij@linaro.org, daniel.lezcano@linaro.org, vilhelm.gray@gmail.com, michal.simek@xilinx.com, bgolaszewski@baylibre.com, rrichter@marvell.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, akpm@linux-foundation.org, rui.zhang@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 15, 2020 at 04:46:03AM +0530, Syed Nayyar Waris wrote: > This patchset introduces a new generic version of for_each_set_clump. > The previous version of for_each_set_clump8 used a fixed size 8-bit > clump, but the new generic version can work with clump of any size but > less than or equal to BITS_PER_LONG. The patchset utilizes the new macro > in several GPIO drivers. > > The earlier 8-bit for_each_set_clump8 facilitated a > for-loop syntax that iterates over a memory region entire groups of set > bits at a time. > > For example, suppose you would like to iterate over a 32-bit integer 8 > bits at a time, skipping over 8-bit groups with no set bit, where > XXXXXXXX represents the current 8-bit group: > > Example: 10111110 00000000 11111111 00110011 > First loop: 10111110 00000000 11111111 XXXXXXXX > Second loop: 10111110 00000000 XXXXXXXX 00110011 > Third loop: XXXXXXXX 00000000 11111111 00110011 > > Each iteration of the loop returns the next 8-bit group that has at > least one set bit. > > But with the new for_each_set_clump the clump size can be different from 8 bits. > Moreover, the clump can be split at word boundary in situations where word > size is not multiple of clump size. Following are examples showing the working > of new macro for clump sizes of 24 bits and 6 bits. > > Example 1: > clump size: 24 bits, Number of clumps (or ports): 10 > bitmap stores the bit information from where successive clumps are retrieved. > > /* bitmap memory region */ > 0x00aa0000ff000000; /* Most significant bits */ > 0xaaaaaa0000ff0000; > 0x000000aa000000aa; > 0xbbbbabcdeffedcba; /* Least significant bits */ > > Different iterations of for_each_set_clump:- > 'offset' is the bit position and 'clump' is the 24 bit clump from the > above bitmap. > Iteration first: offset: 0 clump: 0xfedcba > Iteration second: offset: 24 clump: 0xabcdef > Iteration third: offset: 48 clump: 0xaabbbb > Iteration fourth: offset: 96 clump: 0xaa > Iteration fifth: offset: 144 clump: 0xff > Iteration sixth: offset: 168 clump: 0xaaaaaa > Iteration seventh: offset: 216 clump: 0xff > Loop breaks because in the end the remaining bits (0x00aa) size was less > than clump size of 24 bits. > > In above example it can be seen that in iteration third, the 24 bit clump > that was retrieved was split between bitmap[0] and bitmap[1]. This example > also shows that 24 bit zeroes if present in between, were skipped (preserving > the previous for_each_set_macro8 behaviour). > > Example 2: > clump size = 6 bits, Number of clumps (or ports) = 3. > > /* bitmap memory region */ > 0x00aa0000ff000000; /* Most significant bits */ > 0xaaaaaa0000ff0000; > 0x0f00000000000000; > 0x0000000000000ac0; /* Least significant bits */ > > Different iterations of for_each_set_clump: > 'offset' is the bit position and 'clump' is the 6 bit clump from the > above bitmap. > Iteration first: offset: 6 clump: 0x2b > Loop breaks because 6 * 3 = 18 bits traversed in bitmap. > Here 6 * 3 is clump size * no. of clumps. Thank you! Overall looks good to me, though I gave tags per individual patches (I'm not familiar with that GPIO drivers, so, I may not tag them). > > Changes in v6: > - [Patch 2/4]: Make 'for loop' inside test_for_each_set_clump more > succinct. > > Changes in v5: > - [Patch 4/4]: Minor change: Hardcode value for better code readability. > > Changes in v4: > - [Patch 2/4]: Use 'for' loop in test function of for_each_set_clump. > - [Patch 3/4]: Minor change: Inline value for better code readability. > - [Patch 4/4]: Minor change: Inline value for better code readability. > > Changes in v3: > - [Patch 3/4]: Change datatype of some variables from u64 to unsigned long > in function thunderx_gpio_set_multiple. > > CHanges in v2: > - [Patch 2/4]: Unify different tests for 'for_each_set_clump'. Pass test data as > function parameters. > - [Patch 2/4]: Remove unnecessary bitmap_zero calls. > > Syed Nayyar Waris (4): > bitops: Introduce the the for_each_set_clump macro > lib/test_bitmap.c: Add for_each_set_clump test cases > gpio: thunderx: Utilize for_each_set_clump macro > gpio: xilinx: Utilize for_each_set_clump macro > > drivers/gpio/gpio-thunderx.c | 11 ++- > drivers/gpio/gpio-xilinx.c | 62 ++++++------- > include/asm-generic/bitops/find.h | 19 ++++ > include/linux/bitmap.h | 61 +++++++++++++ > include/linux/bitops.h | 13 +++ > lib/find_bit.c | 14 +++ > lib/test_bitmap.c | 142 ++++++++++++++++++++++++++++++ > 7 files changed, 288 insertions(+), 34 deletions(-) > > > base-commit: 5f458e572071a54841b93f41e25fbe8ded82df79 > -- > 2.26.2 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel