From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5AFEC433E0 for ; Fri, 15 May 2020 11:38:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90E35206D4 for ; Fri, 15 May 2020 11:38:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o9c29ZUS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90E35206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MEbGuKUIBn+NqPaOVzpMLBOUAdcHpHs340Jt5ChVRqA=; b=o9c29ZUSu1yzEn kGualTG3+L9NMQF0RK/nqk7NR7y5yyHYFIZc5A37r6CSkjP8HhflJK0ffxo8rPOr6lWAsB670gTh7 sQc/1beNORm0xlIZzd91cg8AO56zi1ysh6kHdqaIz206rvBIKOhcDyqmj+j4lBGYxzHJ9qs9BlQ8s H+suqMOwyMaSRMsVOi5PDlA4mYXwTXzN4gs294R8YHAgS4vLuBJbA6VgdJNp7GnZfZz2LJ144V+tI cZo3ivKAw84P95FzetwRlafQljM0/+bKWWq3Meibt5VgLZsYnxUUbevWrWCkdSdZKB/kkIEwbp8o/ RpQHn0l9w9+rdWMBlk6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYfd-0004o7-KZ; Fri, 15 May 2020 11:38:29 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZYfH-0004V8-QS; Fri, 15 May 2020 11:38:10 +0000 IronPort-SDR: co4hyqZ8C8w30k1oUW52pWlgkefR8DyLO2e2yCKFJxvl3etrT6UV16GgXTePa5/nSYcSsht0/q fg3eNo1x8hzw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 04:38:07 -0700 IronPort-SDR: 7syfHYZiSk8sdH8ji4fv9pM54Sp1BiN4RvBPVmxzksORhZghe3ut/diu/a4C7Nlf1zWtmcXfJu gIzg/VPBiymw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,395,1583222400"; d="scan'208";a="464877908" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 15 May 2020 04:38:05 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZYfI-006qgY-Gz; Fri, 15 May 2020 14:38:08 +0300 Date: Fri, 15 May 2020 14:38:08 +0300 From: Andy Shevchenko To: Fengping Yu Subject: Re: [PATCH v8] Add matrix keypad driver support for Mediatek SoCs Message-ID: <20200515113808.GQ185537@smile.fi.intel.com> References: <20200515062007.28346-1-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515062007.28346-1-fengping.yu@mediatek.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_043807_879926_B8C73592 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , Marco Felsch , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Yingjoe Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 15, 2020 at 02:20:04PM +0800, Fengping Yu wrote: > > Change since v7: > - specify compatible property as const string > - add maxItem in required property > - squash keypad example nodes > - sort header file with alphabetic order > - align all define values and add MTK_ prefix to make more uniform > - change debounce value to default 16ms if not specified in dts > - remove extra braces > - separate clk prepare as an internal driver function > - add special compatible string > - modify CONFIG_KEYBOARD_MTK_KPD=m to build keypad as ko module You forgot to address at least some of my comments... > > fengping.yu (3): > dt-bindings: Add keypad devicetree documentation > drivers: input: keyboard: Add mtk keypad driver > configs: defconfig: Add CONFIG_ng.yu (3): > dt-bindings: Add keypad devicetree documentation > drivers: input: keyboard: Add mtk keypad driver > configs: defconfig: Add CONFIG_KEYBOARD_MTK_KPD=m > > .../devicetree/bindings/input/mtk-kpd.yaml | 94 +++++++ > arch/arm64/configs/defconfig | 1 + > drivers/input/keyboard/Kconfig | 9 + > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/mtk-kpd.c | 231 ++++++++++++++++++ > 5 files changed, 336 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mtk-kpd.yaml > create mode 100644 drivers/input/keyboard/mtk-kpd.c > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel