From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5E5C433DF for ; Fri, 15 May 2020 12:21:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A0FF20709 for ; Fri, 15 May 2020 12:21:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qi07O7LM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A0FF20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5StVmWcCAYeLGE3pY2wBRbboCtYpMVR7B7TSmXOeh60=; b=qi07O7LMp29tUk as9r/VHV71DP+DVxiQGQunLLRxts0oQunBKkRHXmaxEO+Dxk6bDKlUZWqz4jo5hCbo0n0WutPShU3 GS0KxTL3f6PqcSqiRSzDx0K39Nf/OZl9z4kDIoo82Egw2kwAANI5E6cQj6IEmdcVGIkfoyJazggW8 gkNQkQc7qMvFQH/u009wcBumM6TzqjUjGnuhidtvsdSGg1vkVe9mSr26OKGhK678GNYwroxEBYCeH TlYLF2U1FxpycSKYN5eMoWqkZooCx6Ih38my6rdLbgZNdEyVG1pYVwichMaXOzva7DziWREy6KsGo XpFZKRkRbihF0674F/lg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZZKx-0005an-PF; Fri, 15 May 2020 12:21:11 +0000 Received: from 8bytes.org ([81.169.241.247] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZZKu-0005a4-VC for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 12:21:10 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id DEA45379; Fri, 15 May 2020 14:21:05 +0200 (CEST) Date: Fri, 15 May 2020 14:21:04 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Subject: Re: [PATCH 2/4] iommu/amd: Use pci_ats_supported() Message-ID: <20200515122104.GV18353@8bytes.org> References: <20200515104359.1178606-1-jean-philippe@linaro.org> <20200515104359.1178606-3-jean-philippe@linaro.org> <20200515120150.GU18353@8bytes.org> <20200515121124.GA784024@myrica> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515121124.GA784024@myrica> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_052109_154151_24DB19AC X-CRM114-Status: UNSURE ( 7.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.williamson@redhat.com, ashok.raj@intel.com, linux-pci@vger.kernel.org, robin.murphy@arm.com, iommu@lists.linux-foundation.org, bhelgaas@google.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 15, 2020 at 02:11:24PM +0200, Jean-Philippe Brucker wrote: > On Fri, May 15, 2020 at 02:01:50PM +0200, Joerg Roedel wrote: > > Hmm, but per patch 1, pci_ats_supported() does not check > > pci_ats_disabled(), or do I miss something? > > The commit message isn't clear. pci_ats_init() sets dev->ats_cap only if > !pci_ats_disabled(), so checking dev->ats_cap in pci_ats_supported() > takes pci_ats_disabled() into account. Right, so the patch is fine: Reviewed-by: Joerg Roedel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel