From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Amit Tomer <amittomer25@gmail.com>
Cc: devicetree@vger.kernel.org,
"André Przywara" <andre.przywara@arm.com>,
linux-actions@lists.infradead.org, cristian.ciocaltea@gmail.com,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700
Date: Mon, 18 May 2020 11:47:55 +0530 [thread overview]
Message-ID: <20200518061755.GA25113@mani> (raw)
In-Reply-To: <CABHD4K-MHs4jhL_9otJJ_xjC1uv1N20mnHqT39b2kob7WjZcVQ@mail.gmail.com>
On 0518, Amit Tomer wrote:
> Hi,
>
> > I recommend reading the DT spec, chapter 2.3.1 "compatible":
> > https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
>
> My point is more about, DT validation is not happy about this situation.
> For instance when I run dt-validate, do see following:
>
> /home/amit/work/kernel_work/linux/arch/arm64/boot/dts/actions/s700-cubieboard7.dt.yaml:
> mmc@e0210000: compatible: Additional items are not allowed
> ('actions,s700-mmc' was unexpected)
>
> and I am not sure if this is because DT and driver has different
> number of compatible strings.
>
Yeah, the DT YAML validation tool doesn't allow this. And there were patches
removing the additional compatible from DTS.
I don't know if the DT fallback is discouraged or not.
Anyway, is enough investigation done to justify that we need SoC specific tweaks
in the driver? I think I did look into the downstream code for s700/s500 while
upstreaming this driver and convinced myself that the same driver could be
reused without modifications.
Thanks,
Mani
> Thanks
> Amit
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-18 6:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 16:10 [PATCH v1 0/9] Add MMC and DMA support for Actions S700 Amit Singh Tomar
2020-05-14 16:10 ` [PATCH v1 1/9] dmaengine: Actions: get rid of bit fields from dma descriptor Amit Singh Tomar
2020-05-14 18:27 ` Vinod Koul
2020-05-14 18:34 ` Amit Tomer
2020-05-15 6:58 ` Vinod Koul
2020-05-15 7:46 ` Amit Tomer
2020-05-15 11:11 ` Amit Tomer
2020-05-14 16:10 ` [PATCH v1 2/9] dmaengine: Actions: Add support for S700 DMA engine Amit Singh Tomar
2020-05-14 17:02 ` André Przywara
2020-05-14 16:10 ` [PATCH v1 3/9] clk: actions: Add MMC clock-register reset bits Amit Singh Tomar
2020-05-14 16:10 ` [PATCH v1 4/9] arm64: dts: actions: do not merge disable sps node from S700 Amit Singh Tomar
2020-05-14 16:10 ` [PATCH v1 5/9] dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml Amit Singh Tomar
2020-05-15 15:54 ` André Przywara
2020-05-15 19:05 ` Amit Tomer
2020-05-15 19:24 ` Amit Tomer
2020-05-16 18:21 ` Amit Tomer
2020-05-14 16:10 ` [PATCH v1 6/9] arm64: dts: actions: Add DMA Controller for S700 Amit Singh Tomar
2020-05-14 16:10 ` [PATCH v1 7/9] dt-bindings: reset: s700: Add binding constants for mmc Amit Singh Tomar
2020-05-14 16:10 ` [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700 Amit Singh Tomar
2020-05-15 15:01 ` André Przywara
2020-05-15 18:41 ` Amit Tomer
2020-05-17 11:56 ` Amit Tomer
2020-05-17 16:42 ` André Przywara
2020-05-17 17:12 ` Amit Tomer
2020-05-17 21:30 ` André Przywara
2020-05-18 3:06 ` Amit Tomer
2020-05-18 6:17 ` Manivannan Sadhasivam [this message]
2020-05-18 8:29 ` André Przywara
2020-05-18 9:48 ` Andreas Färber
2020-05-14 16:10 ` [PATCH v1 9/9] arm64: dts: actions: Add uSD support for Cubieboard7 Amit Singh Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518061755.GA25113@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=amittomer25@gmail.com \
--cc=andre.przywara@arm.com \
--cc=cristian.ciocaltea@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).